ProjectCard Implemented #143
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minhngo3818
added
Frontend
minhngo3818
reviewed
Apr 16, 2023
minhngo3818
reviewed
Apr 16, 2023
minhngo3818
reviewed
Apr 16, 2023
minhngo3818
reviewed
Apr 16, 2023
minhngo3818
reviewed
Apr 16, 2023
minhngo3818
reviewed
Apr 16, 2023
minhngo3818
reviewed
Apr 16, 2023
Collaborator
minhngo3818
left a comment
minhngo3818
left a comment
There was a problem hiding this comment.
There is a lot of work to edit. Please address changes. Overall, it looks wonderful with the responsive cards!
minhngo3818
reviewed
May 1, 2023
| border-white | ||
| border-solid | ||
| w-10 h-10 | ||
| rounded-2xl |
Collaborator
There was a problem hiding this comment.
Suggested change
| rounded-2xl | |
| rounded-full |
minhngo3818
reviewed
May 1, 2023
| @apply border | ||
| border-white | ||
| border-solid | ||
| w-10 h-10 |
Collaborator
There was a problem hiding this comment.
Suggested change
| w-10 h-10 | |
| w-12 h-12 |
minhngo3818
reviewed
May 1, 2023
minhngo3818
reviewed
May 1, 2023
| <ProjectCardImg /> | ||
| </div> | ||
| <div className="flex flex-col gap-6"> | ||
| <p className="text-2xl">{title}</p> |
Collaborator
There was a problem hiding this comment.
Suggested change
| <p className="text-2xl">{title}</p> | |
| <p className="text-2xl font-bold">{title}</p> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new component ProjectCard is implemented which is fetching the fake Data Model to render the Project Cards.
Some colors are also added in tailwind.config.js.
TailwindCSS ,PostCSS and autoprefixer are upgraded to the latest version.