Repository navigation
fix(skills): name what to refresh in the custom-node validation slice - #1027
Conversation
|
Warning Review limit reached
This review includes 3 billable files and costs up to $0.75.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 37 minutes for your next included review. View limit details
Comment |
|
No changes needed for this. It's CodeRabbit's automatic "draft PR not reviewed" notice, not review feedback. The PR stays a draft until a maintainer has looked at it, and a CodeRabbit review can be triggered manually then. |
6145a65 to
fe1eba2
Compare
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
✅ No high-signal findings.
Panel: 6/6 reviewers contributed findings.
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 14 automatic and 15 manual. Updated by Swarmhost's agentic review process. |
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit fe1eba2 has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
PR Created by the Glary-Bot Agent
Why
Comfy agents tell users to refresh their ComfyUI tab when it isn't needed. The
comfy-custom-nodes-validationfallback skill said:There are two ways to misread that bare "refresh":
comfy nodes refresh: that re-pulls node annotations from comfy-complete and never touches/object_info(refresh_cmd→refresh_annotations()).What changes
object_info_stalemeans: the result was served from a cache after the live fetch failed. The action is to restart ComfyUI and re-run that same command, and to trust the catalog only once the warning is gone. It also says explicitly thatcomfy nodes refreshand a browser reload change neither. This matches the existing guidance incomfy/SKILL.mdand theobject_info_stalehint inerror_codes.py.custom_node_context_budget.jsonis updated to the slice's new size (826 → 987 bytes).test_custom_node_validation_names_what_to_refreshrejects a bare "restart … refresh" and any "refresh/reload the browser/page/tab" instruction, and pins the corrected wording. It fails onmain.Verification
ruff check .andruff format --check .are clean.pytest tests/comfy_cli/skills: 83 passed.pytest: 10168 passed, 6 failed. The same 6 fail onmain(tests/comfy_cli/agent/test_command.pypermissions tests andtest_http.py::test_an_unloadable_supplement_falls_through_to_the_platform_roots), so they're unrelated.Search notes
I also searched every bundled skill and all user-facing CLI output in this repo for refresh, reload or browser-tab advice. Nothing else tells an agent to have the user refresh. The custom-node slices already say "do not promise hot reload".
Related: Comfy-Org/cloud#14149 (agent prompt), Comfy-Org/ComfyUI_frontend#20903 (frontend auto-refresh after an agent restart).
Update
Rebased onto
main. Removed an internal ticket ID from the test docstring (it failed the public-repo hygiene scan).pytest tests/comfy_cli/skills: 83 passed; the new test fails withmain's skill text and passes here.