Skip to content

fix(skills): name what to refresh in the custom-node validation slice - #1027

Merged
christian-byrne merged 1 commit into
mainfrom
glary/pm-2119-unambiguous-catalog-refresh
Oct 18, 2026
Merged

christian-byrne merged 1 commit into
mainfrom
glary/pm-2119-unambiguous-catalog-refresh

Conversation

@christian-byrne

@christian-byrne christian-byrne commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

PR Created by the Glary-Bot Agent


Why

Comfy agents tell users to refresh their ComfyUI tab when it isn't needed. The comfy-custom-nodes-validation fallback skill said:

If the result reports object_info_stale, restart ComfyUI and refresh before treating the catalog as proof of what loaded.

There are two ways to misread that bare "refresh":

  • as a browser reload: the reported symptom;
  • as comfy nodes refresh: that re-pulls node annotations from comfy-complete and never touches /object_info (refresh_cmd → refresh_annotations()).

What changes

  • Skill text: it now says what object_info_stale means: the result was served from a cache after the live fetch failed. The action is to restart ComfyUI and re-run that same command, and to trust the catalog only once the warning is gone. It also says explicitly that comfy nodes refresh and a browser reload change neither. This matches the existing guidance in comfy/SKILL.md and the object_info_stale hint in error_codes.py.
  • Context-budget fixture: custom_node_context_budget.json is updated to the slice's new size (826 → 987 bytes).
  • New test: test_custom_node_validation_names_what_to_refresh rejects a bare "restart … refresh" and any "refresh/reload the browser/page/tab" instruction, and pins the corrected wording. It fails on main.

Verification

  • ruff check . and ruff format --check . are clean.
  • pytest tests/comfy_cli/skills: 83 passed.
  • Full pytest: 10168 passed, 6 failed. The same 6 fail on main (tests/comfy_cli/agent/test_command.py permissions tests and test_http.py::test_an_unloadable_supplement_falls_through_to_the_platform_roots), so they're unrelated.
  • Manual: this changes skill text only, with no CLI behaviour change. The installed-skill content is covered by the existing installer tests.

Search notes

I also searched every bundled skill and all user-facing CLI output in this repo for refresh, reload or browser-tab advice. Nothing else tells an agent to have the user refresh. The custom-node slices already say "do not promise hot reload".

Related: Comfy-Org/cloud#14149 (agent prompt), Comfy-Org/ComfyUI_frontend#20903 (frontend auto-refresh after an agent restart).

Update

Rebased onto main. Removed an internal ticket ID from the test docstring (it failed the public-repo hygiene scan). pytest tests/comfy_cli/skills: 83 passed; the new test fails with main's skill text and passes here.

@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

This review includes 3 billable files and costs up to $0.75.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 37 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: 83e58a64-a5da-4231-99b7-63e07d0cb821
📥 Commits

Reviewing files that changed from the base of the PR and between 05e40ef and fe1eba2.

📒 Files selected for processing: 3
  • comfy_cli/skills/comfy-custom-nodes-validation/SKILL.md
  • tests/comfy_cli/skills/fixtures/custom_node_context_budget.json
  • tests/comfy_cli/skills/test_installer.py
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@glary-bot

glary-bot Bot commented Oct 18, 2026

Copy link
Copy Markdown

No changes needed for this. It's CodeRabbit's automatic "draft PR not reviewed" notice, not review feedback. The PR stays a draft until a maintainer has looked at it, and a CodeRabbit review can be triggered manually then.

@christian-byrne
christian-byrne force-pushed the glary/pm-2119-unambiguous-catalog-refresh branch from 6145a65 to fe1eba2 Compare October 18, 2026 01:52
@christian-byrne christian-byrne changed the title fix(skills): name what to refresh in the custom-node validation slice (PM-2119) fix(skills): name what to refresh in the custom-node validation slice Oct 18, 2026
@christian-byrne
christian-byrne marked this pull request as ready for review October 18, 2026 01:52
@christian-byrne christian-byrne added the cursor-review Request Cursor bot review label Oct 18, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

✅ No high-signal findings.

Panel: 6/6 reviewers contributed findings.

@comfy-greenlight-bot

comfy-greenlight-bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Swarmhost agentic review

The detailed evaluation is available to employees in the internal Slack review thread.

Evaluation budget remaining for this pull request: 14 automatic and 15 manual.

Updated by Swarmhost's agentic review process.

@comfy-greenlight-bot comfy-greenlight-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request at head commit fe1eba2 has been reviewed and approved by Swarmhost's agentic review process.

The detailed evaluation is available to employees in the internal Slack review thread.

@christian-byrne
christian-byrne merged commit a622bfd into main Oct 18, 2026
39 checks passed
@christian-byrne
christian-byrne deleted the glary/pm-2119-unambiguous-catalog-refresh branch October 18, 2026 02:23
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cursor-review Request Cursor bot review greenlight

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants