Skip to content

fix: Add validation and consistent data structure for survey 'Other' options #5620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christian-byrne merged 1 commit into from
Sep 18, 2025
Merged

fix: Add validation and consistent data structure for survey 'Other' options #5620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 23 additions & 5 deletions src/platform/onboarding/cloud/CloudSurveyView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,13 @@
>
</div>
</div>
<div v-if="surveyData.useCase === 'other'" class="mt-4 ml-8">
<InputText
v-model="surveyData.useCaseOther"
class="w-full"
placeholder="Please specify"
Copy link
Contributor

@DrJKL DrJKL Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#5625
Once this goes in, the placeholder will be flagged as something to translate.

/>
</div>
</div>

<div class="flex gap-6 pt-4">
Expand Down Expand Up @@ -243,6 +250,7 @@ const isSubmitting = ref(false)
const surveyData = ref({
familiarity: '',
useCase: '',
useCaseOther: '',
industry: '',
industryOther: '',
making: [] as string[]
Expand All @@ -265,7 +273,8 @@ const purposeOptions = [
},
{ label: 'Client work (freelance)', value: 'client' },
{ label: 'My own workplace (in-house)', value: 'inhouse' },
{ label: 'Academic research', value: 'research' }
{ label: 'Academic research', value: 'research' },
{ label: 'Other', value: 'other' }
]

const industryOptions = [
Expand All @@ -290,7 +299,13 @@ const makingOptions = [

// Validation per step
const validStep1 = computed(() => !!surveyData.value.familiarity)
const validStep2 = computed(() => !!surveyData.value.useCase)
const validStep2 = computed(() => {
if (!surveyData.value.useCase) return false
if (surveyData.value.useCase === 'other') {
return !!surveyData.value.useCaseOther?.trim()
}
return true
})
const validStep3 = computed(() => {
if (!surveyData.value.industry) return false
if (surveyData.value.industry === 'other') {
Expand All @@ -314,13 +329,16 @@ const goTo = (step: number, activate: (val: string | number) => void) => {
const onSubmitSurvey = async () => {
try {
isSubmitting.value = true
// prepare payload: collapse "other" field
// prepare payload with consistent structure
const payload = {
familiarity: surveyData.value.familiarity,
useCase: surveyData.value.useCase,
useCase:
surveyData.value.useCase === 'other'
? surveyData.value.useCaseOther?.trim() || 'other'
: surveyData.value.useCase,
industry:
surveyData.value.industry === 'other'
? { type: 'other', text: surveyData.value.industryOther }
? surveyData.value.industryOther?.trim() || 'other'
: surveyData.value.industry,
making: surveyData.value.making
}
Expand Down
Loading