Skip to content

Conversation

@viva-jinyi
Copy link
Member

@viva-jinyi viva-jinyi commented Sep 17, 2025

Summary

  • Added validation to prevent users from proceeding when "Other" is selected but text input is empty
  • Changed data structure to send consistent string values to database instead of mixed objects
  • Both useCase and industry now send user input directly when "Other" is selected

Changes

  • Added useCaseOther field and input to survey form
  • Updated validStep2 to validate useCaseOther when useCase is 'other'
  • Modified submit payload to send string values consistently for both useCase and industry fields

Test plan

  • Select "Other" for use case without filling input → Next button disabled
  • Select "Other" for industry without filling input → Next button disabled
  • Fill in "Other" text inputs → Next button enabled
  • Submit survey with "Other" selections → Payload sends user input as string values

🤖 Generated with Claude Code

┆Issue is synchronized with this Notion page by Unito

@viva-jinyi viva-jinyi requested a review from a team as a code owner September 17, 2025 06:49
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 17, 2025
@github-actions
Copy link

github-actions bot commented Sep 17, 2025

🎭 Playwright Test Results

Some tests failed!

⏰ Completed at: 09/17/2025, 10:49:59 AM UTC

📊 Test Reports by Browser


⚠️ Please check the test reports for details on failures.

Copy link
Contributor

@DrJKL DrJKL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can they only pick one use case?
If it ends up being multiselect this logic will probably need to change.

<InputText
v-model="surveyData.useCaseOther"
class="w-full"
placeholder="Please specify"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#5625
Once this goes in, the placeholder will be flagged as something to translate.

@christian-byrne christian-byrne merged commit 16ebe33 into rh-test Sep 18, 2025
6 of 13 checks passed
@christian-byrne christian-byrne deleted the fix/survey-template branch September 18, 2025 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants