Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v4
with:
# Vite 4 requires Node 18; if you upgrade to Vite 5 bump this to 20
# Pinned via .nvmrc; keep CI aligned with production Node 20 baseline.
node-version-file: ".nvmrc"
cache: "npm"
cache-dependency-path: package-lock.json
Expand All @@ -93,7 +93,7 @@ jobs:
env:
# Placeholder – real URL is injected at deploy time via Hyperlift env
VITE_API_URL: https://spectracleanse.com
run: npx vite build
run: npm run build

- name: Upload build artifact
uses: actions/upload-artifact@v4
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/security.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: "18"
node-version-file: ".nvmrc"
cache: "npm"
cache-dependency-path: package-lock.json

Expand Down Expand Up @@ -49,4 +49,4 @@ jobs:
format: table
exit-code: "1"
ignore-unfixed: true
severity: "HIGH,CRITICAL"
severity: "HIGH,CRITICAL"
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,10 @@ Questions, partnerships, or enterprise enquiries: [hello@spectracleanse.com](mai

## Native Node deployment runtime

- Native Render/Node deployments should use **Node 20.20.2** (recommended) or a Node version within the supported engines range: `>=18 <23`.
- Native Render/Node deployments should use **Node 20.20.2** (recommended) or another **Node 20.x** release.
- If Render defaults your service to a newer Node release, set `NODE_VERSION=20.20.2` in the service environment.
- Node 24 is currently not supported for native installs in validation because `better-sqlite3` native compilation failed under Node 24.
- Docker deployments already pin Node 18 via the repo Dockerfile.
- Docker deployments already pin Node 20 via the repo Dockerfile.

---

Expand Down
2 changes: 1 addition & 1 deletion spectracleanse-engineering/docs/render-deploy-checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ This checklist covers both Render (web service) and Spaceship Hyperlift (both do
- [ ] Not Node 24 (better-sqlite3 native compilation incompatible)
- [ ] Build log confirms `v20.x.x` — not `v18.x.x` or `v24.x.x`

Note: `.github/workflows/ci.yml` uses Node 18 for CI. This diverges from the production pin. Do not use CI's Node version as a guide for the production runtime.
Note: CI workflows should use `.nvmrc` (`20.20.2`) so native modules (for example `better-sqlite3`) are validated on the same major version used in production.

---

Expand Down
Loading