Align CI and docs to Node 20 and make frontend build/test steps consistent#46
Merged
ChrisAdamsdevelopment merged 1 commit intoMay 24, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Sorry @ChrisAdamsdevelopment, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
better-sqlite3) early.vite buildin CI.Description
node-version-file: ".nvmrc"so scans run on Node 20.20.2 instead of a hardcoded Node 18. (.github/workflows/security.yml)..nvmrccomment and changed the build step tonpm run buildso the same npm script (tsc && vite build) runs in CI as locally. (.github/workflows/ci.yml).20.20.2) and that Docker now uses Node 20 base, removing stale Node 18 wording. (README.md)..nvmrcso native modules are validated on the production Node baseline. (spectracleanse-engineering/docs/render-deploy-checklist.md).Files changed:
.github/workflows/security.yml,.github/workflows/ci.yml,README.md,spectracleanse-engineering/docs/render-deploy-checklist.md.Testing
node -v->v20.20.2andnpm -v->11.4.2(used for successful verification). (Passed)npm ciunder Nodev24.15.0failed during native build ofbetter-sqlite3as expected, confirming Node 24 is unsupported. (Failed as expected)v20.20.2rannpm ci(with dev deps), which completed successfully. (Passed)npm run test:run(vitest run) under Node20.20.2and all tests passed: 3 test files, 7 tests (Passed).VITE_API_URL=https://spectracleanse.com npm run build(executestsc && vite build) under Node20.20.2and build completed withdist/artifacts present. (Passed)node --check server.jsandnode --check server/processor.jsunder Node20.20.2and both passed. (Passed)node server.jsthencurl -sf http://localhost:3001/api/healthand received{"status":"ok"}. (Passed)Notes / remaining risk: If a deploy platform runs
npm ci --omit=devfor the frontend build step, devDependencies (Vitest/jsdom/TypeScript/Vite) would be missing and the build/tests would fail; ensure build environments install devDependencies (CI uses fullnpm cifor build jobs).Codex Task