Update resource limits #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents people from explicity setting memory or cpu request to 0 for their containers. While such pods will be the first to be kicked out when the cluster is low on resources, they will continue to run for free at other times. With this in place the scheduler will reject the container from running with an appropriate message to the user.
This sets it such that the CPU to Memory ratio aligns with our CPU SU definition of 1 CPU to 4 Gi of Memory. Note that I lowered the CPU limits and request instead of only increasing the memory.
|
The manifests are copy pasted into the nerc-ocp-config repo, so you need to change it here too https://github.com/OCP-on-NERC/nerc-ocp-config/blob/ad7ae587560af0845b1aac30ce6c06587325b92e/acct-mgt/base/configmaps.yaml#L52 |
|
@knikolla okay, thanks for pointing that out. I guess once we have agreed here on what the numbers should be I can update it in the other place too. |
jtriley
approved these changes
Aug 8, 2024
|
Looks like microshift CI/CD failure is unrelated to this PR. |
joachimweyl
approved these changes
Aug 8, 2024
larsks
approved these changes
Aug 12, 2024
naved001
added a commit
to naved001/nerc-ocp-config
that referenced
this pull request
Aug 12, 2024
The default container size aligns with our SU definitions and now there's a minimum size for a container. Related: CCI-MOC/openshift-acct-mgt#102
naved001
added a commit
to naved001/nerc-ocp-config
that referenced
this pull request
Aug 21, 2024
The default container size aligns with our SU definitions and now there's a minimum size for a container. Related: CCI-MOC/openshift-acct-mgt#102
larsks
pushed a commit
to naved001/nerc-ocp-config
that referenced
this pull request
Aug 27, 2024
The default container size aligns with our SU definitions and now there's a minimum size for a container. Related: CCI-MOC/openshift-acct-mgt#102
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses nerc-project/operations#602 and nerc-project/coldfront-plugin-cloud#108
Feel free to suggest any other defaults or mininum values.