Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default limitrange for OpenShift pods to have the same ratios as used for SU definitions #108

Closed
naved001 opened this issue Jun 28, 2023 · 5 comments
Assignees

Comments

@naved001
Copy link
Contributor

naved001 commented Jun 28, 2023

right now it's 1CPU to 0.5 Gig of memory. We probably want it something like 0.5 CPU to 2Gig of memory. We could also find out the most common size and base the default on that with the correct ratio.

Edit:
Q1. What should the default pod size be? 0.5 CPU and 2 GiB RAM, or 0.25 CPU and 1 GiB RAM? It's best to keep it at 1:4 ratio so it aligns with our SU definitions. I will use these same to enforce as the minimum pod sizes here: nerc-project/operations#602

Q2. After this change is made, how will the current limitranges be updated? (Maybe that is outside the scope of this issue, but it we need to make that it's captured somewhere).

@joachimweyl
Copy link

@naved001 is this something you feel you could do next sprint with @knikolla as backup if you have questions?

@naved001
Copy link
Contributor Author

naved001 commented Oct 2, 2023

same answer: #106 (comment)

@joachimweyl joachimweyl changed the title Set default limitrange for openshift pods to have the same ratios as used for SU defintions Set default limitrange for OpenShift pods to have the same ratios as used for SU definitions Oct 11, 2023
@joachimweyl
Copy link

@naved001 please add questions to this issue so we can finalize and then create the PR.

@naved001
Copy link
Contributor Author

naved001 commented Aug 6, 2024

@jtriley I have proposed this PR to address this issue and nerc-project/operations#602

@naved001
Copy link
Contributor Author

closed by CCI-MOC/openshift-acct-mgt#102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants