-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multi-arch #17
Open
aliariff
wants to merge
3
commits into
BuoyantIO:main
Choose a base branch
from
aliariff:multiarch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,27 @@ | ||
FROM golang:1.11.6-stretch as golang | ||
ARG BUILDPLATFORM=linux/amd64 | ||
|
||
FROM --platform=$BUILDPLATFORM golang:1.11.6-stretch as golang | ||
WORKDIR /go/src/github.com/buoyantio/bb | ||
ADD . /go/src/github.com/buoyantio/bb | ||
|
||
RUN mkdir -p /out | ||
RUN ./bin/dep ensure | ||
RUN go build -o /out/bb . | ||
ARG TARGETARCH | ||
RUN GOOS=linux GOARCH=$TARGETARCH go build -o /out/bb . | ||
|
||
FROM debian:buster-20200514-slim | ||
RUN apt-get update && apt-get install -y --no-install-recommends \ | ||
curl \ | ||
dnsutils \ | ||
iptables \ | ||
jq \ | ||
nghttp2 \ | ||
ca-certificates && \ | ||
rm -rf /var/lib/apt/lists/* | ||
|
||
# We still rely on old iptables-legacy syntax. | ||
RUN update-alternatives --set iptables /usr/sbin/iptables-legacy \ | ||
&& update-alternatives --set ip6tables /usr/sbin/ip6tables-legacy | ||
|
||
FROM gcr.io/linkerd-io/base:2019-02-19.01 | ||
RUN apt-get update | ||
RUN apt-get install -y ca-certificates | ||
COPY --from=golang /out /out | ||
ENTRYPOINT ["/out/bb"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -124,3 +124,10 @@ You can then use `curl`to query the service: | |
|
||
$ curl `minikube -n bb-readme service bb-readme-gateway-svc --url` | ||
{"requestUid":"in:http-sid:point-to-point-channel-grpc:-1-h1:8080-66349706","payload":"BANANA"} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add a note and commands here to create the multiarch builder image? Something like what we have here: https://github.com/linkerd/linkerd2-proxy-init/blob/master/Makefile#L73 |
||
## Build Multi-Arch Images with Buildx | ||
|
||
docker buildx build . \ | ||
--platform linux/amd64,linux/arm64,linux/arm/v7 \ | ||
--push \ | ||
--tag buoyantio/bb:<version> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think of moving the
&&
to the same line asrm -rf
, like we had here? For me it's more readable, but take it or leave it