Support multi-arch #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ali Ariff <[email protected]>
cpretzer
suggested changes
Aug 12, 2020
Dockerfile
Outdated
| iptables \ | ||
| jq \ | ||
| nghttp2 \ | ||
| ca-certificates && \ |
There was a problem hiding this comment.
What do you think of moving the && to the same line as rm -rf, like we had here? For me it's more readable, but take it or leave it
| @@ -124,3 +124,10 @@ You can then use `curl`to query the service: | |||
|
|
|||
| $ curl `minikube -n bb-readme service bb-readme-gateway-svc --url` | |||
| {"requestUid":"in:http-sid:point-to-point-channel-grpc:-1-h1:8080-66349706","payload":"BANANA"} | |||
|
|
|||
There was a problem hiding this comment.
Can you add a note and commands here to create the multiarch builder image? Something like what we have here: https://github.com/linkerd/linkerd2-proxy-init/blob/master/Makefile#L73
Signed-off-by: Ali Ariff <[email protected]>
Signed-off-by: Ali Ariff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cpretzer @alpeb
Signed-off-by: Ali Ariff [email protected]