Skip to content

[BI-2009] - Dynamic Concatenation of Entity + ObsUnitID (Exp UI)#436

Merged
HMS17 merged 3 commits intofuture/1.2from
feature/BI-2009
May 7, 2025
Merged

[BI-2009] - Dynamic Concatenation of Entity + ObsUnitID (Exp UI)#436
HMS17 merged 3 commits intofuture/1.2from
feature/BI-2009

Conversation

@HMS17
Copy link
Contributor

@HMS17 HMS17 commented Apr 22, 2025

Description

Story: BI-2009 - Dynamic Concatenation of Entity + ObsUnitID (Exp UI)

Modified Dataset.vue to prefix the ObsUnitID label for the experimental dataset table with the respective observation level

Dependencies

bi-api: feature/BI-2009

Testing

UI Display

  • Open experiment details for experiments with different observation levels
  • In each case, ensure that in the table the ObsUnitID column header is prefixed with the correct observation level ( ObsUnitID) and that row values appear as expected

Export

  • Export dataset for experiments with different observation levels and different environments selected
  • In each case, ensure that the ObsUnitID column header in the exported file is prefixed with the correct observation level ( ObsUnitID) and that row values appear as expected

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run> alas since npm fix not in future/1.2, failing
  • I have run SiteImprove on pages impacted by changes

@HMS17 HMS17 marked this pull request as ready for review May 1, 2025 16:47
@HMS17 HMS17 requested review from davedrp and dmeidlin May 1, 2025 16:48
Copy link
Contributor

@dmeidlin dmeidlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unable to run bi-web because npx sort-package-json is failing.

@HMS17 HMS17 requested a review from dmeidlin May 6, 2025 17:58
@HMS17
Copy link
Contributor Author

HMS17 commented May 6, 2025

I'm unable to run bi-web because npx sort-package-json is failing.

Added serve.js fix on branch, strange that it treats it as a difference from the base branch when the base branch has the fix.

Copy link
Contributor

@dmeidlin dmeidlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The code ran and worked as expected.

@HMS17 HMS17 merged commit f01005b into future/1.2 May 7, 2025
1 check passed
@HMS17 HMS17 deleted the feature/BI-2009 branch May 7, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants