[BI-2009] - Dynamic Concatenation of Entity + ObsUnitID (Exp UI)#458
[BI-2009] - Dynamic Concatenation of Entity + ObsUnitID (Exp UI)#458HMS17 merged 37 commits intofuture/1.2from
Conversation
dmeidlin
left a comment
There was a problem hiding this comment.
The code in place looks good and fulfills the requirements of the card; however, changes to be made in 1.2 to the importer to support sub-entities will cause the export to break as implemented.
The issue is that neither the Create or Append workflows for importing experiments will use a column named ObsUnitID, so it will be removed from ExperimentObservation. For the export feature then, the dynamic observation unit column will need to be handled in a similar way to other dynamic columns like observation variables since ObsUnitID will no longer be a required static column.
ObsUnitID will be removed from ExpFileCOlumns and from ExperimentObservation.Columns, so in BrAPITrialService#ExportObservations the ObsUnitId column will not appear as an expected column here, and also in BrAPITrialService#createExportRow here.
BrAPITrtialService#dynamicUpdateObsUnitIDLabel will need to be changed from a method that mutates an existing column to a method that creates a new column, similar to BrAPITrialService#addObsVarColumns.
|
This branch doesn't have the new page size limit of 65,000 set in BrAPIDAOUtil that is needed for the brapi server develop branch, so I'm getting errors while running bi-api. We should probable rebase future1.2 so that it has Jason's changes. |
https://breedinginsight.atlassian.net/browse/BI-2631 new card made to handle these changes to limit scope of this card |
Description
Story: BI-2009 - Dynamic Concatenation of Entity + ObsUnitID (Exp UI)
Modifications to allow appending of respective observation level to ObsUnitID column when generating experiment file for export.
Added dynamicUpdateObsUnitIDLabel method to BrAPITrialService.java to prefix the column header in the exported file with the observation level
Overrode equals and hashCode for Column class to aid in modifying the correct column
Overrode hashCode for Country class due to noticing it lacking one when working on the Column hashCode override
Updated unit tests to account for changed column name in export
Dependencies
bi-web: feature/BI-2009
Testing
see bi-web
Checklist: