Skip to content

chore(deps): bump better-sqlite3 from 12.11.1 to 13.0.2 - #9

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/better-sqlite3-13.0.2
Closed

chore(deps): bump better-sqlite3 from 12.11.1 to 13.0.2#9
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/better-sqlite3-13.0.2

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Aug 2, 2026

Copy link
Copy Markdown
Contributor

Bumps better-sqlite3 from 12.11.1 to 13.0.2.

Release notes

Sourced from better-sqlite3's releases.

v13.0.2

What's Changed

New Contributors

Full Changelog: WiseLibs/better-sqlite3@v13.0.1...v13.0.2

v13.0.1

Full Changelog: WiseLibs/better-sqlite3@v13.0.0...v13.0.1

Fixed a regression in parameter binding where it would be overly strict and reject plain objects from other realms (e.g., in jest tests).

v13.0.0

Version 13.0.0 marks a major milestone, as it's the first version of better-sqlite3 to run on the N-API. This means prebuilt binaries should theoretically work across different versions of Node.js and Electron, and perhaps even other runtimes like Bun. As a result, we've removed the deprecated prebuild-install dependency, and now prebuilt binaries are published directly with the better-sqlite3 code itself. If your platform/architecture doesn't have a prebuilt binary, it should compile during install as before.

What's Changed

New Contributors

Full Changelog: WiseLibs/better-sqlite3@v12.12.0...v13.0.0

v12.12.0

What's Changed

[!WARNING]

BREAKING: Starting with Electron v43, binary assets will require glibc 2.41 or higher on Linux hosts.

Full Changelog: WiseLibs/better-sqlite3@v12.11.2...v12.12.0

v12.11.2

What's Changed

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [better-sqlite3](https://github.com/WiseLibs/better-sqlite3) from 12.11.1 to 13.0.2.
- [Release notes](https://github.com/WiseLibs/better-sqlite3/releases)
- [Commits](WiseLibs/better-sqlite3@v12.11.1...v13.0.2)

---
updated-dependencies:
- dependency-name: better-sqlite3
  dependency-version: 13.0.2
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Aug 2, 2026
@Booyaka101

Copy link
Copy Markdown
Owner

Closing — this bump can't pass, and the fix is a different version.

better-sqlite3 13.0.0–13.0.2 replaced prebuild-install || node-gyp rebuild with a bare node-gyp rebuild, and published zero prebuilt assets on those releases. So 13.0.2 compiles from source on every install. On node 22 / windows-latest — a required check here — the bundled node-gyp 11.5.0 can't detect VS 2026 (unknown version "undefined" found at C:\Program Files\Microsoft Visual Studio\18\Enterprise) and the build dies. Same reason as the earlier hold in revert(deps): hold better-sqlite3 at 12.

13.0.3 is the version that actually unblocks it: prebuilds are now shipped inside the npm tarball (prebuilds/win32-x64.node et al) and the install script is gone entirely — so it needs no allowScripts entry at all. It was published 2026-08-05, though, which is inside our own cooldown window, so I'm not pulling it in a day old. Dependabot will re-propose it; merge then.

@Booyaka101 Booyaka101 closed this Aug 6, 2026
@dependabot @github

dependabot Bot commented on behalf of github Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot
dependabot Bot deleted the dependabot/npm_and_yarn/better-sqlite3-13.0.2 branch August 6, 2026 15:35
@Booyaka101

Copy link
Copy Markdown
Owner

Correcting myself: the reason I gave above is wrong.

I read "no prebuilts" off the GitHub release assets for 13.x, which are empty. npm doesn't install from those — it installs the tarball, and the 13.0.2 tarball carries all 8 prebuilds including win32-x64. Registry metadata backs that up:

version scripts.install gypfile
13.0.0 / 13.0.1 node-gyp rebuild true
13.0.2 / 13.0.3 absent false

So 13.0.2 was already the fixed shape, and my "wait for 13.0.3" advice was pointless — the compile-from-source window was 13.0.0–13.0.1.

What I still can't explain is why this PR's CI ran node-gyp rebuild for 13.0.2 at all. npm ci against this exact package.json + lockfile on Windows, node 22, under npm 10.9.3, 10.9.8 and 11 installs 44 packages in ~2s with no compile — five clean attempts, no repro. The one input I can't reproduce locally is Dependabot's metadata-only lockfile rewrite.

#10 is the experiment: same bump, lockfile regenerated by a real npm install. If it goes green on node 22 / windows-latest, that difference was the cause.

Booyaka101 added a commit that referenced this pull request Aug 8, 2026
Re-opens what #9 closed, with a corrected reading of why #9 failed.

#9 was closed on the claim that 13.0.0-13.0.2 ship no prebuilt binaries. That
was wrong: it was read off the GitHub *release* assets, which are empty for
13.x, not off the npm tarball, which is what npm actually installs. Registry
metadata is unambiguous:

  13.0.0 / 13.0.1  scripts.install = "node-gyp rebuild"   gypfile = true
  13.0.2 / 13.0.3  scripts.install = absent                gypfile = false

and the 13.0.2 and 13.0.3 tarballs both carry all 8 prebuilds, win32-x64
included. So 13.0.2 is already the fixed shape — the compile-from-source window
was 13.0.0-13.0.1 only.

What that does not yet explain is why #9's CI ran `node-gyp rebuild` for
13.0.2 and died on VS 2026 detection under node 22. I could not reproduce it:
`npm ci` against #9's exact package.json + lockfile on Windows, node 22, under
npm 10.9.3, 10.9.8 and 11 installs 44 packages in ~2s with no compile. Five
clean attempts, no repro. This PR is the experiment that settles it — same
bump, but with a lockfile regenerated by a real `npm install` rather than
Dependabot's metadata-only rewrite, which is the one input I could not
reproduce locally. If CI is green, that difference was the cause.

Fallout of the move, all consistent with the install script being gone:
allowScripts drops better-sqlite3 entirely, script-lens.json records zero
packages with install-time behavior, and the lockfile loses 413 lines as the
prebuild-install subtree goes with it.

Offline tests pass. Cooldown: 13.0.3 clears the 72h window tomorrow.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant