deps: move better-sqlite3 to 13.x, and drop the install script with it - #10
Closed
Booyaka101 wants to merge 1 commit into
Closed
deps: move better-sqlite3 to 13.x, and drop the install script with it#10Booyaka101 wants to merge 1 commit into
Booyaka101 wants to merge 1 commit into
Conversation
Re-opens what #9 closed, with a corrected reading of why #9 failed. #9 was closed on the claim that 13.0.0-13.0.2 ship no prebuilt binaries. That was wrong: it was read off the GitHub *release* assets, which are empty for 13.x, not off the npm tarball, which is what npm actually installs. Registry metadata is unambiguous: 13.0.0 / 13.0.1 scripts.install = "node-gyp rebuild" gypfile = true 13.0.2 / 13.0.3 scripts.install = absent gypfile = false and the 13.0.2 and 13.0.3 tarballs both carry all 8 prebuilds, win32-x64 included. So 13.0.2 is already the fixed shape — the compile-from-source window was 13.0.0-13.0.1 only. What that does not yet explain is why #9's CI ran `node-gyp rebuild` for 13.0.2 and died on VS 2026 detection under node 22. I could not reproduce it: `npm ci` against #9's exact package.json + lockfile on Windows, node 22, under npm 10.9.3, 10.9.8 and 11 installs 44 packages in ~2s with no compile. Five clean attempts, no repro. This PR is the experiment that settles it — same bump, but with a lockfile regenerated by a real `npm install` rather than Dependabot's metadata-only rewrite, which is the one input I could not reproduce locally. If CI is green, that difference was the cause. Fallout of the move, all consistent with the install script being gone: allowScripts drops better-sqlite3 entirely, script-lens.json records zero packages with install-time behavior, and the lockfile loses 413 lines as the prebuild-install subtree goes with it. Offline tests pass. Cooldown: 13.0.3 clears the 72h window tomorrow. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Aug 6, 2026
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-opens what #9 closed, with a corrected reading of why #9 failed.
#9 was closed on the claim that 13.0.0-13.0.2 ship no prebuilt binaries. That
was wrong: it was read off the GitHub release assets, which are empty for
13.x, not off the npm tarball, which is what npm actually installs. Registry
metadata is unambiguous:
13.0.0 / 13.0.1 scripts.install = "node-gyp rebuild" gypfile = true
13.0.2 / 13.0.3 scripts.install = absent gypfile = false
and the 13.0.2 and 13.0.3 tarballs both carry all 8 prebuilds, win32-x64
included. So 13.0.2 is already the fixed shape — the compile-from-source window
was 13.0.0-13.0.1 only.
What that does not yet explain is why #9's CI ran
node-gyp rebuildfor13.0.2 and died on VS 2026 detection under node 22. I could not reproduce it:
npm ciagainst #9's exact package.json + lockfile on Windows, node 22, undernpm 10.9.3, 10.9.8 and 11 installs 44 packages in ~2s with no compile. Five
clean attempts, no repro. This PR is the experiment that settles it — same
bump, but with a lockfile regenerated by a real
npm installrather thanDependabot's metadata-only rewrite, which is the one input I could not
reproduce locally. If CI is green, that difference was the cause.
Fallout of the move, all consistent with the install script being gone:
allowScripts drops better-sqlite3 entirely, script-lens.json records zero
packages with install-time behavior, and the lockfile loses 413 lines as the
prebuild-install subtree goes with it.
Offline tests pass. Cooldown: 13.0.3 clears the 72h window tomorrow.
Co-Authored-By: Claude Opus 5 noreply@anthropic.com