Skip to content

deps: move better-sqlite3 to 13.x, and drop the install script with it - #10

Closed
Booyaka101 wants to merge 1 commit into
mainfrom
fix/better-sqlite3-13
Closed

deps: move better-sqlite3 to 13.x, and drop the install script with it#10
Booyaka101 wants to merge 1 commit into
mainfrom
fix/better-sqlite3-13

Conversation

@Booyaka101

Copy link
Copy Markdown
Owner

Re-opens what #9 closed, with a corrected reading of why #9 failed.

#9 was closed on the claim that 13.0.0-13.0.2 ship no prebuilt binaries. That
was wrong: it was read off the GitHub release assets, which are empty for
13.x, not off the npm tarball, which is what npm actually installs. Registry
metadata is unambiguous:

13.0.0 / 13.0.1 scripts.install = "node-gyp rebuild" gypfile = true
13.0.2 / 13.0.3 scripts.install = absent gypfile = false

and the 13.0.2 and 13.0.3 tarballs both carry all 8 prebuilds, win32-x64
included. So 13.0.2 is already the fixed shape — the compile-from-source window
was 13.0.0-13.0.1 only.

What that does not yet explain is why #9's CI ran node-gyp rebuild for
13.0.2 and died on VS 2026 detection under node 22. I could not reproduce it:
npm ci against #9's exact package.json + lockfile on Windows, node 22, under
npm 10.9.3, 10.9.8 and 11 installs 44 packages in ~2s with no compile. Five
clean attempts, no repro. This PR is the experiment that settles it — same
bump, but with a lockfile regenerated by a real npm install rather than
Dependabot's metadata-only rewrite, which is the one input I could not
reproduce locally. If CI is green, that difference was the cause.

Fallout of the move, all consistent with the install script being gone:
allowScripts drops better-sqlite3 entirely, script-lens.json records zero
packages with install-time behavior, and the lockfile loses 413 lines as the
prebuild-install subtree goes with it.

Offline tests pass. Cooldown: 13.0.3 clears the 72h window tomorrow.

Co-Authored-By: Claude Opus 5 noreply@anthropic.com

Re-opens what #9 closed, with a corrected reading of why #9 failed.

#9 was closed on the claim that 13.0.0-13.0.2 ship no prebuilt binaries. That
was wrong: it was read off the GitHub *release* assets, which are empty for
13.x, not off the npm tarball, which is what npm actually installs. Registry
metadata is unambiguous:

  13.0.0 / 13.0.1  scripts.install = "node-gyp rebuild"   gypfile = true
  13.0.2 / 13.0.3  scripts.install = absent                gypfile = false

and the 13.0.2 and 13.0.3 tarballs both carry all 8 prebuilds, win32-x64
included. So 13.0.2 is already the fixed shape — the compile-from-source window
was 13.0.0-13.0.1 only.

What that does not yet explain is why #9's CI ran `node-gyp rebuild` for
13.0.2 and died on VS 2026 detection under node 22. I could not reproduce it:
`npm ci` against #9's exact package.json + lockfile on Windows, node 22, under
npm 10.9.3, 10.9.8 and 11 installs 44 packages in ~2s with no compile. Five
clean attempts, no repro. This PR is the experiment that settles it — same
bump, but with a lockfile regenerated by a real `npm install` rather than
Dependabot's metadata-only rewrite, which is the one input I could not
reproduce locally. If CI is green, that difference was the cause.

Fallout of the move, all consistent with the install script being gone:
allowScripts drops better-sqlite3 entirely, script-lens.json records zero
packages with install-time behavior, and the lockfile loses 413 lines as the
prebuild-install subtree goes with it.

Offline tests pass. Cooldown: 13.0.3 clears the 72h window tomorrow.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@Booyaka101

Copy link
Copy Markdown
Owner Author

Superseded by #11, which was stacked on this branch and shipped this commit as part of the 0.4.0 release. #11 was rebase-merged so the SHA changed and GitHub could not auto-close this one. better-sqlite3 is on 13.0.3 on main.

@Booyaka101 Booyaka101 closed this Aug 8, 2026
@Booyaka101
Booyaka101 deleted the fix/better-sqlite3-13 branch August 8, 2026 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant