Fix empty list in reports #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* this is a temporary solution until BlueBrain/libsonata#84 is done
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 1146 1151 +5
=========================================
+ Hits 1146 1151 +5
Continue to review full report at Codecov.
|
wizmer
reviewed
Apr 8, 2020
bluepysnap/frame_report.py
Outdated
Comment on lines
215
to
218
| if group == []: | ||
| # Only solution to return an empty list from self._frame_population.get | ||
| # see: https://github.com/BlueBrain/libsonata/issues/84 | ||
| return np.array([-2]) |
There was a problem hiding this comment.
You could define
def empty_list():
'''Only solution to return an empty list from self._frame_population.get
see: https://github.com/BlueBrain/libsonata/issues/84
'''
return np.array([-2])And use it everywhere, so that you won't have to look for np.array([-2]) the day you need to fix it, and you don't need to rewrite the comment everytime you need it.
wizmer
approved these changes
Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python Spike/ReportPopulation .get() behavior with empty list of ids libsonata#84 is done