Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated bison commands #1221

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

JCGoran
Copy link
Contributor

@JCGoran JCGoran commented Mar 18, 2024

TODO:

  • according to the docs, updating name-prefix to api.prefix is a bit non-trivial, and a naive fix results in compilation errors. For reference, here's the relevant section:
    The '%name-prefix "xx"' directive is deprecated in favor of '%define
    api.prefix {xx}' since Bison 3.0, but no warning was issued.  These
    directives are slightly different, you might need to adjust your code.
    %name-prefix renames only symbols with external linkage, while api.prefix
    also renames types and macros, including YYDEBUG, YYTOKENTYPE,
    yytokentype, YYSTYPE, YYLTYPE, etc.
    
    Users of Flex that move from '%name-prefix "xx"' to '%define api.prefix
    {xx}' will typically have to update YY_DECL from
    
    #define YY_DECL int xxlex (YYSTYPE *yylval, YYLTYPE *yylloc)
    
    to
    
    #define YY_DECL int xxlex (XXSTYPE *yylval, XXLTYPE *yylloc)
    

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.30%. Comparing base (7c4a829) to head (2eb369a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1221   +/-   ##
=======================================
  Coverage   86.30%   86.30%           
=======================================
  Files         178      178           
  Lines       13263    13263           
=======================================
  Hits        11446    11446           
  Misses       1817     1817           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

@bbpbuildbot

This comment has been minimized.

@alkino
Copy link
Member

alkino commented May 16, 2024

I never changed this one because Ubuntu still have old bison, IIRC

@JCGoran
Copy link
Contributor Author

JCGoran commented May 16, 2024

According to https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2004-Readme.md the Ubuntu runner should have Bison 3.5.1, so we should be good as far as versions are concerned.

bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request May 24, 2024
@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #212633 (:white_check_mark:) have been uploaded here!

Status and direct links:

Copy link
Contributor

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never changed this one because Ubuntu still have old bison, IIRC

@alkino : I remember an old discussion where I was included to support previous versions. Looking at your comment here: #717 (comment), I guess now it's reasonable to support Ubuntu >= 20. With NEURON, users get NMODL via pip install anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants