-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated bison commands #1221
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1221 +/- ##
=======================================
Coverage 86.30% 86.30%
=======================================
Files 178 178
Lines 13263 13263
=======================================
Hits 11446 11446
Misses 1817 1817 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I never changed this one because Ubuntu still have old bison, IIRC |
According to https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2004-Readme.md the Ubuntu runner should have Bison 3.5.1, so we should be good as far as versions are concerned. |
Logfiles from GitLab pipeline #212633 (:white_check_mark:) have been uploaded here! Status and direct links: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I never changed this one because Ubuntu still have old bison, IIRC
@alkino : I remember an old discussion where I was included to support previous versions. Looking at your comment here: #717 (comment), I guess now it's reasonable to support Ubuntu >= 20. With NEURON, users get NMODL via pip install
anyway.
TODO:
name-prefix
toapi.prefix
is a bit non-trivial, and a naive fix results in compilation errors. For reference, here's the relevant section: