Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add 'replace_pattern' entry for DictComparator and several related save capabilities #53

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

adrien-berchet
Copy link
Member

Description

  • Add some save() capabilities to the comparators based on the DictComparator.
  • Add an optional replace_pattern entry to the comparators based on the DictComparator.

Checklist

This pull request is:

  • A documentation / typographical error fix
    • Good to go, no issue or tests are needed
  • A short code fix
    • Please include: Fixes: #<issue number> in the description if it solves an existing issue
      (which must include a complete example of the issue).
    • Please include tests that fail with the main branch and pass with the provided fix.
  • A new feature implementation or update an existing feature
    • Please include: Fixes: #<issue number> in the description if it solves an existing issue
      (which must include a complete example of the feature).
    • Please include tests that cover every lines of the new/updated feature.
    • Please update the documentation to describe the new/updated feature.

@adrien-berchet adrien-berchet merged commit 2ad26ef into main Feb 5, 2024
7 checks passed
@adrien-berchet adrien-berchet deleted the dict_save branch February 5, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant