[Z_Master_Skills] Fix tiered solar cell crafting#2
Open
rv-jgentile wants to merge 3 commits into
Open
Conversation
rv-jgentile
commented
Sep 6, 2024
| <!-- <passive_effect name="CraftingIngredientCount" level="5,6" operation="base_add" value="10,50" tags="resourceForgedSteel"/> --> | ||
| <!-- </effect_group> --> | ||
| <!-- </recipe> --> | ||
| <recipe name="solarCell" count="1" craft_time="1500" craft_area="workbench" tags="learnable,perkMachineGunner"> |
Author
There was a problem hiding this comment.
Suggested change
| <recipe name="solarCell" count="1" craft_time="1500" craft_area="workbench" tags="learnable,perkMachineGunner"> | |
| <recipe name="solarCell" count="1" craft_time="1500" craft_area="workbench" tags="learnable,perkAdvancedEngineering"> | |
@BlackRabbitMsk I didn't want to play with this because it's unrelated to the fix in this PR, but is perkMachineGunner correct here? Should this be perkAdvancedEngineering (I think?) instead?
I'm still learning my way around these XMLs but I figured I'd mention it while this PR's open anyway. I added it as a suggestion so you can just click it to update the line if I'm correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussed in length on discord, but I think TL;DR is that CraftingTier's first level is the tier 2 unlock, since the tier 1 unlock is already defined in RecipeTagUnlocked. It also seems it needs to end in the same value as
max_levelfor the skill...? Fun times.¯\_(ツ)_/¯