Skip to content

Update baseSlider.ts to send target/currentTarget to onValueChangedObservable #17323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 21, 2025
+1 −2
Merged

Update baseSlider.ts to send target/currentTarget to onValueChangedObservable #17323

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aae8a9d
Update baseSlider.ts
HiGregSmith Oct 21, 2025
7e1a3da
Update baseSlider.ts
HiGregSmith Oct 21, 2025
11d80ed
Update baseSlider.ts
HiGregSmith Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/dev/gui/src/2D/controls/sliders/baseSlider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ export class BaseSlider extends Control {

this._value = value;
this._markAsDirty();
this.onValueChangedObservable.notifyObservers(this._value);
this.onValueChangedObservable.notifyObservers(this._value, undefined, this, this);
}

/**Gets or sets a boolean indicating if the slider should be vertical or horizontal */
Expand Down Expand Up @@ -326,7 +326,6 @@ export class BaseSlider extends Control {
if (this._pointerIsDown && !this.isReadOnly) {
this._updateValueFromPointer(coordinates.x, coordinates.y);
}

super._onPointerMove(target, coordinates, pointerId, pi);
}

Expand Down