Skip to content

Conversation

@HiGregSmith
Copy link
Contributor

@HiGregSmith HiGregSmith commented Oct 21, 2025

Added target and currentTarget properties to slider onValueChangedObservable.

Test with this playground: https://playground.babylonjs.com/?snapshot=refs%2Fpull%2F17323%2Fmerge#UBZNMP%230

See this forum post for more details: https://forum.babylonjs.com/t/obtain-gui-component-within-onvaluechangedobservable-on-slider-and-colorpicker/61045/6

Added target and currentTarget properties to slider onValueChangedObservable.
@bjsplat
Copy link
Collaborator

bjsplat commented Oct 21, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 21, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 21, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 21, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 21, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 21, 2025

removed final newline (was added by github)
Removed final newline
@bjsplat
Copy link
Collaborator

bjsplat commented Oct 21, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 21, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 21, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 21, 2025

@georginahalpern georginahalpern changed the title Update baseSlider.ts Update baseSlider.ts to send target/currentTarget to onValueChangedObservable Oct 21, 2025
@sebavan sebavan merged commit 65e6978 into BabylonJS:master Oct 21, 2025
20 checks passed
sebavan pushed a commit to sebavan/Babylon.js that referenced this pull request Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants