-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IES shader #15952
IES shader #15952
Conversation
…der.ts Co-authored-by: Popov72 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 14 changed files in this pull request and generated no suggestions.
Files not reviewed (8)
- packages/dev/core/src/Shaders/ShadersInclude/lightFragment.fx: Language not supported
- packages/dev/core/src/Shaders/ShadersInclude/lightFragmentDeclaration.fx: Language not supported
- packages/dev/core/src/Shaders/ShadersInclude/lightUboDeclaration.fx: Language not supported
- packages/dev/core/src/Shaders/ShadersInclude/lightsFragmentFunctions.fx: Language not supported
- packages/dev/core/src/ShadersWGSL/ShadersInclude/lightFragment.fx: Language not supported
- packages/dev/core/src/ShadersWGSL/ShadersInclude/lightUboDeclaration.fx: Language not supported
- packages/dev/core/src/ShadersWGSL/ShadersInclude/lightsFragmentFunctions.fx: Language not supported
- packages/tools/tests/test/visualization/config.json: Language not supported
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15952/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/15952/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/15952/merge#BCU1XR#0 |
Visualization tests for WebGPU (Experimental) |
WebGL2 visualization test reporter: |
Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at If tests were successful afterwards, this report might not be available anymore. |
Love it !!! just missing PBR and Good to go !!! |
All done! |
packages/dev/core/src/Shaders/ShadersInclude/pbrDirectLightingFalloffFunctions.fx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add a test with a weird IES shape ? maybe once the gltf is in ?
Yes that test will be with the gltf loader:) |
Visualization tests for WebGPU (Experimental) |
WebGL2 visualization test reporter: |
Associated with #15000