Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IES shader #15952

Merged
merged 18 commits into from
Dec 5, 2024
Merged

IES shader #15952

merged 18 commits into from
Dec 5, 2024

Conversation

deltakosh
Copy link
Contributor

Associated with #15000

@deltakosh deltakosh requested review from sebavan and Copilot December 4, 2024 22:58
@deltakosh deltakosh changed the title Ies shader IES shader Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 14 changed files in this pull request and generated no suggestions.

Files not reviewed (8)
  • packages/dev/core/src/Shaders/ShadersInclude/lightFragment.fx: Language not supported
  • packages/dev/core/src/Shaders/ShadersInclude/lightFragmentDeclaration.fx: Language not supported
  • packages/dev/core/src/Shaders/ShadersInclude/lightUboDeclaration.fx: Language not supported
  • packages/dev/core/src/Shaders/ShadersInclude/lightsFragmentFunctions.fx: Language not supported
  • packages/dev/core/src/ShadersWGSL/ShadersInclude/lightFragment.fx: Language not supported
  • packages/dev/core/src/ShadersWGSL/ShadersInclude/lightUboDeclaration.fx: Language not supported
  • packages/dev/core/src/ShadersWGSL/ShadersInclude/lightsFragmentFunctions.fx: Language not supported
  • packages/tools/tests/test/visualization/config.json: Language not supported
@bjsplat
Copy link
Collaborator

bjsplat commented Dec 4, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 4, 2024

@deltakosh deltakosh requested a review from Popov72 December 4, 2024 23:19
@bjsplat
Copy link
Collaborator

bjsplat commented Dec 4, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 4, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 4, 2024

Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15952/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@deltakosh deltakosh enabled auto-merge (squash) December 4, 2024 23:29
@sebavan
Copy link
Member

sebavan commented Dec 5, 2024

Love it !!! just missing PBR and Good to go !!!

@deltakosh
Copy link
Contributor Author

All done!

Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a test with a weird IES shape ? maybe once the gltf is in ?

@deltakosh
Copy link
Contributor Author

Yes that test will be with the gltf loader:)

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 5, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 5, 2024

@deltakosh deltakosh merged commit af7fcf3 into master Dec 5, 2024
13 of 14 checks passed
@deltakosh deltakosh deleted the ies-shader branch December 5, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants