Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken nightly Native #15974

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

CedricGuillemet
Copy link
Contributor

@CedricGuillemet CedricGuillemet commented Dec 10, 2024

fix native issue introduced with #15952
No support for bias parameter with glsl texture function and bias value is 0 -> removed.

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 10, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@CedricGuillemet CedricGuillemet changed the title Fix Native nightly Fix broken nightly Native Dec 10, 2024
@bjsplat
Copy link
Collaborator

bjsplat commented Dec 10, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 10, 2024

Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15974/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 10, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 10, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 10, 2024

Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15974/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

1 similar comment
@bjsplat
Copy link
Collaborator

bjsplat commented Dec 10, 2024

Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15974/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not have the same meaning. cc @deltakosh to validate but I guess it is all good.

We should just ensure we do not generate mipmaps for the texture.

@deltakosh
Copy link
Contributor

Yes it is fine, I do not build the mipmap for this one so no problem

@RaananW RaananW merged commit 81e2c3d into BabylonJS:master Dec 10, 2024
12 of 14 checks passed
@CedricGuillemet
Copy link
Contributor Author

Did you mean to use textureLod instead @deltakosh ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants