Skip to content

[EH] Set AMQP Client Link Max Message Size to 0 #43462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 21, 2025
+4 −1
Merged

[EH] Set AMQP Client Link Max Message Size to 0 #43462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8890b3f
no restriction on max message size in amqp attach
PIRO-V Oct 16, 2025
ff1fd4b
eh constant changed correctly, sb change reverted
PIRO-V Oct 16, 2025
079f50d
log addition
PIRO-V Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/eventhub/azure-eventhub/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

- Fixed a bug where service errors were incorrectly required and expected to have info/description fields.
- Fixed a bug so that the BufferedProducer ThreadPoolExecutor uses one worker per partition. ([#38961](https://github.com/Azure/azure-sdk-for-python/issues/38961))
- Fixed a bug in the EventHub client where the maximum message size negotiation during the AMQP attach frame was handled incorrectly. The client now correctly sends a max message size of 0 (unlimited), allowing the server to apply its internal limit (20 MB) as intended.

### Other Changes

Expand Down
3 changes: 2 additions & 1 deletion sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
OUTGOING_WINDOW,
DEFAULT_AUTH_TIMEOUT,
MESSAGE_DELIVERY_DONE_STATES,
LINK_MAX_MESSAGE_SIZE
)

from .management_operation import ManagementOperation
Expand Down Expand Up @@ -576,7 +577,7 @@ class SendClient(AMQPClient):
def __init__(self, hostname, target, **kwargs):
self.target = target
# Sender and Link settings
self._max_message_size = kwargs.pop("max_message_size", MAX_FRAME_SIZE_BYTES)
self._max_message_size = kwargs.pop("max_message_size", LINK_MAX_MESSAGE_SIZE)
self._link_properties = kwargs.pop("link_properties", None)
self._link_credit = kwargs.pop("link_credit", None)
super(SendClient, self).__init__(hostname, **kwargs)
Expand Down
1 change: 1 addition & 0 deletions sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
#: size until they have agreed a definitive maximum frame size for that Connection.
MIN_MAX_FRAME_SIZE = 512
MAX_FRAME_SIZE_BYTES = 1024 * 1024
LINK_MAX_MESSAGE_SIZE = 0
MAX_CHANNELS = 65535
INCOMING_WINDOW = 64 * 1024
OUTGOING_WINDOW = 64 * 1024
Expand Down