[EH] Set AMQP Client Link Max Message Size to 0 #43462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PIRO-V
requested review from
EldertGrootenboer,
axisc,
hmlam and
sjkwak
as code owners
There was a problem hiding this comment.
Pull Request Overview
This pull request modifies the EventHub AMQP client to set the link maximum message size to 0, effectively removing any default size limit. This allows the server to apply its own internal 20 MB limit instead of having the client impose a potentially smaller limit.
Key changes:
- Introduces a new constant
LINK_MAX_MESSAGE_SIZE = 0 - Updates the SendClient to use this new constant instead of
MAX_FRAME_SIZE_BYTESfor the default max message size
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| sdk/servicebus/azure-servicebus/azure/servicebus/_pyamqp/constants.py | Adds new constant LINK_MAX_MESSAGE_SIZE = 0 to define unlimited message size |
| sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/client.py | Updates SendClient to import and use the new constant for default max message size |
|
/azp run python - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kashifkhan
approved these changes
Oct 20, 2025
kashifkhan
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request ensures that the EventHub client link max size is set to 0.
This change prevents any default maximum link size from being applied, which is required for proper client behavior in our environment.
The client initiates communication by sending an Attach command to the server, including specific configuration settings. Upon receiving this command, the server processes the information, performs a minimum value calculation based on the provided parameters, and then generates a response that is sent back to the client.
Our change modifies the client-side request to explicitly send a value of 0 for the maximum message size. By doing this, the server interprets the value as “no limit” on the message size. When the server receives this request, it performs its minimum value calculation based on the requested settings. After completing this calculation, the server enforces its internal 20 MB limit on the message size and returns the resulting configuration back to the client.