Moved swagger specs from resources to solutions folder. #19826

vayada · 2022-07-19T06:39:01Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2022-07-19T06:39:04Z

Hi, @vayada Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2022-07-19T06:39:05Z

Swagger Validation Report

️❌BreakingChange: 13 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.9.6)]	new version	base version
managedapplications.json	2021-07-01(d295853)	2021-07-01(main)

Rule	Message
`❌` 1011 - AddingResponseCode	The new version adds a response code '404'. New: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L100:11
`❌` 1011 - AddingResponseCode	The new version adds a response code '202'. New: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L150:11
`❌` 1011 - AddingResponseCode	The new version adds a response code '404'. New: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L310:11
`❌` 1011 - AddingResponseCode	The new version adds a response code '404'. New: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L868:11
`❌` 1012 - RemovedResponseCode	The new version removes the response code '202' Old: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L342:11
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'provisioningState' renamed or removed? New: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L1726:7 Old: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L1176:7
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L635:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L1198:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L1262:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L1321:5
`❌` 1044 - XmsLongRunningOperationChanged	The new version has a different 'x-ms-longrunning-operation' value than the previous one. New: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L224:7 Old: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L217:7
`❌` 1044 - XmsLongRunningOperationChanged	The new version has a different 'x-ms-longrunning-operation' value than the previous one. New: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L328:7 Old: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L310:7
`❌` 1044 - XmsLongRunningOperationChanged	The new version has a different 'x-ms-longrunning-operation' value than the previous one. New: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L368:7 Old: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L354:7

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️❌LintDiff: 393 Errors, 19 Warnings failed [Detail]

compared tags (via openapi-validator v1.13.0)	new version	base version
package-managedapplications-2021-07	package-managedapplications-2021-07(d295853)	package-managedapplications-2021-07(main)
package-managedapplications-2021-02	package-managedapplications-2021-02(d295853)	default(main)
package-managedapplications-2020-08	package-managedapplications-2020-08(d295853)	default(main)
package-managedapplications-2019-07	package-managedapplications-2019-07(d295853)	default(main)
package-managedapplications-2018-09	package-managedapplications-2018-09(d295853)	default(main)
package-managedapplications-2018-06	package-managedapplications-2018-06(d295853)	default(main)
package-managedapplications-2018-03	package-managedapplications-2018-03(d295853)	default(main)
package-managedapplications-2018-02	package-managedapplications-2018-02(d295853)	default(main)
package-managedapplications-2017-12	package-managedapplications-2017-12(d295853)	default(main)
package-managedapplications-2017-09	package-managedapplications-2017-09(d295853)	default(main)

The following errors/warnings are introduced by current PR:

Only 14 items are listed, please refer to log for more details.

Rule	Message
`❌` R3007 - PutGetPatchResponseSchema	/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Solutions/applications/{applicationName} has different responses for PUT/GET/PATCH operations. The PUT/GET/PATCH operations must have same schema response. Location: Microsoft.Solutions/preview/2018-09-01-preview/managedapplications.json#L73
`❌` R3007 - PutGetPatchResponseSchema	/{applicationId} has different responses for PUT/GET/PATCH operations. The PUT/GET/PATCH operations must have same schema response. Location: Microsoft.Solutions/preview/2018-09-01-preview/managedapplications.json#L746
`❌` R3007 - PutGetPatchResponseSchema	/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Solutions/applications/{applicationName} has different responses for PUT/GET/PATCH operations. The PUT/GET/PATCH operations must have same schema response. Location: Microsoft.Solutions/preview/2020-08-21-preview/managedapplications.json#L73
`❌` R3007 - PutGetPatchResponseSchema	/{applicationId} has different responses for PUT/GET/PATCH operations. The PUT/GET/PATCH operations must have same schema response. Location: Microsoft.Solutions/preview/2020-08-21-preview/managedapplications.json#L742
`❌` R3007 - PutGetPatchResponseSchema	/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Solutions/applications/{applicationName} has different responses for PUT/GET/PATCH operations. The PUT/GET/PATCH operations must have same schema response. Location: Microsoft.Solutions/preview/2021-02-01-preview/managedapplications.json#L73
`❌` R3007 - PutGetPatchResponseSchema	/{applicationId} has different responses for PUT/GET/PATCH operations. The PUT/GET/PATCH operations must have same schema response. Location: Microsoft.Solutions/preview/2021-02-01-preview/managedapplications.json#L904
`❌` R3007 - PutGetPatchResponseSchema	/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Solutions/applications/{applicationName} has different responses for PUT/GET/PATCH operations. The PUT/GET/PATCH operations must have same schema response. Location: Microsoft.Solutions/stable/2017-09-01/managedapplications.json#L73
`❌` R3007 - PutGetPatchResponseSchema	/{applicationId} has different responses for PUT/GET/PATCH operations. The PUT/GET/PATCH operations must have same schema response. Location: Microsoft.Solutions/stable/2017-09-01/managedapplications.json#L753
`❌` R3007 - PutGetPatchResponseSchema	/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Solutions/applications/{applicationName} has different responses for PUT/GET/PATCH operations. The PUT/GET/PATCH operations must have same schema response. Location: Microsoft.Solutions/stable/2017-12-01/managedapplications.json#L73
`❌` R3007 - PutGetPatchResponseSchema	/{applicationId} has different responses for PUT/GET/PATCH operations. The PUT/GET/PATCH operations must have same schema response. Location: Microsoft.Solutions/stable/2017-12-01/managedapplications.json#L746
`❌` R3007 - PutGetPatchResponseSchema	/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Solutions/applications/{applicationName} has different responses for PUT/GET/PATCH operations. The PUT/GET/PATCH operations must have same schema response. Location: Microsoft.Solutions/stable/2018-02-01/managedapplications.json#L73
`❌` R3007 - PutGetPatchResponseSchema	/{applicationId} has different responses for PUT/GET/PATCH operations. The PUT/GET/PATCH operations must have same schema response. Location: Microsoft.Solutions/stable/2018-02-01/managedapplications.json#L746
`❌` R3007 - PutGetPatchResponseSchema	/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Solutions/applications/{applicationName} has different responses for PUT/GET/PATCH operations. The PUT/GET/PATCH operations must have same schema response. Location: Microsoft.Solutions/stable/2018-03-01/managedapplications.json#L73
`❌` R3007 - PutGetPatchResponseSchema	/{applicationId} has different responses for PUT/GET/PATCH operations. The PUT/GET/PATCH operations must have same schema response. Location: Microsoft.Solutions/stable/2018-03-01/managedapplications.json#L746

The following errors/warnings exist before current PR submission:

Only 14 items are listed, please refer to log for more details.

Rule	Message
⚠️ R1003 - ListInOperationName	Since operation 'ListOperations' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Solutions/preview/2018-09-01-preview/managedapplications.json#L42
⚠️ R1003 - ListInOperationName	Since operation 'ListOperations' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Solutions/preview/2020-08-21-preview/managedapplications.json#L42
⚠️ R1003 - ListInOperationName	Since operation 'ListOperations' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Solutions/preview/2021-02-01-preview/managedapplications.json#L42
⚠️ R1003 - ListInOperationName	Since operation 'ListOperations' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Solutions/stable/2017-09-01/managedapplications.json#L42
⚠️ R1003 - ListInOperationName	Since operation 'ListOperations' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Solutions/stable/2017-12-01/managedapplications.json#L42
⚠️ R1003 - ListInOperationName	Since operation 'ListOperations' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Solutions/stable/2018-02-01/managedapplications.json#L42
⚠️ R1003 - ListInOperationName	Since operation 'ListOperations' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Solutions/stable/2018-03-01/managedapplications.json#L42
⚠️ R1003 - ListInOperationName	Since operation 'ListOperations' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Solutions/stable/2018-06-01/managedapplications.json#L42
⚠️ R1003 - ListInOperationName	Since operation 'ListOperations' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Solutions/stable/2019-07-01/managedapplications.json#L42
⚠️ R1003 - ListInOperationName	Since operation 'ListOperations' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L42
⚠️ R2007 - LongRunningOperationsWithLongRunningExtension	The operation 'Applications_Update' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.Solutions/preview/2020-08-21-preview/managedapplications.json#L263
⚠️ R2029 - PageableOperation	Based on the response model schema, operation 'jitRequests_ListBySubscription' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Solutions/preview/2018-09-01-preview/managedapplications.json#L1191
⚠️ R2029 - PageableOperation	Based on the response model schema, operation 'jitRequests_ListByResourceGroup' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Solutions/preview/2018-09-01-preview/managedapplications.json#L1227
⚠️ R2029 - PageableOperation	Based on the response model schema, operation 'jitRequests_ListBySubscription' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Solutions/preview/2020-08-21-preview/managedapplications.json#L1187

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️❌SDK Track2 Validation: 23 Errors, 2 Warnings failed [Detail]

The following tags are being changed in this PR

"https://github.com/Azure/azure-rest-api-specs/blob/d2958531ae3128a7aa789161a1b4e67ded6e0541/specification/solutions/resource-manager/readme.md#tag-package-managedapplications-2021-07">solutions/resource-manager/readme.md#package-managedapplications-2021-07
"https://github.com/Azure/azure-rest-api-specs/blob/d2958531ae3128a7aa789161a1b4e67ded6e0541/specification/solutions/resource-manager/readme.md#tag-package-managedapplications-2021-02">solutions/resource-manager/readme.md#package-managedapplications-2021-02
"https://github.com/Azure/azure-rest-api-specs/blob/d2958531ae3128a7aa789161a1b4e67ded6e0541/specification/solutions/resource-manager/readme.md#tag-package-managedapplications-2020-08">solutions/resource-manager/readme.md#package-managedapplications-2020-08
"https://github.com/Azure/azure-rest-api-specs/blob/d2958531ae3128a7aa789161a1b4e67ded6e0541/specification/solutions/resource-manager/readme.md#tag-package-managedapplications-2019-07">solutions/resource-manager/readme.md#package-managedapplications-2019-07
"https://github.com/Azure/azure-rest-api-specs/blob/d2958531ae3128a7aa789161a1b4e67ded6e0541/specification/solutions/resource-manager/readme.md#tag-package-managedapplications-2018-09">solutions/resource-manager/readme.md#package-managedapplications-2018-09
"https://github.com/Azure/azure-rest-api-specs/blob/d2958531ae3128a7aa789161a1b4e67ded6e0541/specification/solutions/resource-manager/readme.md#tag-package-managedapplications-2018-06">solutions/resource-manager/readme.md#package-managedapplications-2018-06
"https://github.com/Azure/azure-rest-api-specs/blob/d2958531ae3128a7aa789161a1b4e67ded6e0541/specification/solutions/resource-manager/readme.md#tag-package-managedapplications-2018-03">solutions/resource-manager/readme.md#package-managedapplications-2018-03
"https://github.com/Azure/azure-rest-api-specs/blob/d2958531ae3128a7aa789161a1b4e67ded6e0541/specification/solutions/resource-manager/readme.md#tag-package-managedapplications-2018-02">solutions/resource-manager/readme.md#package-managedapplications-2018-02
"https://github.com/Azure/azure-rest-api-specs/blob/d2958531ae3128a7aa789161a1b4e67ded6e0541/specification/solutions/resource-manager/readme.md#tag-package-managedapplications-2017-12">solutions/resource-manager/readme.md#package-managedapplications-2017-12
"https://github.com/Azure/azure-rest-api-specs/blob/d2958531ae3128a7aa789161a1b4e67ded6e0541/specification/solutions/resource-manager/readme.md#tag-package-managedapplications-2017-09">solutions/resource-manager/readme.md#package-managedapplications-2017-09

The following errors/warnings are introduced by current PR:

Only 14 items are listed, please refer to log for more details.

Rule	Message
`❌` PreCheck/DuplicateSchema	"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2021-02", "details":"Duplicate Schema named 'Operation' (10 differences):\n - properties.name.$ref: "#/components/schemas/schemas:141" => "#/components/schemas/schemas:243"\n - properties.name.description: "Operation name: provider/resource/operation" => "The name of the operation, as per Resource-Based Access Control (RBAC). Examples: \"Microsoft.Compute/virtualMachines/write\", \"Microsoft.Compute/virtualMachines/capture/action\""\n - properties.name.readOnly: => true\n - properties.isDataAction.description: "Indicates whether the operation is a data action" => "Whether the operation applies to data-plane. This is \"true\" for data-plane operations and \"false\" for ARM/control-plane operations."\n - properties.isDataAction.readOnly: => true\n - properties.display.$ref: "#/components/schemas/schemas:142" => "#/components/schemas/schemas:244"\n - properties.display.description: "The object that represents the operation." => "Localized display information for this particular operation."\n - properties.origin: => "x-ms-enum":"name":"Origin", "modelAsString":true, "$ref":"#/components/schemas/Origin", "description":"The intended executor of the operation; as in Resource Based Access Control (RBAC) and audit logs UX. Default value is \"user, system\"", "readOnly":true\n - properties.actionType: => "x-ms-enum":"name":"ActionType", "modelAsString":true, "$ref":"#/components/schemas/ActionType", "description":"Enum. Indicates the action type. \"Internal\" refers to actions that are for internal only APIs.", "readOnly":true\n - title: => "REST API Operation"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌` PreCheck/DuplicateSchema	"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2021-02", "details":"Duplicate Schema named 'Operation-display' (10 differences):\n - properties.provider.$ref: "#/components/schemas/schemas:143" => "#/components/schemas/schemas:245"\n - properties.provider.description: "Service provider: Microsoft.Solutions" => "The localized friendly form of the resource provider name, e.g. \"Microsoft Monitoring Insights\" or \"Microsoft Compute\"."\n - properties.provider.readOnly: => true\n - properties.resource.$ref: "#/components/schemas/schemas:144" => "#/components/schemas/schemas:246"\n - properties.resource.description: "Resource on which the operation is performed: Application, JitRequest, etc." => "The localized friendly name of the resource type related to this operation. E.g. \"Virtual Machines\" or \"Job Schedule Collections\"."\n - properties.resource.readOnly: => true\n - properties.operation.$ref: "#/components/schemas/schemas:145" => "#/components/schemas/schemas:247"\n - properties.operation.description: "Operation type: Read, write, delete, etc." => "The concise, localized friendly name for the operation; suitable for dropdowns. E.g. \"Create or Update Virtual Machine\", \"Restart Virtual Machine\"."\n - properties.operation.readOnly: => true\n - properties.description.description: "Localized friendly description for the operation" => "The short, localized friendly description of the operation; suitable for tool tips and detailed views."; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌` PreCheck/DuplicateSchema	"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2021-02", "details":"Duplicate Schema named 'OperationListResult' (7 differences):\n - properties.value.$ref: "#/components/schemas/schemas:148" => "#/components/schemas/schemas:252"\n - properties.value.description: "List of Microsoft.Solutions operations." => "List of operations supported by the resource provider"\n - properties.value.x-ms-identifiers: => ["name"]\n - properties.value.readOnly: => true\n - properties.nextLink.$ref: "#/components/schemas/schemas:149" => "#/components/schemas/schemas:253"\n - properties.nextLink.description: "URL to get the next set of operation list results if there are any." => "URL to get the next set of operation list results (if there are any)."\n - properties.nextLink.readOnly: => true; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌`	"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2021-02", "details":"Error: 3 errors occured -- cannot continue."
`❌` PreCheck/DuplicateSchema	"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2020-08", "details":"Duplicate Schema named 'Operation' (10 differences):\n - properties.name.$ref: "#/components/schemas/schemas:141" => "#/components/schemas/schemas:272"\n - properties.name.description: "Operation name: provider/resource/operation" => "The name of the operation, as per Resource-Based Access Control (RBAC). Examples: \"Microsoft.Compute/virtualMachines/write\", \"Microsoft.Compute/virtualMachines/capture/action\""\n - properties.name.readOnly: => true\n - properties.isDataAction.description: "Indicates whether the operation is a data action" => "Whether the operation applies to data-plane. This is \"true\" for data-plane operations and \"false\" for ARM/control-plane operations."\n - properties.isDataAction.readOnly: => true\n - properties.display.$ref: "#/components/schemas/schemas:142" => "#/components/schemas/schemas:273"\n - properties.display.description: "The object that represents the operation." => "Localized display information for this particular operation."\n - properties.origin: => "x-ms-enum":"name":"Origin", "modelAsString":true, "$ref":"#/components/schemas/Origin", "description":"The intended executor of the operation; as in Resource Based Access Control (RBAC) and audit logs UX. Default value is \"user, system\"", "readOnly":true\n - properties.actionType: => "x-ms-enum":"name":"ActionType", "modelAsString":true, "$ref":"#/components/schemas/ActionType", "description":"Enum. Indicates the action type. \"Internal\" refers to actions that are for internal only APIs.", "readOnly":true\n - title: => "REST API Operation"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌` PreCheck/DuplicateSchema	"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2020-08", "details":"Duplicate Schema named 'Operation-display' (10 differences):\n - properties.provider.$ref: "#/components/schemas/schemas:143" => "#/components/schemas/schemas:274"\n - properties.provider.description: "Service provider: Microsoft.Solutions" => "The localized friendly form of the resource provider name, e.g. \"Microsoft Monitoring Insights\" or \"Microsoft Compute\"."\n - properties.provider.readOnly: => true\n - properties.resource.$ref: "#/components/schemas/schemas:144" => "#/components/schemas/schemas:275"\n - properties.resource.description: "Resource on which the operation is performed: Application, JitRequest, etc." => "The localized friendly name of the resource type related to this operation. E.g. \"Virtual Machines\" or \"Job Schedule Collections\"."\n - properties.resource.readOnly: => true\n - properties.operation.$ref: "#/components/schemas/schemas:145" => "#/components/schemas/schemas:276"\n - properties.operation.description: "Operation type: Read, write, delete, etc." => "The concise, localized friendly name for the operation; suitable for dropdowns. E.g. \"Create or Update Virtual Machine\", \"Restart Virtual Machine\"."\n - properties.operation.readOnly: => true\n - properties.description.description: "Localized friendly description for the operation" => "The short, localized friendly description of the operation; suitable for tool tips and detailed views."; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌` PreCheck/DuplicateSchema	"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2020-08", "details":"Duplicate Schema named 'OperationListResult' (7 differences):\n - properties.value.$ref: "#/components/schemas/schemas:148" => "#/components/schemas/schemas:281"\n - properties.value.description: "List of Microsoft.Solutions operations." => "List of operations supported by the resource provider"\n - properties.value.x-ms-identifiers: => ["name"]\n - properties.value.readOnly: => true\n - properties.nextLink.$ref: "#/components/schemas/schemas:149" => "#/components/schemas/schemas:282"\n - properties.nextLink.description: "URL to get the next set of operation list results if there are any." => "URL to get the next set of operation list results (if there are any)."\n - properties.nextLink.readOnly: => true; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌`	"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2020-08", "details":"Error: 3 errors occured -- cannot continue."
`❌` PreCheck/DuplicateSchema	"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2019-07", "details":"Duplicate Schema named 'Operation' (9 differences):\n - properties.name.$ref: "#/components/schemas/schemas:141" => "#/components/schemas/schemas:268"\n - properties.name.description: "Operation name: provider/resource/operation" => "The name of the operation, as per Resource-Based Access Control (RBAC). Examples: \"Microsoft.Compute/virtualMachines/write\", \"Microsoft.Compute/virtualMachines/capture/action\""\n - properties.name.readOnly: => true\n - properties.display.$ref: "#/components/schemas/schemas:142" => "#/components/schemas/schemas:269"\n - properties.display.description: "The object that represents the operation." => "Localized display information for this particular operation."\n - properties.isDataAction: => "description":"Whether the operation applies to data-plane. This is \"true\" for data-plane operations and \"false\" for ARM/control-plane operations.", "type":"boolean", "readOnly":true\n - properties.origin: => "x-ms-enum":"name":"Origin", "modelAsString":true, "$ref":"#/components/schemas/Origin", "description":"The intended executor of the operation; as in Resource Based Access Control (RBAC) and audit logs UX. Default value is \"user, system\"", "readOnly":true\n - properties.actionType: => "x-ms-enum":"name":"ActionType", "modelAsString":true, "$ref":"#/components/schemas/ActionType", "description":"Enum. Indicates the action type. \"Internal\" refers to actions that are for internal only APIs.", "readOnly":true\n - title: => "REST API Operation"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌` PreCheck/DuplicateSchema	"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2019-07", "details":"Duplicate Schema named 'Operation-display' (10 differences):\n - properties.provider.$ref: "#/components/schemas/schemas:143" => "#/components/schemas/schemas:270"\n - properties.provider.description: "Service provider: Microsoft.Solutions" => "The localized friendly form of the resource provider name, e.g. \"Microsoft Monitoring Insights\" or \"Microsoft Compute\"."\n - properties.provider.readOnly: => true\n - properties.resource.$ref: "#/components/schemas/schemas:144" => "#/components/schemas/schemas:271"\n - properties.resource.description: "Resource on which the operation is performed: Application, JitRequest, etc." => "The localized friendly name of the resource type related to this operation. E.g. \"Virtual Machines\" or \"Job Schedule Collections\"."\n - properties.resource.readOnly: => true\n - properties.operation.$ref: "#/components/schemas/schemas:145" => "#/components/schemas/schemas:272"\n - properties.operation.description: "Operation type: Read, write, delete, etc." => "The concise, localized friendly name for the operation; suitable for dropdowns. E.g. \"Create or Update Virtual Machine\", \"Restart Virtual Machine\"."\n - properties.operation.readOnly: => true\n - properties.description: => "$ref":"#/components/schemas/schemas:273", "description":"The short, localized friendly description of the operation; suitable for tool tips and detailed views.", "readOnly":true; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌`	"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2019-07", "details":"Error: 2 errors occured -- cannot continue."
`❌` PreCheck/DuplicateSchema	"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2018-09", "details":"Duplicate Schema named 'Operation' (9 differences):\n - properties.name.$ref: "#/components/schemas/schemas:129" => "#/components/schemas/schemas:251"\n - properties.name.description: "Operation name: provider/resource/operation" => "The name of the operation, as per Resource-Based Access Control (RBAC). Examples: \"Microsoft.Compute/virtualMachines/write\", \"Microsoft.Compute/virtualMachines/capture/action\""\n - properties.name.readOnly: => true\n - properties.display.$ref: "#/components/schemas/schemas:130" => "#/components/schemas/schemas:252"\n - properties.display.description: "The object that represents the operation." => "Localized display information for this particular operation."\n - properties.isDataAction: => "description":"Whether the operation applies to data-plane. This is \"true\" for data-plane operations and \"false\" for ARM/control-plane operations.", "type":"boolean", "readOnly":true\n - properties.origin: => "x-ms-enum":"name":"Origin", "modelAsString":true, "$ref":"#/components/schemas/Origin", "description":"The intended executor of the operation; as in Resource Based Access Control (RBAC) and audit logs UX. Default value is \"user, system\"", "readOnly":true\n - properties.actionType: => "x-ms-enum":"name":"ActionType", "modelAsString":true, "$ref":"#/components/schemas/ActionType", "description":"Enum. Indicates the action type. \"Internal\" refers to actions that are for internal only APIs.", "readOnly":true\n - title: => "REST API Operation"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌` PreCheck/DuplicateSchema	"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2018-09", "details":"Duplicate Schema named 'Operation-display' (10 differences):\n - properties.provider.$ref: "#/components/schemas/schemas:131" => "#/components/schemas/schemas:253"\n - properties.provider.description: "Service provider: Microsoft.Solutions" => "The localized friendly form of the resource provider name, e.g. \"Microsoft Monitoring Insights\" or \"Microsoft Compute\"."\n - properties.provider.readOnly: => true\n - properties.resource.$ref: "#/components/schemas/schemas:132" => "#/components/schemas/schemas:254"\n - properties.resource.description: "Resource on which the operation is performed: Application, JitRequest, etc." => "The localized friendly name of the resource type related to this operation. E.g. \"Virtual Machines\" or \"Job Schedule Collections\"."\n - properties.resource.readOnly: => true\n - properties.operation.$ref: "#/components/schemas/schemas:133" => "#/components/schemas/schemas:255"\n - properties.operation.description: "Operation type: Read, write, delete, etc." => "The concise, localized friendly name for the operation; suitable for dropdowns. E.g. \"Create or Update Virtual Machine\", \"Restart Virtual Machine\"."\n - properties.operation.readOnly: => true\n - properties.description: => "$ref":"#/components/schemas/schemas:256", "description":"The short, localized friendly description of the operation; suitable for tool tips and detailed views.", "readOnly":true; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌`	"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2018-09", "details":"Error: 2 errors occured -- cannot continue."

The following errors/warnings exist before current PR submission:

Rule	Message
⚠️ UnkownSecurityScheme	"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2021-07", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous"

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️❌Lint(RPaaS): 3 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` R4023 - Rpaas_CreateOperationAsyncResponseValidation	[RPaaS] An async PUT operation must set ''x-ms-long-running-operation' : true''. Location: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L368
`❌` R4023 - Rpaas_CreateOperationAsyncResponseValidation	[RPaaS] An async PUT operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L368
`❌` R4031 - Rpaas_ResourceProvisioningState	[RPaaS] The resource ApplicationDefinition is defined without 'provisioningState' in properties bag, consider adding the provisioningState for it. Location: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L1614

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-07-19T06:39:05Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - armmanagedapplications - 2.0.0

-	Field `Parameters` of struct `ApplicationsClientUpdateByIDOptions` has been removed
-	Field `Parameters` of struct `ApplicationsClientUpdateOptions` has been removed
-	Function `*ApplicationsClient.UpdateByID` parameter(s) have been changed from `(context.Context, string, *ApplicationsClientUpdateByIDOptions)` to `(context.Context, string, Application, *ApplicationsClientUpdateByIDOptions)`
-	Function `*ApplicationsClient.Update` parameter(s) have been changed from `(context.Context, string, string, *ApplicationsClientUpdateOptions)` to `(context.Context, string, string, ApplicationPatchable, *ApplicationsClientUpdateOptions)`
+	Field `Application` of struct `ApplicationsClientUpdateResponse` has been removed
+	Field `ProvisioningState` of struct `ApplicationDefinitionProperties` has been removed
+	Function `*ApplicationDefinitionsClient.BeginCreateOrUpdate` has been removed
+	Function `*ApplicationDefinitionsClient.BeginDelete` has been removed
+	Function `*ApplicationsClient.Update` has been removed
+	Struct `ApplicationDefinitionsClientBeginCreateOrUpdateOptions` has been removed
+	Struct `ApplicationDefinitionsClientBeginDeleteOptions` has been removed
+	Struct `ApplicationPropertiesPatchable` has been removed
+	Struct `ApplicationsClientUpdateOptions` has been removed

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 5a16258. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]  config global `--global`, `--local` are deprecated. Use `--location=global` instead.
warn	No file changes detected after generation
warn	No package detected after generation

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 5a16258. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-solutions [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 5a16258. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armmanagedapplications [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `*ApplicationDefinitionsClient.BeginDelete` has been removed
info	[Changelog] - Function `*ApplicationDefinitionsClient.BeginCreateOrUpdate` has been removed
info	[Changelog] - Function `*ApplicationsClient.Update` has been removed
info	[Changelog] - Struct `ApplicationDefinitionsClientBeginCreateOrUpdateOptions` has been removed
info	[Changelog] - Struct `ApplicationDefinitionsClientBeginDeleteOptions` has been removed
info	[Changelog] - Struct `ApplicationPropertiesPatchable` has been removed
info	[Changelog] - Struct `ApplicationsClientUpdateOptions` has been removed
info	[Changelog] - Field `ProvisioningState` of struct `ApplicationDefinitionProperties` has been removed
info	[Changelog] - Field `Application` of struct `ApplicationsClientUpdateResponse` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `SubstatusApproved`
info	[Changelog] - New const `SubstatusNotSpecified`
info	[Changelog] - New const `SubstatusExpired`
info	[Changelog] - New const `StatusRemove`
info	[Changelog] - New const `StatusNotSpecified`
info	[Changelog] - New const `SubstatusFailed`
info	[Changelog] - New const `SubstatusDenied`
info	[Changelog] - New const `StatusElevate`
info	[Changelog] - New const `SubstatusTimeout`
info	[Changelog] - New function `*ApplicationDefinitionsClient.CreateOrUpdate(context.Context, string, string, ApplicationDefinition, *ApplicationDefinitionsClientCreateOrUpdateOptions) (ApplicationDefinitionsClientCreateOrUpdateResponse, error)`
info	[Changelog] - New function `*ApplicationsClient.GetByID(context.Context, string, *ApplicationsClientGetByIDOptions) (ApplicationsClientGetByIDResponse, error)`
info	[Changelog] - New function `PossibleSubstatusValues() []Substatus`
info	[Changelog] - New function `*ApplicationsClient.BeginDeleteByID(context.Context, string, *ApplicationsClientBeginDeleteByIDOptions) (*runtime.Poller[ApplicationsClientDeleteByIDResponse], error)`
info	[Changelog] - New function `*ApplicationDefinitionsClient.DeleteByID(context.Context, string, string, *ApplicationDefinitionsClientDeleteByIDOptions) (ApplicationDefinitionsClientDeleteByIDResponse, error)`
info	[Changelog] - New function `*ApplicationDefinitionsClient.GetByID(context.Context, string, string, *ApplicationDefinitionsClientGetByIDOptions) (ApplicationDefinitionsClientGetByIDResponse, error)`
info	[Changelog] - New function `*ApplicationsClient.BeginCreateOrUpdateByID(context.Context, string, Application, *ApplicationsClientBeginCreateOrUpdateByIDOptions) (*runtime.Poller[ApplicationsClientCreateOrUpdateByIDResponse], error)`
info	[Changelog] - New function `*ApplicationDefinitionsClient.CreateOrUpdateByID(context.Context, string, string, ApplicationDefinition, *ApplicationDefinitionsClientCreateOrUpdateByIDOptions) (ApplicationDefinitionsClientCreateOrUpdateByIDResponse, error)`
info	[Changelog] - New function `*ApplicationsClient.ListTokens(context.Context, string, string, ListTokenRequest, *ApplicationsClientListTokensOptions) (ApplicationsClientListTokensResponse, error)`
info	[Changelog] - New function `*ApplicationDefinitionsClient.UpdateByID(context.Context, string, string, ApplicationDefinitionPatchable, *ApplicationDefinitionsClientUpdateByIDOptions) (ApplicationDefinitionsClientUpdateByIDResponse, error)`
info	[Changelog] - New function `*ApplicationDefinitionsClient.Delete(context.Context, string, string, *ApplicationDefinitionsClientDeleteOptions) (ApplicationDefinitionsClientDeleteResponse, error)`
info	[Changelog] - New function `*ApplicationsClient.BeginUpdate(context.Context, string, string, ApplicationPatchable, *ApplicationsClientBeginUpdateOptions) (*runtime.Poller[ApplicationsClientUpdateResponse], error)`
info	[Changelog] - New function `PossibleStatusValues() []Status`
info	[Changelog] - New function `*ApplicationsClient.BeginUpdateByID(context.Context, string, ApplicationPatchable, *ApplicationsClientBeginUpdateByIDOptions) (*runtime.Poller[ApplicationsClientUpdateByIDResponse], error)`
info	[Changelog] - New function `*ApplicationsClient.BeginUpdateAccess(context.Context, string, string, UpdateAccessDefinition, *ApplicationsClientBeginUpdateAccessOptions) (*runtime.Poller[ApplicationsClientUpdateAccessResponse], error)`
info	[Changelog] - New struct `AllowedUpgradePlansResult`
info	[Changelog] - New struct `ApplicationDefinitionsClientCreateOrUpdateByIDOptions`
info	[Changelog] - New struct `ApplicationDefinitionsClientCreateOrUpdateByIDResponse`
info	[Changelog] - New struct `ApplicationDefinitionsClientCreateOrUpdateOptions`
info	[Changelog] - New struct `ApplicationDefinitionsClientDeleteByIDOptions`
info	[Changelog] - New struct `ApplicationDefinitionsClientDeleteByIDResponse`
info	[Changelog] - New struct `ApplicationDefinitionsClientDeleteOptions`
info	[Changelog] - New struct `ApplicationDefinitionsClientGetByIDOptions`
info	[Changelog] - New struct `ApplicationDefinitionsClientGetByIDResponse`
info	[Changelog] - New struct `ApplicationDefinitionsClientUpdateByIDOptions`
info	[Changelog] - New struct `ApplicationDefinitionsClientUpdateByIDResponse`
info	[Changelog] - New struct `ApplicationsClientBeginCreateOrUpdateByIDOptions`
info	[Changelog] - New struct `ApplicationsClientBeginDeleteByIDOptions`
info	[Changelog] - New struct `ApplicationsClientBeginUpdateAccessOptions`
info	[Changelog] - New struct `ApplicationsClientBeginUpdateByIDOptions`
info	[Changelog] - New struct `ApplicationsClientBeginUpdateOptions`
info	[Changelog] - New struct `ApplicationsClientCreateOrUpdateByIDResponse`
info	[Changelog] - New struct `ApplicationsClientDeleteByIDResponse`
info	[Changelog] - New struct `ApplicationsClientGetByIDOptions`
info	[Changelog] - New struct `ApplicationsClientGetByIDResponse`
info	[Changelog] - New struct `ApplicationsClientListTokensOptions`
info	[Changelog] - New struct `ApplicationsClientListTokensResponse`
info	[Changelog] - New struct `ApplicationsClientUpdateAccessResponse`
info	[Changelog] - New struct `ApplicationsClientUpdateByIDResponse`
info	[Changelog] - New struct `JitRequestMetadata`
info	[Changelog] - New struct `ListTokenRequest`
info	[Changelog] - New struct `ManagedIdentityToken`
info	[Changelog] - New struct `ManagedIdentityTokenResult`
info	[Changelog] - New struct `UpdateAccessDefinition`
info	[Changelog] - New anonymous field `ApplicationPatchable` in struct `ApplicationsClientUpdateResponse`
info	[Changelog] - New anonymous field `AllowedUpgradePlansResult` in struct `ApplicationsClientListAllowedUpgradePlansResponse`
info	[Changelog]
info	[Changelog] Total 13 breaking change(s), 84 additive change(s).

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from 5a16258. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
warn	No file changes detected after generation
warn	No package detected after generation

️❌ azure-powershell failed [Detail]

❌Failed [Logs]Release - Generate from 5a16258. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

❌Az.solutions [View full logs] [Release SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2022-07-19T06:43:39Z

Hi @vayada, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

vayada · 2022-07-19T06:45:12Z

@ruowan This PR is just moving swagger from resources folder to solutions folder as per Josephine's suggestion. There is not other change except moving specs from one location to another as per Josephine's suggestion. So, please help in merging this PR.

Source folders:
azure-rest-api-specs/tree/main/specification/resources/resource-manager/Microsoft.Solutions (Main branch)
azure-rest-api-specs-pr/tree/RPSaaSMaster/specification/solutions/resource-manager/Microsoft.Solutions (RPSaaSMaster)

Target Folder:
azure-rest-api-specs/specification/solutions/resource-manager/Microsoft.Solutions

ruowan · 2022-07-19T09:32:07Z

There are some validation errors, could you take a look and fix them?

openapi-workflow-bot · 2022-07-19T19:50:26Z

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

openapi-workflow-bot · 2022-07-19T22:20:56Z

Hi @vayada, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

vayada · 2022-07-21T17:13:26Z

There are some validation errors, could you take a look and fix them?

@ruowan Fixed all validation errors and currently in touch with ARM API reviewer & breaking change reviewer.

Can you look at sdk errors and let me know what needs to be done for that. Not sure what's causing duplicate key error as below.

"location":"specification/solutions/resource-manager/readme.md",
"tag":"package-managedapplications-2021-07",
"details":"Syntax Error Encountered: Syntax error: duplicate key"

vayada · 2022-07-22T04:48:29Z

@ruowan I have fixed all the validation errors. I have already got the Breaking Change approval. Can you check it now.

ruowan · 2022-07-25T09:02:32Z

Hi, @jianyexi Could you take a look at lintDiff, why there are so many lintDiff error?

jianyexi · 2022-07-25T09:21:16Z

@vayada the restructure causes the lintDiff failure, could you confirm all the versions except 2021-07-01 are coming from the old folder or branch and without any Api changes?

vayada · 2022-07-25T16:30:24Z

@vayada the restructure causes the lintDiff failure, could you confirm all the versions except 2021-07-01 are coming from the old folder or branch and without any Api changes?
@jianyexi This contains the versions from old folder and some new api version specs which were missing and then I have corrected the validation failures in all the versions. So, its not just move now anymore. Please let me know what I can do to resolve these failures?

msyyc · 2022-08-05T09:05:12Z

specification/solutions/resource-manager/readme.md

+### Tag: package-managedapplications-2021-02
+
+These settings apply only when `--tag=package-managedapplications-2021-02` is specified on the command line.
+
+``` yaml $(tag) == 'package-managedapplications-2021-02'
+input-file:
+- Microsoft.Solutions/preview/2021-02-01-preview/managedapplications.json
+```


tag name shall contain preview since it only contain files under preview folder

Moved swagger specs from resources to solutions folder.

39d7325

vayada requested review from ArcturusZhang, BigCat20196 and msyyc as code owners July 19, 2022 06:39

openapi-assignment-bot bot assigned ruowan Jul 19, 2022

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Jul 19, 2022

azure-sdk mentioned this pull request Jul 19, 2022

[AutoPR Az.solutions] Moved swagger specs from resources to solutions folder. azure-sdk/azure-powershell#1378

Closed

vayada added 3 commits July 19, 2022 10:41

Fixed validation errors.

ded0345

Validation error.

c9f6b3f

Fixed validation errors.

2a6bf82

openapi-pipeline-app bot added the NewApiVersionRequired label Jul 19, 2022

Fixed validation errors.

5cb675e

openapi-pipeline-app bot added the BreakingChangeReviewRequired label Jul 19, 2022

vayada added 4 commits July 19, 2022 15:39

Validation error.

1d836d4

Validation errors.

3a00d9a

Validation errors.

5eca2bf

Validation errors.

7a34386

vayada changed the title ~~Moved swagger specs from resources to solutions folder. NO OTHER CHANGE EXCEPT MOVE.~~ Moved swagger specs from resources to solutions folder. Jul 20, 2022

vayada added 3 commits July 19, 2022 19:55

Validation errors.

481827a

Added missing api specs.

22bc318

Fixed validation errors.

442584a

vayada added 3 commits July 21, 2022 20:06

Validation.

4462704

Validation.

4bb6ba4

Validation.

59beb21

rkmanda added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Jul 25, 2022

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 25, 2022

Validation.

f8182a3

openapi-pipeline-app bot removed the CI-BreakingChange-Go label Jul 25, 2022

Validation.

e1323e5

openapi-pipeline-app bot added the CI-BreakingChange-Go label Jul 26, 2022

vayada added 3 commits July 25, 2022 18:12

Validation.

abc0932

Prettier.

d879e0d

Validation.

d295853

jianyexi added the Approved-LintDiff label Jul 26, 2022

ruowan approved these changes Jul 26, 2022

View reviewed changes

ruowan merged commit 5a16258 into Azure:main Jul 26, 2022

msyyc mentioned this pull request Aug 5, 2022

[Managedapplication]Update readme.python.md #20127

Merged

msyyc reviewed Aug 5, 2022

View reviewed changes

tadelesh mentioned this pull request Sep 23, 2022

Fix AMA swagger for completeness. R3007 #20667

Closed

11 tasks

Alancere mentioned this pull request Sep 13, 2023

[Release] sdk/resourcemanager/solutions/armmanagedapplications/2.0.0 Azure/azure-sdk-for-go#21462

Merged

kazrael2119 mentioned this pull request Sep 20, 2023

[mgmt] managedapplications(solutions) release Azure/azure-sdk-for-js#27026

Merged

Moved swagger specs from resources to solutions folder. #19826

Moved swagger specs from resources to solutions folder. #19826

Uh oh!

Conversation

vayada commented Jul 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

openapi-workflow-bot bot commented Jul 19, 2022

Uh oh!

openapi-pipeline-app bot commented Jul 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented Jul 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

openapi-workflow-bot bot commented Jul 19, 2022

Uh oh!

vayada commented Jul 19, 2022

Uh oh!

ruowan commented Jul 19, 2022

Uh oh!

openapi-workflow-bot bot commented Jul 19, 2022

Uh oh!

openapi-workflow-bot bot commented Jul 19, 2022

Uh oh!

vayada commented Jul 21, 2022

Uh oh!

vayada commented Jul 22, 2022

Uh oh!

ruowan commented Jul 25, 2022

Uh oh!

jianyexi commented Jul 25, 2022

Uh oh!

vayada commented Jul 25, 2022

Uh oh!

msyyc Aug 5, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

vayada commented Jul 19, 2022 •

edited

Loading

openapi-pipeline-app bot commented Jul 19, 2022 •

edited

Loading

openapi-pipeline-app bot commented Jul 19, 2022 •

edited

Loading