Fix AMA swagger for completeness. R3007 #20667
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @vayada Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| compared swaggers (via Oad v0.9.7)] | new version | base version |
|---|---|---|
| managedapplications.json | 2018-09-01-preview(e158ad6) | 2018-09-01-preview(main) |
| managedapplications.json | 2020-08-21-preview(e158ad6) | 2020-08-21-preview(main) |
| managedapplications.json | 2021-02-01-preview(e158ad6) | 2021-02-01-preview(main) |
| managedapplications.json | 2017-09-01(e158ad6) | 2017-09-01(main) |
| managedapplications.json | 2017-12-01(e158ad6) | 2017-12-01(main) |
| managedapplications.json | 2018-02-01(e158ad6) | 2018-02-01(main) |
| managedapplications.json | 2018-03-01(e158ad6) | 2018-03-01(main) |
| managedapplications.json | 2018-06-01(e158ad6) | 2018-06-01(main) |
| managedapplications.json | 2019-07-01(e158ad6) | 2019-07-01(main) |
| managedapplications.json | 2021-07-01(e158ad6) | 2021-07-01(main) |
Only 14 items are listed, please refer to log for more details.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 2 Warnings warning [Detail]
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
| The response of operation:'Applications_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Solutions/preview/2020-08-21-preview/managedapplications.json#L263 |
||
| The response of operation:'Applications_UpdateById' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Solutions/preview/2020-08-21-preview/managedapplications.json#L890 |
The following errors/warnings exist before current PR submission:
Only 14 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The response schema of operations API '/providers/Microsoft.Solutions/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Solutions/preview/2018-09-01-preview/managedapplications.json#L37 |
|
The response schema of operations API '/providers/Microsoft.Solutions/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Solutions/stable/2018-02-01/managedapplications.json#L37 |
|
The response schema of operations API '/providers/Microsoft.Solutions/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Solutions/stable/2018-03-01/managedapplications.json#L37 |
|
The response schema of operations API '/providers/Microsoft.Solutions/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Solutions/stable/2018-06-01/managedapplications.json#L37 |
|
The response schema of operations API '/providers/Microsoft.Solutions/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Solutions/stable/2019-07-01/managedapplications.json#L37 |
|
Response code 404 is defined without a x-ms-error-response. Location: Microsoft.Solutions/preview/2018-09-01-preview/managedapplications.json#L119 |
|
Response code 404 is defined without a x-ms-error-response. Location: Microsoft.Solutions/preview/2018-09-01-preview/managedapplications.json#L375 |
|
Response code 404 is defined without a x-ms-error-response. Location: Microsoft.Solutions/preview/2018-09-01-preview/managedapplications.json#L772 |
|
Response code 404 is defined without a x-ms-error-response. Location: Microsoft.Solutions/preview/2018-09-01-preview/managedapplications.json#L990 |
|
Response code 404 is defined without a x-ms-error-response. Location: Microsoft.Solutions/preview/2020-08-21-preview/managedapplications.json#L113 |
|
Response code 404 is defined without a x-ms-error-response. Location: Microsoft.Solutions/preview/2020-08-21-preview/managedapplications.json#L371 |
|
Response code 404 is defined without a x-ms-error-response. Location: Microsoft.Solutions/preview/2020-08-21-preview/managedapplications.json#L768 |
|
Response code 404 is defined without a x-ms-error-response. Location: Microsoft.Solutions/preview/2020-08-21-preview/managedapplications.json#L986 |
|
Response code 404 is defined without a x-ms-error-response. Location: Microsoft.Solutions/preview/2021-02-01-preview/managedapplications.json#L100 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️❌~[Staging] ServiceAPIReadinessTest: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
"ResourceType 'applications' should be deployed in 'West Central US' on apiVersion '2018-09-01-preview'.: expected [ Array(7) ] to satisfy [Function]" |
️❌~[Staging] TrafficValidation: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
"ResourceType 'applications' should be deployed in 'West Central US' on apiVersion '2018-09-01-preview'.: expected [ Array(7) ] to satisfy [Function]" |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️⚠️SDK Track2 Validation: 0 Warnings warning [Detail]
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/e158ad614cec0d24c7c04d5795080719ab27bfe0/specification/solutions/resource-manager/readme.md#tag-package-managedapplications-2021-07">solutions/resource-manager/readme.md#package-managedapplications-2021-07
- "https://github.com/Azure/azure-rest-api-specs/blob/e158ad614cec0d24c7c04d5795080719ab27bfe0/specification/solutions/resource-manager/readme.md#tag-package-managedapplications-2021-02">solutions/resource-manager/readme.md#package-managedapplications-2021-02
- "https://github.com/Azure/azure-rest-api-specs/blob/e158ad614cec0d24c7c04d5795080719ab27bfe0/specification/solutions/resource-manager/readme.md#tag-package-managedapplications-2020-08">solutions/resource-manager/readme.md#package-managedapplications-2020-08
- "https://github.com/Azure/azure-rest-api-specs/blob/e158ad614cec0d24c7c04d5795080719ab27bfe0/specification/solutions/resource-manager/readme.md#tag-package-managedapplications-2019-07">solutions/resource-manager/readme.md#package-managedapplications-2019-07
- "https://github.com/Azure/azure-rest-api-specs/blob/e158ad614cec0d24c7c04d5795080719ab27bfe0/specification/solutions/resource-manager/readme.md#tag-package-managedapplications-2018-09">solutions/resource-manager/readme.md#package-managedapplications-2018-09
- "https://github.com/Azure/azure-rest-api-specs/blob/e158ad614cec0d24c7c04d5795080719ab27bfe0/specification/solutions/resource-manager/readme.md#tag-package-managedapplications-2018-06">solutions/resource-manager/readme.md#package-managedapplications-2018-06
- "https://github.com/Azure/azure-rest-api-specs/blob/e158ad614cec0d24c7c04d5795080719ab27bfe0/specification/solutions/resource-manager/readme.md#tag-package-managedapplications-2018-03">solutions/resource-manager/readme.md#package-managedapplications-2018-03
- "https://github.com/Azure/azure-rest-api-specs/blob/e158ad614cec0d24c7c04d5795080719ab27bfe0/specification/solutions/resource-manager/readme.md#tag-package-managedapplications-2018-02">solutions/resource-manager/readme.md#package-managedapplications-2018-02
- "https://github.com/Azure/azure-rest-api-specs/blob/e158ad614cec0d24c7c04d5795080719ab27bfe0/specification/solutions/resource-manager/readme.md#tag-package-managedapplications-2017-12">solutions/resource-manager/readme.md#package-managedapplications-2017-12
- "https://github.com/Azure/azure-rest-api-specs/blob/e158ad614cec0d24c7c04d5795080719ab27bfe0/specification/solutions/resource-manager/readme.md#tag-package-managedapplications-2017-09">solutions/resource-manager/readme.md#package-managedapplications-2017-09
Only 14 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2021-02", "details":"Duplicate Schema named 'Operation' (10 differences):\n - properties.name.$ref: "#/components/schemas/schemas:141" => "#/components/schemas/schemas:243"\n - properties.name.description: "Operation name: provider/resource/operation" => "The name of the operation, as per Resource-Based Access Control (RBAC). Examples: \"Microsoft.Compute/virtualMachines/write\", \"Microsoft.Compute/virtualMachines/capture/action\""\n - properties.name.readOnly: => true\n - properties.isDataAction.description: "Indicates whether the operation is a data action" => "Whether the operation applies to data-plane. This is \"true\" for data-plane operations and \"false\" for ARM/control-plane operations."\n - properties.isDataAction.readOnly: => true\n - properties.display.$ref: "#/components/schemas/schemas:142" => "#/components/schemas/schemas:244"\n - properties.display.description: "The object that represents the operation." => "Localized display information for this particular operation."\n - properties.origin: => "x-ms-enum":"name":"Origin", "modelAsString":true, "$ref":"#/components/schemas/Origin", "description":"The intended executor of the operation; as in Resource Based Access Control (RBAC) and audit logs UX. Default value is \"user, system\"", "readOnly":true\n - properties.actionType: => "x-ms-enum":"name":"ActionType", "modelAsString":true, "$ref":"#/components/schemas/ActionType", "description":"Enum. Indicates the action type. \"Internal\" refers to actions that are for internal only APIs.", "readOnly":true\n - title: => "REST API Operation"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2021-02", "details":"Duplicate Schema named 'Operation-display' (10 differences):\n - properties.provider.$ref: "#/components/schemas/schemas:143" => "#/components/schemas/schemas:245"\n - properties.provider.description: "Service provider: Microsoft.Solutions" => "The localized friendly form of the resource provider name, e.g. \"Microsoft Monitoring Insights\" or \"Microsoft Compute\"."\n - properties.provider.readOnly: => true\n - properties.resource.$ref: "#/components/schemas/schemas:144" => "#/components/schemas/schemas:246"\n - properties.resource.description: "Resource on which the operation is performed: Application, JitRequest, etc." => "The localized friendly name of the resource type related to this operation. E.g. \"Virtual Machines\" or \"Job Schedule Collections\"."\n - properties.resource.readOnly: => true\n - properties.operation.$ref: "#/components/schemas/schemas:145" => "#/components/schemas/schemas:247"\n - properties.operation.description: "Operation type: Read, write, delete, etc." => "The concise, localized friendly name for the operation; suitable for dropdowns. E.g. \"Create or Update Virtual Machine\", \"Restart Virtual Machine\"."\n - properties.operation.readOnly: => true\n - properties.description.description: "Localized friendly description for the operation" => "The short, localized friendly description of the operation; suitable for tool tips and detailed views."; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2021-02", "details":"Duplicate Schema named 'OperationListResult' (7 differences):\n - properties.value.$ref: "#/components/schemas/schemas:148" => "#/components/schemas/schemas:252"\n - properties.value.description: "List of Microsoft.Solutions operations." => "List of operations supported by the resource provider"\n - properties.value.x-ms-identifiers: => ["name"]\n - properties.value.readOnly: => true\n - properties.nextLink.$ref: "#/components/schemas/schemas:149" => "#/components/schemas/schemas:253"\n - properties.nextLink.description: "URL to get the next set of operation list results if there are any." => "URL to get the next set of operation list results (if there are any)."\n - properties.nextLink.readOnly: => true; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2021-02", "details":"Error: 3 errors occured -- cannot continue." |
|
"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2020-08", "details":"Duplicate Schema named 'Operation' (10 differences):\n - properties.name.$ref: "#/components/schemas/schemas:141" => "#/components/schemas/schemas:272"\n - properties.name.description: "Operation name: provider/resource/operation" => "The name of the operation, as per Resource-Based Access Control (RBAC). Examples: \"Microsoft.Compute/virtualMachines/write\", \"Microsoft.Compute/virtualMachines/capture/action\""\n - properties.name.readOnly: => true\n - properties.isDataAction.description: "Indicates whether the operation is a data action" => "Whether the operation applies to data-plane. This is \"true\" for data-plane operations and \"false\" for ARM/control-plane operations."\n - properties.isDataAction.readOnly: => true\n - properties.display.$ref: "#/components/schemas/schemas:142" => "#/components/schemas/schemas:273"\n - properties.display.description: "The object that represents the operation." => "Localized display information for this particular operation."\n - properties.origin: => "x-ms-enum":"name":"Origin", "modelAsString":true, "$ref":"#/components/schemas/Origin", "description":"The intended executor of the operation; as in Resource Based Access Control (RBAC) and audit logs UX. Default value is \"user, system\"", "readOnly":true\n - properties.actionType: => "x-ms-enum":"name":"ActionType", "modelAsString":true, "$ref":"#/components/schemas/ActionType", "description":"Enum. Indicates the action type. \"Internal\" refers to actions that are for internal only APIs.", "readOnly":true\n - title: => "REST API Operation"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2020-08", "details":"Duplicate Schema named 'Operation-display' (10 differences):\n - properties.provider.$ref: "#/components/schemas/schemas:143" => "#/components/schemas/schemas:274"\n - properties.provider.description: "Service provider: Microsoft.Solutions" => "The localized friendly form of the resource provider name, e.g. \"Microsoft Monitoring Insights\" or \"Microsoft Compute\"."\n - properties.provider.readOnly: => true\n - properties.resource.$ref: "#/components/schemas/schemas:144" => "#/components/schemas/schemas:275"\n - properties.resource.description: "Resource on which the operation is performed: Application, JitRequest, etc." => "The localized friendly name of the resource type related to this operation. E.g. \"Virtual Machines\" or \"Job Schedule Collections\"."\n - properties.resource.readOnly: => true\n - properties.operation.$ref: "#/components/schemas/schemas:145" => "#/components/schemas/schemas:276"\n - properties.operation.description: "Operation type: Read, write, delete, etc." => "The concise, localized friendly name for the operation; suitable for dropdowns. E.g. \"Create or Update Virtual Machine\", \"Restart Virtual Machine\"."\n - properties.operation.readOnly: => true\n - properties.description.description: "Localized friendly description for the operation" => "The short, localized friendly description of the operation; suitable for tool tips and detailed views."; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2020-08", "details":"Duplicate Schema named 'OperationListResult' (7 differences):\n - properties.value.$ref: "#/components/schemas/schemas:148" => "#/components/schemas/schemas:281"\n - properties.value.description: "List of Microsoft.Solutions operations." => "List of operations supported by the resource provider"\n - properties.value.x-ms-identifiers: => ["name"]\n - properties.value.readOnly: => true\n - properties.nextLink.$ref: "#/components/schemas/schemas:149" => "#/components/schemas/schemas:282"\n - properties.nextLink.description: "URL to get the next set of operation list results if there are any." => "URL to get the next set of operation list results (if there are any)."\n - properties.nextLink.readOnly: => true; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2020-08", "details":"Error: 3 errors occured -- cannot continue." |
|
"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2019-07", "details":"Duplicate Schema named 'Operation' (9 differences):\n - properties.name.$ref: "#/components/schemas/schemas:141" => "#/components/schemas/schemas:268"\n - properties.name.description: "Operation name: provider/resource/operation" => "The name of the operation, as per Resource-Based Access Control (RBAC). Examples: \"Microsoft.Compute/virtualMachines/write\", \"Microsoft.Compute/virtualMachines/capture/action\""\n - properties.name.readOnly: => true\n - properties.display.$ref: "#/components/schemas/schemas:142" => "#/components/schemas/schemas:269"\n - properties.display.description: "The object that represents the operation." => "Localized display information for this particular operation."\n - properties.isDataAction: => "description":"Whether the operation applies to data-plane. This is \"true\" for data-plane operations and \"false\" for ARM/control-plane operations.", "type":"boolean", "readOnly":true\n - properties.origin: => "x-ms-enum":"name":"Origin", "modelAsString":true, "$ref":"#/components/schemas/Origin", "description":"The intended executor of the operation; as in Resource Based Access Control (RBAC) and audit logs UX. Default value is \"user, system\"", "readOnly":true\n - properties.actionType: => "x-ms-enum":"name":"ActionType", "modelAsString":true, "$ref":"#/components/schemas/ActionType", "description":"Enum. Indicates the action type. \"Internal\" refers to actions that are for internal only APIs.", "readOnly":true\n - title: => "REST API Operation"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2019-07", "details":"Duplicate Schema named 'Operation-display' (10 differences):\n - properties.provider.$ref: "#/components/schemas/schemas:143" => "#/components/schemas/schemas:270"\n - properties.provider.description: "Service provider: Microsoft.Solutions" => "The localized friendly form of the resource provider name, e.g. \"Microsoft Monitoring Insights\" or \"Microsoft Compute\"."\n - properties.provider.readOnly: => true\n - properties.resource.$ref: "#/components/schemas/schemas:144" => "#/components/schemas/schemas:271"\n - properties.resource.description: "Resource on which the operation is performed: Application, JitRequest, etc." => "The localized friendly name of the resource type related to this operation. E.g. \"Virtual Machines\" or \"Job Schedule Collections\"."\n - properties.resource.readOnly: => true\n - properties.operation.$ref: "#/components/schemas/schemas:145" => "#/components/schemas/schemas:272"\n - properties.operation.description: "Operation type: Read, write, delete, etc." => "The concise, localized friendly name for the operation; suitable for dropdowns. E.g. \"Create or Update Virtual Machine\", \"Restart Virtual Machine\"."\n - properties.operation.readOnly: => true\n - properties.description: => "$ref":"#/components/schemas/schemas:273", "description":"The short, localized friendly description of the operation; suitable for tool tips and detailed views.", "readOnly":true; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2019-07", "details":"Error: 2 errors occured -- cannot continue." |
|
"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2018-09", "details":"Duplicate Schema named 'Operation' (9 differences):\n - properties.name.$ref: "#/components/schemas/schemas:129" => "#/components/schemas/schemas:251"\n - properties.name.description: "Operation name: provider/resource/operation" => "The name of the operation, as per Resource-Based Access Control (RBAC). Examples: \"Microsoft.Compute/virtualMachines/write\", \"Microsoft.Compute/virtualMachines/capture/action\""\n - properties.name.readOnly: => true\n - properties.display.$ref: "#/components/schemas/schemas:130" => "#/components/schemas/schemas:252"\n - properties.display.description: "The object that represents the operation." => "Localized display information for this particular operation."\n - properties.isDataAction: => "description":"Whether the operation applies to data-plane. This is \"true\" for data-plane operations and \"false\" for ARM/control-plane operations.", "type":"boolean", "readOnly":true\n - properties.origin: => "x-ms-enum":"name":"Origin", "modelAsString":true, "$ref":"#/components/schemas/Origin", "description":"The intended executor of the operation; as in Resource Based Access Control (RBAC) and audit logs UX. Default value is \"user, system\"", "readOnly":true\n - properties.actionType: => "x-ms-enum":"name":"ActionType", "modelAsString":true, "$ref":"#/components/schemas/ActionType", "description":"Enum. Indicates the action type. \"Internal\" refers to actions that are for internal only APIs.", "readOnly":true\n - title: => "REST API Operation"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2018-09", "details":"Duplicate Schema named 'Operation-display' (10 differences):\n - properties.provider.$ref: "#/components/schemas/schemas:131" => "#/components/schemas/schemas:253"\n - properties.provider.description: "Service provider: Microsoft.Solutions" => "The localized friendly form of the resource provider name, e.g. \"Microsoft Monitoring Insights\" or \"Microsoft Compute\"."\n - properties.provider.readOnly: => true\n - properties.resource.$ref: "#/components/schemas/schemas:132" => "#/components/schemas/schemas:254"\n - properties.resource.description: "Resource on which the operation is performed: Application, JitRequest, etc." => "The localized friendly name of the resource type related to this operation. E.g. \"Virtual Machines\" or \"Job Schedule Collections\"."\n - properties.resource.readOnly: => true\n - properties.operation.$ref: "#/components/schemas/schemas:133" => "#/components/schemas/schemas:255"\n - properties.operation.description: "Operation type: Read, write, delete, etc." => "The concise, localized friendly name for the operation; suitable for dropdowns. E.g. \"Create or Update Virtual Machine\", \"Restart Virtual Machine\"."\n - properties.operation.readOnly: => true\n - properties.description: => "$ref":"#/components/schemas/schemas:256", "description":"The short, localized friendly description of the operation; suitable for tool tips and detailed views.", "readOnly":true; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2018-09", "details":"Error: 2 errors occured -- cannot continue." |
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️❌Lint(RPaaS): 3 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
[RPaaS] An async PUT operation must set ''x-ms-long-running-operation' : true''. Location: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L368 |
|
[RPaaS] An async PUT operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L368 |
|
[RPaaS] The resource ApplicationDefinition is defined without 'provisioningState' in properties bag, consider adding the provisioningState for it. Location: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L1614 |
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
Swagger Generation Artifacts
|
Generated ApiView
|
|
This fix is being made for following S360 for swagger completeness. |
|
Hi @vayada, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Sep 9, 2022
|
@leni-msft Can you please review this PR. This is for fixing S360 issues. |
|
@jianyexi please help reivew this PR fixing Lint R3007 PutGetPatchResponseSchema |
jianyexi
approved these changes
Sep 13, 2022
|
Hi @vayada, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
@vayada please request breaking change approval following Action in #20667 (comment) . and fix the Lint(RPaaS) error |
|
@tadelesh please help check go sdk breaking changes |
@leni-msft RPaaS Linter errors are false alarm as agreed with RPaaS team. As you can see this is not coming from current change. We have exception for this since starting. |
Will review after breaking change arch review. |
|
@tadelesh Breaking Change ARCH review wants you to review first. So, can you please do that. |
|
@josefree Could you give guidance here? This PR is to fix S360 Lint error, and may cause breaking changes to both API and SDK. |
leniatgh
added
the
BreakingChangeReviewRequired
|
Approved for Go breaking as it is caused by this PR. |
tadelesh
added
the
Approved-SdkBreakingChange-Go
|
@vayada Go SDK breaking changes have been approved, please request BC board review |
|
Hi, @vayada. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
ghost
closed this
|
Hi, @vayada. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.