-
Notifications
You must be signed in to change notification settings - Fork 5.5k
[Hub Generated] [Microsoft.Cache] 2022-05-01 API: Add "Latest" option to "redisVersion" property, async linked server, managed identity changes #19506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi, @JeffreyCA Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
Hi, @JeffreyCA your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
specification/redis/resource-manager/Microsoft.Cache/stable/2020-12-01/redis.json
Outdated
Show resolved
Hide resolved
Swagger Validation Report
|
| compared swaggers (via Oad v0.9.6)] | new version | base version |
|---|---|---|
| redis.json | 2020-06-01(3362a77) | 2020-06-01(main) |
| redis.json | 2020-12-01(3362a77) | 2020-12-01(main) |
| redis.json | 2021-06-01(3362a77) | 2021-06-01(main) |
️❌Breaking Change(Cross-Version): 8 Errors, 30 Warnings failed [Detail]
| compared swaggers (via Oad v0.9.6)] | new version | base version |
|---|---|---|
| redis.json | 2022-05-01(3362a77) | 2021-06-01(main) |
| redis.json | 2022-05-01(3362a77) | 2019-07-01(main) |
The following breaking changes are detected by comparison with the latest stable version:
The following breaking changes are detected by comparison with the latest preview version:
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/listUpgradeNotifications' removed or restructured? Old: Microsoft.Cache/preview/2019-07-01/redis.json#L103:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}' removed or restructured? Old: Microsoft.Cache/preview/2019-07-01/redis.json#L155:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis' removed or restructured? Old: Microsoft.Cache/preview/2019-07-01/redis.json#L354:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Cache/Redis' removed or restructured? Old: Microsoft.Cache/preview/2019-07-01/redis.json#L394:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/listKeys' removed or restructured? Old: Microsoft.Cache/preview/2019-07-01/redis.json#L427:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/regenerateKey' removed or restructured? Old: Microsoft.Cache/preview/2019-07-01/redis.json#L471:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/forceReboot' removed or restructured? Old: Microsoft.Cache/preview/2019-07-01/redis.json#L524:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/import' removed or restructured? Old: Microsoft.Cache/preview/2019-07-01/redis.json#L577:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/export' removed or restructured? Old: Microsoft.Cache/preview/2019-07-01/redis.json#L634:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{cacheName}/firewallRules' removed or restructured? Old: Microsoft.Cache/preview/2019-07-01/redis.json#L691:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{cacheName}/firewallRules/{ruleName}' removed or restructured? Old: Microsoft.Cache/preview/2019-07-01/redis.json#L739:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{cacheName}/patchSchedules' removed or restructured? Old: Microsoft.Cache/preview/2019-07-01/redis.json#L906:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/patchSchedules/{default}' removed or restructured? Old: Microsoft.Cache/preview/2019-07-01/redis.json#L954:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/linkedServers/{linkedServerName}' removed or restructured? Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1142:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/linkedServers' removed or restructured? Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1304:5 |
|
| The new version adds a response code 'default'. New: Microsoft.Cache/stable/2022-05-01/redis.json#L61:11 |
|
| The new version adds a response code 'default'. New: Microsoft.Cache/stable/2022-05-01/redis.json#L106:11 |
|
| The new version has a different type '' than the previous one 'string'. New: Microsoft.Cache/stable/2022-05-01/redis.json#L1963:11 Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1397:11 |
|
| The new version has a different type '' than the previous one 'string'. New: Microsoft.Cache/stable/2022-05-01/redis.json#L1963:11 Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1397:11 |
|
| The new version has a different type '' than the previous one 'string'. New: Microsoft.Cache/stable/2022-05-01/redis.json#L1963:11 Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1397:11 |
|
| The new version has a different type '' than the previous one 'string'. New: Microsoft.Cache/stable/2022-05-01/redis.json#L1963:11 Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1397:11 |
|
| The new version has a different type 'object' than the previous one ''. New: common-types/resource-management/v2/types.json#L9:5 Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1560:5 |
|
| The new version has a different type 'object' than the previous one ''. New: common-types/resource-management/v2/types.json#L85:5 Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1581:5 |
|
| The new version has a different type 'object' than the previous one ''. New: common-types/resource-management/v2/types.json#L50:5 Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1589:5 |
|
| The new version has a different default value than the previous one. New: Microsoft.Cache/stable/2022-05-01/redis.json#L1970:9 Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1402:9 |
|
| The new version has a different default value than the previous one. New: Microsoft.Cache/stable/2022-05-01/redis.json#L1970:9 Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1402:9 |
|
| The new version has a different default value than the previous one. New: Microsoft.Cache/stable/2022-05-01/redis.json#L1970:9 Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1402:9 |
|
| The new version has a different default value than the previous one. New: Microsoft.Cache/stable/2022-05-01/redis.json#L1970:9 Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1402:9 |
|
| The read only property has changed from 'true' to 'false'. New: Microsoft.Cache/stable/2022-05-01/redis.json#L1966:9 Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1485:9 |
|
| The new version has a different 'allOf' property than the previous one. New: Microsoft.Cache/stable/2022-05-01/redis.json#L2251:5 Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1708:5 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v1.13.0) | new version | base version |
|---|---|---|
| package-2021-06 | package-2021-06(3362a77) | package-2021-06(main) |
| package-2020-12 | package-2020-12(3362a77) | package-2020-12(main) |
| package-2020-06 | package-2020-06(3362a77) | package-2020-06(main) |
| package-2022-05 | package-2022-05(3362a77) | default(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
R3021 - PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Cache/CheckNameAvailability' Location: Microsoft.Cache/stable/2020-06-01/redis.json#L73 |
R3021 - PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Cache/CheckNameAvailability' Location: Microsoft.Cache/stable/2020-12-01/redis.json#L73 |
R3021 - PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Cache/CheckNameAvailability' Location: Microsoft.Cache/stable/2021-06-01/redis.json#L73 |
R3021 - PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Cache/CheckNameAvailability' Location: Microsoft.Cache/stable/2022-05-01/redis.json#L73 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.Cache/stable/2020-06-01/redis.json#L2378 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2336 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2406 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.Cache/stable/2022-05-01/redis.json#L2419 |
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.Cache/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Cache/stable/2020-06-01/redis.json#L37 |
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.Cache/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Cache/stable/2020-12-01/redis.json#L37 |
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.Cache/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Cache/stable/2021-06-01/redis.json#L37 |
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.Cache/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Cache/stable/2022-05-01/redis.json#L37 |
R4037 - MissingTypeObject |
The schema 'Sku' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-06-01/redis.json#L1786 |
R4037 - MissingTypeObject |
The schema 'RedisCommonProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-06-01/redis.json#L1826 |
R4037 - MissingTypeObject |
The schema 'RedisCreateProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-06-01/redis.json#L1934 |
R4037 - MissingTypeObject |
The schema 'RedisUpdateProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-06-01/redis.json#L1966 |
R4037 - MissingTypeObject |
The schema 'RedisProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-06-01/redis.json#L1981 |
R4037 - MissingTypeObject |
The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-06-01/redis.json#L2066 |
R4037 - MissingTypeObject |
The schema 'TrackedResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-06-01/redis.json#L2095 |
R4037 - MissingTypeObject |
The schema 'RedisCreateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-06-01/redis.json#L2128 |
R4037 - MissingTypeObject |
The schema 'RedisUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-06-01/redis.json#L2164 |
R4037 - MissingTypeObject |
The schema 'RedisAccessKeys' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-06-01/redis.json#L2181 |
R4037 - MissingTypeObject |
The schema 'RedisFirewallRule' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-06-01/redis.json#L2196 |
R4037 - MissingTypeObject |
The schema 'RedisFirewallRuleCreateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-06-01/redis.json#L2214 |
R4037 - MissingTypeObject |
The schema 'RedisFirewallRuleProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-06-01/redis.json#L2227 |
R4037 - MissingTypeObject |
The schema 'RedisFirewallRuleListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-06-01/redis.json#L2244 |
R4037 - MissingTypeObject |
The schema 'RedisResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-06-01/redis.json#L2261 |
R4037 - MissingTypeObject |
The schema 'RedisInstanceDetails' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-06-01/redis.json#L2286 |
R4037 - MissingTypeObject |
The schema 'RedisListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-06-01/redis.json#L2319 |
R4037 - MissingTypeObject |
The schema 'RedisRegenerateKeyParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cache/stable/2020-06-01/redis.json#L2336 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️❌SDK Track2 Validation: 2 Errors, 0 Warnings failed [Detail]
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/3362a77ae682694908fa843e462a44543c748bec/specification/redis/resource-manager/readme.md#tag-package-2021-06">redis/resource-manager/readme.md#package-2021-06
- "https://github.com/Azure/azure-rest-api-specs/blob/3362a77ae682694908fa843e462a44543c748bec/specification/redis/resource-manager/readme.md#tag-package-2020-12">redis/resource-manager/readme.md#package-2020-12
- "https://github.com/Azure/azure-rest-api-specs/blob/3362a77ae682694908fa843e462a44543c748bec/specification/redis/resource-manager/readme.md#tag-package-2020-06">redis/resource-manager/readme.md#package-2020-06
- "https://github.com/Azure/azure-rest-api-specs/blob/3362a77ae682694908fa843e462a44543c748bec/specification/redis/resource-manager/readme.md#tag-package-2022-05">redis/resource-manager/readme.md#package-2022-05
| Rule | Message |
|---|---|
PreCheck/DuplicateSchema |
"readme":"redis/resource-manager/readme.md", "tag":"package-2022-05", "details":"Duplicate Schema named 'ErrorDetail' (1 differences):\n - properties.details.$ref: "#/components/schemas/schemas:249" => "#/components/schemas/schemas:455"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"redis/resource-manager/readme.md", "tag":"package-2022-05", "details":"Error: 1 errors occured -- cannot continue." |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
PreCheck/DuplicateSchema |
"readme":"redis/resource-manager/readme.md", "tag":"package-2021-06", "details":"Duplicate Schema named 'ErrorDetail' (1 differences):\n - properties.details.$ref: "#/components/schemas/schemas:247" => "#/components/schemas/schemas:453"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"redis/resource-manager/readme.md", "tag":"package-2021-06", "details":"Error: 1 errors occured -- cannot continue." |
PreCheck/DuplicateSchema |
"readme":"redis/resource-manager/readme.md", "tag":"package-2020-06", "details":"Duplicate Schema named 'Resource' (4 differences):\n - properties.id.description: "Resource ID." => "Fully qualified resource ID for the resource. Ex - /subscriptions/subscriptionId/resourceGroups/resourceGroupName/providers/resourceProviderNamespace/resourceType/resourceName"\n - properties.name.description: "Resource name." => "The name of the resource"\n - properties.type.description: "Resource type." => "The type of the resource. E.g. \"Microsoft.Compute/virtualMachines\" or \"Microsoft.Storage/storageAccounts\""\n - title: => "Resource"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"redis/resource-manager/readme.md", "tag":"package-2020-06", "details":"Error: 1 errors occured -- cannot continue." |
| "readme":"redis/resource-manager/readme.md", "tag":"package-2020-12", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
Swagger Generation Artifacts
|
|
Hi @JeffreyCA, Your PR has some issues. Please fix the CI sequentially by following the order of
|
specification/redis/resource-manager/Microsoft.Cache/stable/2022-05-01/redis.json
Outdated
Show resolved
Hide resolved
|
Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove |
specification/redis/resource-manager/Microsoft.Cache/stable/2022-05-01/redis.json
Outdated
Show resolved
Hide resolved
specification/redis/resource-manager/Microsoft.Cache/stable/2022-05-01/redis.json
Show resolved
Hide resolved
|
@msyyc @tadelesh @qiaozha @XiaofeiCao @fengzhou-msft for awareness to breaking changes (Jeffrey already approved). |
0fdc153 to
8ea3f71
Compare
|
approved for python breaking change |
|
Hello @weidongxu-microsoft and @msyyc. I am on the Azure Cache for Redis Team and am taking over this work from @JeffreyCA. The RP manifest rollout has completed for all regions and we are ready to have this PR merged. Yesterday, I removed the |
…dd "Latest" option to "redisVersion" property, async linked server, managed identity changes (#2510) Create to sync Azure/azure-rest-api-specs#19506 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/redis?expand=1)
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
What's the purpose of the update?
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
July 2022
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
July 2022
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.