Skip to content

Conversation

@JeffreyCA
Copy link
Contributor

@JeffreyCA JeffreyCA commented Jun 17, 2022

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?

    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
    July 2022

  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
    July 2022

  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @JeffreyCA Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @JeffreyCA JeffreyCA added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jun 20, 2022
    @JeffreyCA JeffreyCA marked this pull request as ready for review June 20, 2022 21:50
    @JeffreyCA JeffreyCA changed the title [Hub Generated] Review request for Microsoft.Cache to add version stable/2020-12-01, stable/2021-06-01 and stable/2022-05-01 [Hub Generated] Review request for Microsoft.Cache to add "Latest" option to "redisVersion" property and make it default in new API version 2022-05-01 Jun 20, 2022
    @openapi-workflow-bot openapi-workflow-bot bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 20, 2022
    @openapi-workflow-bot
    Copy link

    Hi, @JeffreyCA your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 20, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    compared swaggers (via Oad v0.9.6)] new version base version
    redis.json 2020-06-01(3362a77) 2020-06-01(main)
    redis.json 2020-12-01(3362a77) 2020-12-01(main)
    redis.json 2021-06-01(3362a77) 2021-06-01(main)
    ️❌Breaking Change(Cross-Version): 8 Errors, 30 Warnings failed [Detail]
    compared swaggers (via Oad v0.9.6)] new version base version
    redis.json 2022-05-01(3362a77) 2021-06-01(main)
    redis.json 2022-05-01(3362a77) 2019-07-01(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Rule Message
    1011 - AddingResponseCode The new version adds a response code '202'.
    New: Microsoft.Cache/stable/2022-05-01/redis.json#L297:11
    1011 - AddingResponseCode The new version adds a response code '202'.
    New: Microsoft.Cache/stable/2022-05-01/redis.json#L1407:11
    1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.Cache/stable/2022-05-01/redis.json#L1949:13
    Old: Microsoft.Cache/stable/2021-06-01/redis.json#L1935:13
    1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.Cache/stable/2022-05-01/redis.json#L1949:13
    Old: Microsoft.Cache/stable/2021-06-01/redis.json#L1935:13
    1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.Cache/stable/2022-05-01/redis.json#L1949:13
    Old: Microsoft.Cache/stable/2021-06-01/redis.json#L1935:13
    1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.Cache/stable/2022-05-01/redis.json#L1949:13
    Old: Microsoft.Cache/stable/2021-06-01/redis.json#L1935:13
    1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.Cache/stable/2022-05-01/redis.json#L247:7
    Old: Microsoft.Cache/stable/2021-06-01/redis.json#L241:7
    1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.Cache/stable/2022-05-01/redis.json#L1362:7
    Old: Microsoft.Cache/stable/2021-06-01/redis.json#L1349:7


    The following breaking changes are detected by comparison with the latest preview version:

    Rule Message
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/listUpgradeNotifications' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L103:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L155:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L354:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Cache/Redis' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L394:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/listKeys' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L427:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/regenerateKey' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L471:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/forceReboot' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L524:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/import' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L577:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/export' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L634:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{cacheName}/firewallRules' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L691:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{cacheName}/firewallRules/{ruleName}' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L739:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{cacheName}/patchSchedules' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L906:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/patchSchedules/{default}' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L954:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/linkedServers/{linkedServerName}' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1142:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/linkedServers' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1304:5
    ⚠️ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.Cache/stable/2022-05-01/redis.json#L61:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.Cache/stable/2022-05-01/redis.json#L106:11
    ⚠️ 1026 - TypeChanged The new version has a different type '' than the previous one 'string'.
    New: Microsoft.Cache/stable/2022-05-01/redis.json#L1963:11
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1397:11
    ⚠️ 1026 - TypeChanged The new version has a different type '' than the previous one 'string'.
    New: Microsoft.Cache/stable/2022-05-01/redis.json#L1963:11
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1397:11
    ⚠️ 1026 - TypeChanged The new version has a different type '' than the previous one 'string'.
    New: Microsoft.Cache/stable/2022-05-01/redis.json#L1963:11
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1397:11
    ⚠️ 1026 - TypeChanged The new version has a different type '' than the previous one 'string'.
    New: Microsoft.Cache/stable/2022-05-01/redis.json#L1963:11
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1397:11
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: common-types/resource-management/v2/types.json#L9:5
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1560:5
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: common-types/resource-management/v2/types.json#L85:5
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1581:5
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: common-types/resource-management/v2/types.json#L50:5
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1589:5
    ⚠️ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Cache/stable/2022-05-01/redis.json#L1970:9
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1402:9
    ⚠️ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Cache/stable/2022-05-01/redis.json#L1970:9
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1402:9
    ⚠️ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Cache/stable/2022-05-01/redis.json#L1970:9
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1402:9
    ⚠️ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Cache/stable/2022-05-01/redis.json#L1970:9
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1402:9
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.Cache/stable/2022-05-01/redis.json#L1966:9
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1485:9
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.Cache/stable/2022-05-01/redis.json#L2251:5
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1708:5
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v1.13.0) new version base version
    package-2021-06 package-2021-06(3362a77) package-2021-06(main)
    package-2020-12 package-2020-12(3362a77) package-2020-12(main)
    package-2020-06 package-2020-06(3362a77) package-2020-06(main)
    package-2022-05 package-2022-05(3362a77) default(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Cache/CheckNameAvailability'
    Location: Microsoft.Cache/stable/2020-06-01/redis.json#L73
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Cache/CheckNameAvailability'
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L73
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Cache/CheckNameAvailability'
    Location: Microsoft.Cache/stable/2021-06-01/redis.json#L73
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Cache/CheckNameAvailability'
    Location: Microsoft.Cache/stable/2022-05-01/redis.json#L73
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.Cache/stable/2020-06-01/redis.json#L2378
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L2336
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.Cache/stable/2021-06-01/redis.json#L2406
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.Cache/stable/2022-05-01/redis.json#L2419
    R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Cache/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Cache/stable/2020-06-01/redis.json#L37
    R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Cache/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Cache/stable/2020-12-01/redis.json#L37
    R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Cache/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Cache/stable/2021-06-01/redis.json#L37
    R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Cache/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Cache/stable/2022-05-01/redis.json#L37
    R4037 - MissingTypeObject The schema 'Sku' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-06-01/redis.json#L1786
    R4037 - MissingTypeObject The schema 'RedisCommonProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-06-01/redis.json#L1826
    R4037 - MissingTypeObject The schema 'RedisCreateProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-06-01/redis.json#L1934
    R4037 - MissingTypeObject The schema 'RedisUpdateProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-06-01/redis.json#L1966
    R4037 - MissingTypeObject The schema 'RedisProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-06-01/redis.json#L1981
    R4037 - MissingTypeObject The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-06-01/redis.json#L2066
    R4037 - MissingTypeObject The schema 'TrackedResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-06-01/redis.json#L2095
    R4037 - MissingTypeObject The schema 'RedisCreateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-06-01/redis.json#L2128
    R4037 - MissingTypeObject The schema 'RedisUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-06-01/redis.json#L2164
    R4037 - MissingTypeObject The schema 'RedisAccessKeys' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-06-01/redis.json#L2181
    R4037 - MissingTypeObject The schema 'RedisFirewallRule' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-06-01/redis.json#L2196
    R4037 - MissingTypeObject The schema 'RedisFirewallRuleCreateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-06-01/redis.json#L2214
    R4037 - MissingTypeObject The schema 'RedisFirewallRuleProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-06-01/redis.json#L2227
    R4037 - MissingTypeObject The schema 'RedisFirewallRuleListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-06-01/redis.json#L2244
    R4037 - MissingTypeObject The schema 'RedisResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-06-01/redis.json#L2261
    R4037 - MissingTypeObject The schema 'RedisInstanceDetails' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-06-01/redis.json#L2286
    R4037 - MissingTypeObject The schema 'RedisListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-06-01/redis.json#L2319
    R4037 - MissingTypeObject The schema 'RedisRegenerateKeyParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/stable/2020-06-01/redis.json#L2336
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️❌SDK Track2 Validation: 2 Errors, 0 Warnings failed [Detail]
    • The following tags are being changed in this PR
      • "https://github.com/Azure/azure-rest-api-specs/blob/3362a77ae682694908fa843e462a44543c748bec/specification/redis/resource-manager/readme.md#tag-package-2021-06">redis/resource-manager/readme.md#package-2021-06
      • "https://github.com/Azure/azure-rest-api-specs/blob/3362a77ae682694908fa843e462a44543c748bec/specification/redis/resource-manager/readme.md#tag-package-2020-12">redis/resource-manager/readme.md#package-2020-12
      • "https://github.com/Azure/azure-rest-api-specs/blob/3362a77ae682694908fa843e462a44543c748bec/specification/redis/resource-manager/readme.md#tag-package-2020-06">redis/resource-manager/readme.md#package-2020-06
      • "https://github.com/Azure/azure-rest-api-specs/blob/3362a77ae682694908fa843e462a44543c748bec/specification/redis/resource-manager/readme.md#tag-package-2022-05">redis/resource-manager/readme.md#package-2022-05
    The following errors/warnings are introduced by current PR:
    Rule Message
    PreCheck/DuplicateSchema "readme":"redis/resource-manager/readme.md",
    "tag":"package-2022-05",
    "details":"Duplicate Schema named 'ErrorDetail' (1 differences):\n - properties.details.$ref: "#/components/schemas/schemas:249" => "#/components/schemas/schemas:455"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    "readme":"redis/resource-manager/readme.md",
    "tag":"package-2022-05",
    "details":"Error: 1 errors occured -- cannot continue."


    The following errors/warnings exist before current PR submission:

    Rule Message
    PreCheck/DuplicateSchema "readme":"redis/resource-manager/readme.md",
    "tag":"package-2021-06",
    "details":"Duplicate Schema named 'ErrorDetail' (1 differences):\n - properties.details.$ref: "#/components/schemas/schemas:247" => "#/components/schemas/schemas:453"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    "readme":"redis/resource-manager/readme.md",
    "tag":"package-2021-06",
    "details":"Error: 1 errors occured -- cannot continue."
    PreCheck/DuplicateSchema "readme":"redis/resource-manager/readme.md",
    "tag":"package-2020-06",
    "details":"Duplicate Schema named 'Resource' (4 differences):\n - properties.id.description: "Resource ID." => "Fully qualified resource ID for the resource. Ex - /subscriptions/subscriptionId/resourceGroups/resourceGroupName/providers/resourceProviderNamespace/resourceType/resourceName"\n - properties.name.description: "Resource name." => "The name of the resource"\n - properties.type.description: "Resource type." => "The type of the resource. E.g. \"Microsoft.Compute/virtualMachines\" or \"Microsoft.Storage/storageAccounts\""\n - title: => "Resource"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    "readme":"redis/resource-manager/readme.md",
    "tag":"package-2020-06",
    "details":"Error: 1 errors occured -- cannot continue."
    ⚠️ UnkownSecurityScheme "readme":"redis/resource-manager/readme.md",
    "tag":"package-2020-12",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 20, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - armredis - 2.0.0
    +	Function `*Client.Update` has been removed
    +	Function `*LinkedServerClient.Delete` has been removed
    +	Struct `ClientUpdateOptions` has been removed
    +	Struct `LinkedServerClientDeleteOptions` has been removed
    azure-sdk-for-python-track2 - track2_azure-mgmt-redis - Approved - 13.1.0
    +	Removed operation LinkedServerOperations.delete
    +	Removed operation RedisOperations.update
    azure-sdk-for-js - @azure/arm-rediscache - 7.0.0
    +	Removed operation LinkedServer.delete
    +	Removed operation Redis.update
    ️❌ azure-sdk-for-net failed [Detail]
    • Failed [Logs]Release - Generate from 1dd7fa1. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-6.0
      command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/redis/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] No usable version of the libssl was found
      cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
      cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
      cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
      warn	Skip package processing as generation is failed
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 1dd7fa1. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]  config global `--global`, `--local` are deprecated. Use `--location=global` instead.
    • ️✔️track2_azure-mgmt-redis [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation LinkedServerOperations.begin_delete
      info	[Changelog]   - Added operation RedisOperations.begin_update
      info	[Changelog]   - Added operation group AsyncOperationStatusOperations
      info	[Changelog]   - Model ExportRDBParameters has a new parameter preferred_data_archive_auth_method
      info	[Changelog]   - Model ImportRDBParameters has a new parameter preferred_data_archive_auth_method
      info	[Changelog]   - Model RedisCommonPropertiesRedisConfiguration has a new parameter aof_backup_enabled
      info	[Changelog]   - Model RedisCommonPropertiesRedisConfiguration has a new parameter authnotrequired
      info	[Changelog]   - Model RedisCommonPropertiesRedisConfiguration has a new parameter zonal_configuration
      info	[Changelog]   - Model RedisPatchSchedule has a new parameter location
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Removed operation LinkedServerOperations.delete
      info	[Changelog]   - Removed operation RedisOperations.update
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 1dd7fa1. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armredis [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Function `*LinkedServerClient.Delete` has been removed
      info	[Changelog] - Function `*Client.Update` has been removed
      info	[Changelog] - Struct `ClientUpdateOptions` has been removed
      info	[Changelog] - Struct `LinkedServerClientDeleteOptions` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New function `*LinkedServerClient.BeginDelete(context.Context, string, string, string, *LinkedServerClientBeginDeleteOptions) (*runtime.Poller[LinkedServerClientDeleteResponse], error)`
      info	[Changelog] - New function `*Client.BeginUpdate(context.Context, string, string, UpdateParameters, *ClientBeginUpdateOptions) (*runtime.Poller[ClientUpdateResponse], error)`
      info	[Changelog] - New struct `ClientBeginUpdateOptions`
      info	[Changelog] - New struct `LinkedServerClientBeginDeleteOptions`
      info	[Changelog] - New field `AofBackupEnabled` in struct `CommonPropertiesRedisConfiguration`
      info	[Changelog] - New field `Authnotrequired` in struct `CommonPropertiesRedisConfiguration`
      info	[Changelog] - New field `PreferredDataArchiveAuthMethod` in struct `ImportRDBParameters`
      info	[Changelog] - New field `PreferredDataArchiveAuthMethod` in struct `ExportRDBParameters`
      info	[Changelog]
      info	[Changelog] Total 6 breaking change(s), 9 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 1dd7fa1. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-rediscache [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation LinkedServer.beginDelete
      info	[Changelog]   - Added operation LinkedServer.beginDeleteAndWait
      info	[Changelog]   - Added operation Redis.beginUpdate
      info	[Changelog]   - Added operation Redis.beginUpdateAndWait
      info	[Changelog]   - Added Interface OperationStatus
      info	[Changelog]   - Added Interface PrivateEndpointConnection
      info	[Changelog]   - Added Interface PrivateLinkResource
      info	[Changelog]   - Added Interface ProxyResource
      info	[Changelog]   - Added Interface RedisCreateProperties
      info	[Changelog]   - Added Interface RedisFirewallRule
      info	[Changelog]   - Added Interface RedisFirewallRuleCreateParameters
      info	[Changelog]   - Added Interface RedisLinkedServerProperties
      info	[Changelog]   - Added Interface RedisLinkedServerWithProperties
      info	[Changelog]   - Added Interface RedisPatchSchedule
      info	[Changelog]   - Added Interface RedisProperties
      info	[Changelog]   - Added Interface RedisResource
      info	[Changelog]   - Added Interface RedisUpdateProperties
      info	[Changelog]   - Added Interface TrackedResource
      info	[Changelog]   - Interface ExportRDBParameters has a new optional parameter preferredDataArchiveAuthMethod
      info	[Changelog]   - Interface ImportRDBParameters has a new optional parameter preferredDataArchiveAuthMethod
      info	[Changelog]   - Interface LinkedServerDeleteOptionalParams has a new optional parameter resumeFrom
      info	[Changelog]   - Interface LinkedServerDeleteOptionalParams has a new optional parameter updateIntervalInMs
      info	[Changelog]   - Interface RedisCommonPropertiesRedisConfiguration has a new optional parameter aofBackupEnabled
      info	[Changelog]   - Interface RedisCommonPropertiesRedisConfiguration has a new optional parameter authnotrequired
      info	[Changelog]   - Interface RedisUpdateOptionalParams has a new optional parameter resumeFrom
      info	[Changelog]   - Interface RedisUpdateOptionalParams has a new optional parameter updateIntervalInMs
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Removed operation LinkedServer.delete
      info	[Changelog]   - Removed operation Redis.update
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 1dd7fa1. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 1dd7fa1. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.Redis [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @JeffreyCA, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link

    Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 21, 2022
    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jun 21, 2022
    @weidongxu-microsoft
    Copy link
    Member

    @msyyc @tadelesh @qiaozha @XiaofeiCao @fengzhou-msft for awareness to breaking changes (Jeffrey already approved).

    @JeffreyCA JeffreyCA force-pushed the dev-redis-Microsoft.Cache-2022-05-01 branch from 0fdc153 to 8ea3f71 Compare July 21, 2022 03:34
    @weidongxu-microsoft weidongxu-microsoft added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Jul 21, 2022
    @msyyc
    Copy link
    Member

    msyyc commented Jul 21, 2022

    approved for python breaking change

    @austintolani austintolani removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 3, 2022
    @austintolani
    Copy link
    Contributor

    austintolani commented Aug 4, 2022

    Hello @weidongxu-microsoft and @msyyc. I am on the Azure Cache for Redis Team and am taking over this work from @JeffreyCA. The RP manifest rollout has completed for all regions and we are ready to have this PR merged. Yesterday, I removed the DoNotMerge tag from the PR. Is there any additional action I need to take on my end to have the PR merged?

    @weidongxu-microsoft weidongxu-microsoft merged commit 1dd7fa1 into Azure:main Aug 5, 2022
    ghost pushed a commit to Azure/azure-resource-manager-schemas that referenced this pull request Aug 5, 2022
    …dd "Latest" option to "redisVersion" property, async linked server, managed identity changes (#2510)
    
    Create to sync Azure/azure-rest-api-specs#19506
    [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/redis?expand=1)
    @JeffreyCA JeffreyCA deleted the dev-redis-Microsoft.Cache-2022-05-01 branch August 5, 2022 17:14
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates Approved-SdkBreakingChange-Python ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go CI-BreakingChange-JavaScript CI-FixRequiredOnFailure

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    8 participants