Skip to content

Conversation

@austintolani
Copy link
Contributor

Summary
These changes contain the newly generated code for the Azure.ResourceManager.Redis package based on the new 2022-06-01 API version. This generation actually includes new code for changes made in both the 2022-06-01 and 2022-05-01 API versions:

Testing
I have re-recorded the existing tests using the new API version and added some additional testing coverage.

Copy link
Member

@archerzz archerzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two types of breaking changes in the new version:

  1. Two methods are changed to long running
  2. New parameters inserted into the constructor of model class
  • For item2, you could write customization codes to provide backward compatible constructors.
  • For item1, I think you could also write customization codes to provide backward compatible operation methods. Inside the backward compatible methods, you await on the new long running methods.

I'll leave the decision for you. You could write customization codes to provide backward compatibility. Or you could bump the major version.

@austintolani
Copy link
Contributor Author

austintolani commented Nov 2, 2022

@archerzz I've spoken with my team and we've decided the best approach for us is to bump the major version number. I've updated the version number to 2.0.0 in CHANGELOG.md. Is there anything else that I need to do to? Should I be leaving the date as "(Unreleased)" in CHANGELOG.md?

@archerzz
Copy link
Member

archerzz commented Nov 3, 2022

@archerzz I've spoked with my team and we've decided the best approach for us is to bump the major version number. I've updated the version number to 2.0.0 in CHANGELOG.md. Is there anything else that I need to do to? Should I be leaving the date as "(Unreleased)" in CHANGELOG.md?

@austintolani

  • If it's just an update on the codes and you're not going to release the SDK right now, you can leave it with (Unreleased).
  • If you're going to release the SDK, you need to update with the release date.

By the way, the pipeline is broken because the version number in CHANGELOG.md is inconsistent with the value in Azure.ResourceManager.Redis.csproj.

@austintolani
Copy link
Contributor Author

Thanks @archerzz, I've updated the CHANGELOG accordingly. My plan is to release the SDK. Can we merge the PR?

@austintolani
Copy link
Contributor Author

@archerzz There is one failing test that seems to be a timeout failure. Are these type of failures common? Is there anything I can do to fix it?

@archerzz
Copy link
Member

archerzz commented Nov 7, 2022

@archerzz There is one failing test that seems to be a timeout failure. Are these type of failures common? Is there anything I can do to fix it?

No worry. I've restarted the failed job, and it's fine now.

@archerzz archerzz merged commit 0e091f3 into Azure:main Nov 7, 2022
@austintolani
Copy link
Contributor Author

Awesome, thanks for all your help @archerzz

sofiar-msft pushed a commit to sofiar-msft/azure-sdk-for-net that referenced this pull request Dec 7, 2022
@austintolani austintolani deleted the T2-SDK branch October 16, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants