- 
                Notifications
    You must be signed in to change notification settings 
- Fork 5.1k
Redis track 2 .NET SDK 2022-06-01 API version updates #32031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two types of breaking changes in the new version:
- Two methods are changed to long running
- New parameters inserted into the constructor of model class
- For item2, you could write customization codes to provide backward compatible constructors.
- For item1, I think you could also write customization codes to provide backward compatible operation methods. Inside the backward compatible methods, you awaiton the new long running methods.
I'll leave the decision for you. You could write customization codes to provide backward compatibility. Or you could bump the major version.
        
          
                sdk/redis/Azure.ResourceManager.Redis/src/Generated/RedisLinkedServerWithPropertyData.cs
          
            Show resolved
            Hide resolved
        
      | @archerzz I've spoken with my team and we've decided the best approach for us is to bump the major version number. I've updated the version number to 2.0.0 in  | 
| 
 
 By the way, the pipeline is broken because the version number in  | 
| Thanks @archerzz, I've updated the CHANGELOG accordingly. My plan is to release the SDK. Can we merge the PR? | 
| @archerzz There is one failing test that seems to be a timeout failure. Are these type of failures common? Is there anything I can do to fix it? | 
| 
 No worry. I've restarted the failed job, and it's fine now. | 
| Awesome, thanks for all your help @archerzz | 
Co-authored-by: Austin Tolani <[email protected]>
Summary
These changes contain the newly generated code for the
Azure.ResourceManager.Redispackage based on the new 2022-06-01 API version. This generation actually includes new code for changes made in both the 2022-06-01 and 2022-05-01 API versions:Testing
I have re-recorded the existing tests using the new API version and added some additional testing coverage.