Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sync trigger error when AzureWebjobsStorage is not set in ManagedApp Environment #10767

Open
wants to merge 13 commits into
base: dev
Choose a base branch
from
Open

Fix sync trigger error when AzureWebjobsStorage is not set in ManagedApp Environment #10767

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
cd15f8f
Fix sync trigger error when AzureWebjobsStorage is not set in case of…
ishank12 Jan 24, 2025
9f30d19
Add test
Jan 31, 2025
aa79ab9
Update release notes
ishank12 Feb 13, 2025
3b88f24
Update release_notes.md
ishank12 Feb 13, 2025
363d5a5
Merge branch 'dev' into ishank12/synctrigger-managedAppEnv
ishank12 Feb 13, 2025
33ef8a1
Resolved comments
ishank12 Feb 14, 2025
be030c5
Fixed comment
ishank12 Feb 14, 2025
bb83e10
fix comment - skip hash check when client is not set
ishank12 Feb 19, 2025
fc1f8f2
Merge branch 'dev' into ishank12/synctrigger-managedAppEnv
ishank12 Feb 19, 2025
95d4409
update test for managedenv
Feb 19, 2025
88801b0
add test for kubernetes managed env
Feb 19, 2025
4b24959
resolve comments - to use cache disabled in test
ishank12 Feb 24, 2025
02c33f4
Merge branch 'dev' into ishank12/synctrigger-managedAppEnv
ishank12 Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/WebJobs.Script.WebHost/Management/FunctionsSyncManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ public async Task<SyncTriggersResult> TrySyncTriggersAsync(bool isBackgroundSync
PrepareSyncTriggers();

var hashBlobClient = await GetHashBlobAsync();
if (isBackgroundSync && hashBlobClient == null && !_environment.IsKubernetesManagedHosting())
if (isBackgroundSync && hashBlobClient == null && !_environment.IsAnyKubernetesEnvironment())
{
// short circuit before doing any work in background sync
// cases where we need to check/update hash but don't have
Expand All @@ -135,7 +135,7 @@ public async Task<SyncTriggersResult> TrySyncTriggersAsync(bool isBackgroundSync

bool shouldSyncTriggers = true;
string newHash = null;
if (isBackgroundSync && !_environment.IsKubernetesManagedHosting())
if (isBackgroundSync && !_environment.IsKubernetesManagedHosting() && hashBlobClient != null)
{
newHash = await CheckHashAsync(hashBlobClient, payload.Content);
shouldSyncTriggers = newHash != null;
Expand Down
Loading