-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sync trigger error when AzureWebjobsStorage is not set in ManagedApp Environment #10767
Open
ishank12
wants to merge
13
commits into
Azure:dev
Choose a base branch
from
ishank12:ishank12/synctrigger-managedAppEnv
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+38
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading status checks…
… ManagedAppEnvironment for Hybrid Logic Apps Issue : Azure#10686
fabiocav
reviewed
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ishank12 can you please make sure the release notes are updated to capture this change?
Can you also please have some validation for the new behavior to ensure this does not regress in the future?
jviau
reviewed
Feb 4, 2025
mathewc
reviewed
Feb 13, 2025
mathewc
reviewed
Feb 13, 2025
test/WebJobs.Script.Tests.Integration/Management/FunctionsSyncManagerTests.cs
Outdated
Show resolved
Hide resolved
mathewc
reviewed
Feb 18, 2025
mathewc
reviewed
Feb 18, 2025
test/WebJobs.Script.Tests.Integration/Management/FunctionsSyncManagerTests.cs
Show resolved
Hide resolved
mathewc
reviewed
Feb 18, 2025
test/WebJobs.Script.Tests.Integration/Management/FunctionsSyncManagerTests.cs
Show resolved
Hide resolved
ishank12
commented
Feb 19, 2025
test/WebJobs.Script.Tests.Integration/Management/FunctionsSyncManagerTests.cs
Outdated
Show resolved
Hide resolved
mathewc
approved these changes
Feb 24, 2025
/azp run host.public |
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
/azp run host.public |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run host.public |
Commenter does not have sufficient privileges for PR 10767 in repo Azure/azure-functions-host |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… ManagedAppEnvironment for Hybrid Logic Apps
Issue : #10686
Issue describing the changes in this PR
resolves #issue_for_this_pr
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-proc
branch to be included in Core Tools and non-Flex deployments.in-proc
branch is not requiredrelease_notes.md
Additional information
Additional PR information