Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sync trigger error when AzureWebjobsStorage is not set in ManagedApp Environment #10767

Open
wants to merge 13 commits into
base: dev
Choose a base branch
from

Conversation

ishank12
Copy link

@ishank12 ishank12 commented Jan 24, 2025

… ManagedAppEnvironment for Hybrid Logic Apps

Issue : #10686

Issue describing the changes in this PR

resolves #issue_for_this_pr

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

Sorry, something went wrong.

… ManagedAppEnvironment for Hybrid Logic Apps

Issue : Azure#10686
@ishank12 ishank12 requested a review from a team as a code owner January 24, 2025 08:30
Copy link
Member

@fabiocav fabiocav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ishank12 can you please make sure the release notes are updated to capture this change?

Can you also please have some validation for the new behavior to ensure this does not regress in the future?

@ishank12 ishank12 requested a review from fabiocav February 3, 2025 06:10
@ishank12 ishank12 requested a review from jviau February 10, 2025 06:45
ishank12 and others added 4 commits February 19, 2025 15:52
@ishank12 ishank12 requested a review from mathewc February 20, 2025 04:37
@fabiocav
Copy link
Member

/azp run host.public

Copy link

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@fabiocav
Copy link
Member

/azp run host.public

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ishank12
Copy link
Author

/azp run host.public

Copy link

Commenter does not have sufficient privileges for PR 10767 in repo Azure/azure-functions-host

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants