-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set higher timeouts for import/export wp-cli commands #904
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good. Increasing the import process will allow users to import websites with more content.
To establish reasonable limits, we might need to benchmark the amount of content imported on a typical computer and set a limit based on those metrics.
I’ve added a couple of suggestions, please let me know what you think.
…nd itself
b82e923
to
b427255
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashfame, Thanks for considering my suggestions. I like the new approach where wp-cli-process handles selecting the timeout based on the command.
I've tested it and confirmed that the timeout for SQLite export and import processes is 6 hours, while the rest of wp-cli commands still 5 minutes.

I've left a couple of non-blocking comments.
Co-authored-by: Antonio Sejas <[email protected]>
@sejas Thanks for the review! I made both the changes. Will merge shortly 👍 |
Related issues
Proposed Changes
longRunning: true
toexecuteWpCliCommand()
Testing Instructions
Pre-merge Checklist