fix(block-theme): migrate newspack-theme checkout fixes by chickenn00dle · Pull Request #4557 · Automattic/newspack-plugin

chickenn00dle · 2026-03-11T13:28:44Z

All Submissions:

Have you followed the Newspack Contributing guideline?
Does your code follow the WordPress' coding standards and VIP Go coding standards?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Closes https://linear.app/a8c/issue/NPPD-1188/modal-checkout-testing-and-fixes

This PR moves over some of the styles and fixes from newspack-theme so they also apply to block theme.

How to test the changes in this Pull Request:

Checkout the fix/modal-checkout-for-block-theme branch for the following repos: newspack-theme, newspack-blocks, and newspack-plugin
Activate the newspack block theme
Smoke test modal checkout in various scenarios including:
- Checkout Button
- Donate Block
- One payment gateway
- Multiple payment gateways
- Various fields set in Audience > Configuration > Checkout & Payment
- Anything else you can think of!
Activate the newspack theme
Repeat smoke tests
Finally smoke test standard Woo checkout

Other information:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes, as applicable?
Have you successfully ran tests with your changes locally?

Copilot

Pull request overview

Migrates modal checkout UI fixes from newspack-theme into the plugin so they also apply when using the Newspack block theme (especially around WooCommerce checkout/payment UI).

Changes:

Add WooCommerce checkout hook to render a “Payment info” heading above the payment form.
Extend Newspack UI WooCommerce overrides with payment-method layout/styling and select2 sizing fixes.
Adjust Newspack UI table styling to use border-collapse: collapse.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
src/newspack-ui/scss/elements/woocommerce/_overrides.scss	Adds checkout/payment-method and select2 overrides intended to improve modal checkout styling.
src/newspack-ui/scss/elements/_tables.scss	Collapses table borders for more consistent table rendering in UI.
includes/plugins/woocommerce/class-woocommerce-connection.php	Loads the new checkout feature class as part of WooCommerce integration init.
includes/plugins/woocommerce/class-woocommerce-checkout.php	New WooCommerce checkout feature: inserts a payment heading via WooCommerce hook.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

laurelfulford

Looks good @chickenn00dle! Just needs a couple CSS tweaks and it should be good to go!

Co-authored-by: Laurel <laurel.fulford@automattic.com>

chickenn00dle · 2026-03-12T17:49:46Z

Thanks @laurelfulford! I applied your suggestions. This should be good for another round of review as well.

laurelfulford

Thanks @chickenn00dle!

I think we're all good 🙌 Thank you for tackling this one!

github-actions · 2026-03-13T19:56:01Z

Hey @chickenn00dle, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

# [6.36.0-alpha.1](v6.35.1...v6.36.0-alpha.1) (2026-03-19) ### Bug Fixes * **access-rules:** normalize rules to individual OR groups ([#4584](#4584)) ([40a7259](40a7259)) * apply max-width to add payment method iframe ([#4575](#4575)) ([de27bb5](de27bb5)) * **block-theme:** ensure content gate contents inserted in time for styles to be rendered ([#4539](#4539)) ([2be2f3b](2be2f3b)) * **block-theme:** load block styles when needed ([#4555](#4555)) ([ec4c70b](ec4c70b)) * **block-theme:** migrate newspack-theme modal checkout fixes ([#4557](#4557)) ([6eb5f48](6eb5f48)) * **content-gating:** allow for metering with paid access only ([#4571](#4571)) ([e2d8e01](e2d8e01)) * exclude Jetpack Swiper CSS from perfmatters unused CSS feature ([#4538](#4538)) ([0d64190](0d64190)) * guard against null, but enumerated, storage keys ([adcec53](adcec53)) * **integrations:** integrations settings registration ([#4573](#4573)) ([a4d90c2](a4d90c2)) * json_decode and notice style fixes ([#4531](#4531)) ([8fc6ada](8fc6ada)) * use correct is_enabled method ([#4564](#4564)) ([6396e41](6396e41)), closes [#4541](#4541) ### Features * **alert-manager:** failure pattern detection ([#4527](#4527)) ([9a0bb3d](9a0bb3d)) * alerting system ([#4511](#4511)) ([1df65a0](1df65a0)) * **content-gate:** default block patterns ([#4540](#4540)) ([4852a9a](4852a9a)) * **content-gate:** display matching gates in post editor ([#4572](#4572)) ([eb275eb](eb275eb)) * **content-gating:** group subscriptions members in my account ([#4543](#4543)) ([202781a](202781a)) * **content-gating:** i3 designs for Metered Countdown + Content Gifting ([#4526](#4526)) ([ba5b4ee](ba5b4ee)) * **group-subscription:** invite email and acceptance flow ([#4546](#4546)) ([ac50a98](ac50a98)) * **integrations:** add integrations settings framework ([#4541](#4541)) ([735e640](735e640)) * **integrations:** refactor metadata for integration specific selection ([#4544](#4544)) ([eb747fc](eb747fc)) * new `getAll()` method to fetch all reader data from store at once ([fbe68db](fbe68db)) * new `getAll()` method to retrieve all items from the reader data store ([b7d6664](b7d6664)) * **reader-activation:** add integration health check system ([#4550](#4550)) ([4993f21](4993f21)) * **yoast:** add Bluesky contact method registration ([#4554](#4554)) ([aa143d7](aa143d7))

github-actions · 2026-03-19T18:23:33Z

🎉 This PR is included in version 6.36.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# [6.36.0](v6.35.2...v6.36.0) (2026-03-30) ### Bug Fixes * **access-rules:** normalize rules to individual OR groups ([#4584](#4584)) ([40a7259](40a7259)) * apply max-width to add payment method iframe ([#4575](#4575)) ([de27bb5](de27bb5)) * **block-theme:** ensure content gate contents inserted in time for styles to be rendered ([#4539](#4539)) ([2be2f3b](2be2f3b)) * **block-theme:** load block styles when needed ([#4555](#4555)) ([ec4c70b](ec4c70b)) * **block-theme:** migrate newspack-theme modal checkout fixes ([#4557](#4557)) ([6eb5f48](6eb5f48)) * **content-gating:** allow for metering with paid access only ([#4571](#4571)) ([e2d8e01](e2d8e01)) * exclude Jetpack Swiper CSS from perfmatters unused CSS feature ([#4538](#4538)) ([0d64190](0d64190)) * guard against null, but enumerated, storage keys ([adcec53](adcec53)) * **integrations:** integrations settings registration ([#4573](#4573)) ([a4d90c2](a4d90c2)) * json_decode and notice style fixes ([#4531](#4531)) ([8fc6ada](8fc6ada)) * use correct is_enabled method ([#4564](#4564)) ([6396e41](6396e41)), closes [#4541](#4541) ### Features * **alert-manager:** failure pattern detection ([#4527](#4527)) ([9a0bb3d](9a0bb3d)) * alerting system ([#4511](#4511)) ([1df65a0](1df65a0)) * **content-gate:** default block patterns ([#4540](#4540)) ([4852a9a](4852a9a)) * **content-gate:** display matching gates in post editor ([#4572](#4572)) ([eb275eb](eb275eb)) * **content-gating:** group subscriptions members in my account ([#4543](#4543)) ([202781a](202781a)) * **content-gating:** i3 designs for Metered Countdown + Content Gifting ([#4526](#4526)) ([ba5b4ee](ba5b4ee)) * **group-subscription:** invite email and acceptance flow ([#4546](#4546)) ([ac50a98](ac50a98)) * **integrations:** add integrations settings framework ([#4541](#4541)) ([735e640](735e640)) * **integrations:** refactor metadata for integration specific selection ([#4544](#4544)) ([eb747fc](eb747fc)) * new `getAll()` method to fetch all reader data from store at once ([fbe68db](fbe68db)) * new `getAll()` method to retrieve all items from the reader data store ([b7d6664](b7d6664)) * **reader-activation:** add integration health check system ([#4550](#4550)) ([4993f21](4993f21)) * **yoast:** add Bluesky contact method registration ([#4554](#4554)) ([aa143d7](aa143d7))

github-actions · 2026-03-30T20:00:26Z

🎉 This PR is included in version 6.36.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

fix: migrate newspack-theme checkout fixes

ccc72df

This was referenced Mar 11, 2026

fix: migrate newspack-theme checkout fixes Automattic/newspack-theme#2648

Merged

fix: modal checkout for blocks Automattic/newspack-blocks#2311

Merged

fix: add fallbacks

fd8b992

chickenn00dle marked this pull request as ready for review March 11, 2026 14:49

chickenn00dle requested a review from a team as a code owner March 11, 2026 14:49

Copilot AI review requested due to automatic review settings March 11, 2026 14:49

Copilot started reviewing on behalf of chickenn00dle March 11, 2026 14:50 View session

Copilot AI reviewed Mar 11, 2026

View reviewed changes

fix: apply copilot fixes

cf6242f

chickenn00dle added the [Status] Needs Review The issue or pull request needs to be reviewed label Mar 11, 2026

laurelfulford requested changes Mar 12, 2026

View reviewed changes

Comment thread src/newspack-ui/scss/elements/woocommerce/_overrides.scss Outdated

Comment thread src/newspack-ui/scss/elements/woocommerce/_overrides.scss Outdated

github-actions Bot added the [Status] Needs Changes or Feedback The issue or pull request needs action from the original creator label Mar 12, 2026

chickenn00dle and others added 2 commits March 12, 2026 13:48

fix: var-ception

1a1bc40

Co-authored-by: Laurel <laurel.fulford@automattic.com>

fix: var-ception

5863b7b

Co-authored-by: Laurel <laurel.fulford@automattic.com>

chickenn00dle requested a review from laurelfulford March 12, 2026 17:49

chickenn00dle removed the [Status] Needs Changes or Feedback The issue or pull request needs action from the original creator label Mar 12, 2026

laurelfulford approved these changes Mar 13, 2026

View reviewed changes

github-actions Bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Mar 13, 2026

chickenn00dle merged commit 6eb5f48 into trunk Mar 13, 2026
13 checks passed

chickenn00dle deleted the fix/modal-checkout-for-block-theme branch March 13, 2026 19:55

github-actions Bot added the needs-changelog label Mar 13, 2026

chickenn00dle removed the needs-changelog label Mar 13, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(block-theme): migrate newspack-theme checkout fixes#4557

fix(block-theme): migrate newspack-theme checkout fixes#4557
chickenn00dle merged 5 commits intotrunkfrom
fix/modal-checkout-for-block-theme

chickenn00dle commented Mar 11, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

laurelfulford left a comment

Uh oh!

Uh oh!

Uh oh!

chickenn00dle commented Mar 12, 2026

Uh oh!

laurelfulford left a comment

Uh oh!

Uh oh!

github-actions Bot commented Mar 13, 2026

Uh oh!

github-actions Bot commented Mar 19, 2026

Uh oh!

github-actions Bot commented Mar 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

chickenn00dle commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

All Submissions:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Other information:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

laurelfulford left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

chickenn00dle commented Mar 12, 2026

Uh oh!

laurelfulford left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Mar 13, 2026

Uh oh!

github-actions Bot commented Mar 19, 2026

Uh oh!

github-actions Bot commented Mar 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chickenn00dle commented Mar 11, 2026 •

edited

Loading