Skip to content

fix: migrate newspack-theme checkout fixes#2648

Merged
chickenn00dle merged 3 commits intotrunkfrom
fix/modal-checkout-for-block-theme
Mar 13, 2026
Merged

fix: migrate newspack-theme checkout fixes#2648
chickenn00dle merged 3 commits intotrunkfrom
fix/modal-checkout-for-block-theme

Conversation

@chickenn00dle
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Closes https://linear.app/a8c/issue/NPPD-1188/modal-checkout-testing-and-fixes

See Automattic/newspack-plugin#4557

How to test the changes in this Pull Request:

See Automattic/newspack-plugin#4557 for testing instructions

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@chickenn00dle chickenn00dle marked this pull request as ready for review March 11, 2026 14:48
@chickenn00dle chickenn00dle requested a review from a team as a code owner March 11, 2026 14:48
Copilot AI review requested due to automatic review settings March 11, 2026 14:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes theme-level WooCommerce checkout presentation tweaks that are being migrated elsewhere (per linked Newspack Plugin work) to avoid duplicating/overriding updated checkout behavior.

Changes:

  • Drop Select2 single-select sizing/focus overrides in the checkout styles.
  • Remove theme CSS for payment methods UI and the terms/conditions wrapper.
  • Remove the theme-added “Payment info” heading injected before the payment section.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
newspack-theme/sass/plugins/woocommerce.scss Removes checkout-specific CSS overrides for Select2, payment methods, and terms wrapper.
newspack-theme/inc/woocommerce.php Removes the hook that injected an extra payment heading into checkout.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chickenn00dle chickenn00dle added the [Status] Needs Review The issue or pull request needs to be reviewed label Mar 11, 2026
Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chickenn00dle! Just a couple CSS tweaks here, too, and it should be good to go!

Co-authored-by: Laurel <laurel.fulford@automattic.com>
@chickenn00dle
Copy link
Contributor Author

Also applied your suggestion here. Thank you! Should be good for another round of review.

Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chickenn00dle - looking good!

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Mar 13, 2026
@chickenn00dle chickenn00dle merged commit e4f9d91 into trunk Mar 13, 2026
9 checks passed
@chickenn00dle chickenn00dle deleted the fix/modal-checkout-for-block-theme branch March 13, 2026 19:57
@github-actions
Copy link

Hey @chickenn00dle, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Approved The pull request has been reviewed and is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants