fix: migrate newspack-theme checkout fixes#2648
Conversation
There was a problem hiding this comment.
Pull request overview
Removes theme-level WooCommerce checkout presentation tweaks that are being migrated elsewhere (per linked Newspack Plugin work) to avoid duplicating/overriding updated checkout behavior.
Changes:
- Drop Select2 single-select sizing/focus overrides in the checkout styles.
- Remove theme CSS for payment methods UI and the terms/conditions wrapper.
- Remove the theme-added “Payment info” heading injected before the payment section.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
newspack-theme/sass/plugins/woocommerce.scss |
Removes checkout-specific CSS overrides for Select2, payment methods, and terms wrapper. |
newspack-theme/inc/woocommerce.php |
Removes the hook that injected an extra payment heading into checkout. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
laurelfulford
left a comment
There was a problem hiding this comment.
Thanks @chickenn00dle! Just a couple CSS tweaks here, too, and it should be good to go!
Co-authored-by: Laurel <laurel.fulford@automattic.com>
|
Also applied your suggestion here. Thank you! Should be good for another round of review. |
laurelfulford
left a comment
There was a problem hiding this comment.
Thanks @chickenn00dle - looking good!
|
Hey @chickenn00dle, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
All Submissions:
Changes proposed in this Pull Request:
Closes https://linear.app/a8c/issue/NPPD-1188/modal-checkout-testing-and-fixes
See Automattic/newspack-plugin#4557
How to test the changes in this Pull Request:
See Automattic/newspack-plugin#4557 for testing instructions
Other information: