fix(block-theme): migrate newspack-theme checkout fixes#4557
Open
chickenn00dle wants to merge 5 commits intotrunkfrom
Open
fix(block-theme): migrate newspack-theme checkout fixes#4557chickenn00dle wants to merge 5 commits intotrunkfrom
chickenn00dle wants to merge 5 commits intotrunkfrom
Conversation
This was referenced Mar 11, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates modal checkout UI fixes from newspack-theme into the plugin so they also apply when using the Newspack block theme (especially around WooCommerce checkout/payment UI).
Changes:
- Add WooCommerce checkout hook to render a “Payment info” heading above the payment form.
- Extend Newspack UI WooCommerce overrides with payment-method layout/styling and select2 sizing fixes.
- Adjust Newspack UI table styling to use
border-collapse: collapse.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/newspack-ui/scss/elements/woocommerce/_overrides.scss | Adds checkout/payment-method and select2 overrides intended to improve modal checkout styling. |
| src/newspack-ui/scss/elements/_tables.scss | Collapses table borders for more consistent table rendering in UI. |
| includes/plugins/woocommerce/class-woocommerce-connection.php | Loads the new checkout feature class as part of WooCommerce integration init. |
| includes/plugins/woocommerce/class-woocommerce-checkout.php | New WooCommerce checkout feature: inserts a payment heading via WooCommerce hook. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
laurelfulford
requested changes
Mar 12, 2026
Contributor
laurelfulford
left a comment
There was a problem hiding this comment.
Looks good @chickenn00dle! Just needs a couple CSS tweaks and it should be good to go!
Co-authored-by: Laurel <laurel.fulford@automattic.com>
Co-authored-by: Laurel <laurel.fulford@automattic.com>
Contributor
Author
|
Thanks @laurelfulford! I applied your suggestions. This should be good for another round of review as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Closes https://linear.app/a8c/issue/NPPD-1188/modal-checkout-testing-and-fixes
This PR moves over some of the styles and fixes from newspack-theme so they also apply to block theme.
How to test the changes in this Pull Request:
fix/modal-checkout-for-block-themebranch for the following repos:newspack-theme,newspack-blocks, andnewspack-pluginOther information: