Skip to content

fix(block-theme): migrate newspack-theme checkout fixes#4557

Open
chickenn00dle wants to merge 5 commits intotrunkfrom
fix/modal-checkout-for-block-theme
Open

fix(block-theme): migrate newspack-theme checkout fixes#4557
chickenn00dle wants to merge 5 commits intotrunkfrom
fix/modal-checkout-for-block-theme

Conversation

@chickenn00dle
Copy link
Contributor

@chickenn00dle chickenn00dle commented Mar 11, 2026

All Submissions:

Changes proposed in this Pull Request:

Closes https://linear.app/a8c/issue/NPPD-1188/modal-checkout-testing-and-fixes

This PR moves over some of the styles and fixes from newspack-theme so they also apply to block theme.

How to test the changes in this Pull Request:

  • Checkout the fix/modal-checkout-for-block-theme branch for the following repos: newspack-theme, newspack-blocks, and newspack-plugin
  • Activate the newspack block theme
  • Smoke test modal checkout in various scenarios including:
    • Checkout Button
    • Donate Block
    • One payment gateway
    • Multiple payment gateways
    • Various fields set in Audience > Configuration > Checkout & Payment
    • Anything else you can think of!
  • Activate the newspack theme
  • Repeat smoke tests
  • Finally smoke test standard Woo checkout

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@chickenn00dle chickenn00dle marked this pull request as ready for review March 11, 2026 14:49
@chickenn00dle chickenn00dle requested a review from a team as a code owner March 11, 2026 14:49
Copilot AI review requested due to automatic review settings March 11, 2026 14:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Migrates modal checkout UI fixes from newspack-theme into the plugin so they also apply when using the Newspack block theme (especially around WooCommerce checkout/payment UI).

Changes:

  • Add WooCommerce checkout hook to render a “Payment info” heading above the payment form.
  • Extend Newspack UI WooCommerce overrides with payment-method layout/styling and select2 sizing fixes.
  • Adjust Newspack UI table styling to use border-collapse: collapse.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
src/newspack-ui/scss/elements/woocommerce/_overrides.scss Adds checkout/payment-method and select2 overrides intended to improve modal checkout styling.
src/newspack-ui/scss/elements/_tables.scss Collapses table borders for more consistent table rendering in UI.
includes/plugins/woocommerce/class-woocommerce-connection.php Loads the new checkout feature class as part of WooCommerce integration init.
includes/plugins/woocommerce/class-woocommerce-checkout.php New WooCommerce checkout feature: inserts a payment heading via WooCommerce hook.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chickenn00dle chickenn00dle added the [Status] Needs Review The issue or pull request needs to be reviewed label Mar 11, 2026
Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @chickenn00dle! Just needs a couple CSS tweaks and it should be good to go!

@github-actions github-actions bot added the [Status] Needs Changes or Feedback The issue or pull request needs action from the original creator label Mar 12, 2026
chickenn00dle and others added 2 commits March 12, 2026 13:48
Co-authored-by: Laurel <laurel.fulford@automattic.com>
Co-authored-by: Laurel <laurel.fulford@automattic.com>
@chickenn00dle
Copy link
Contributor Author

Thanks @laurelfulford! I applied your suggestions. This should be good for another round of review as well.

@chickenn00dle chickenn00dle removed the [Status] Needs Changes or Feedback The issue or pull request needs action from the original creator label Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Needs Review The issue or pull request needs to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants