Updates to public quilt data #166
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mfs4rd can you add some description of what this PR is doing? For example why removing the test dataset downloading? |
|
@vianamp Updated PR description. Test data downloading has been removed since there are no subsets of the data provided in the public dataset as in the private dataset. We would need to implement a method of properly sampling the dataset and trimming the relevant manifests if we want to keep this feature. |
vianamp
approved these changes
Dec 4, 2024
| @@ -48,7 +48,8 @@ make_cellprofiler_image_set \ | |||
| --defaults_json fish_morphology_code/cellprofiler/cellprofiler_image_set_defaults.json \ | |||
| --path_key rescaled_2D_fov_tiff_path \ | |||
| --local_path ./quilt_data_contrasted_test \ | |||
There was a problem hiding this comment.
Should we remove test from the path since there is no longer a test set?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This updates the quilt paths used to download data used in the paper to match what is on the publicly available dataset
Key changes