Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RedirectManager: support combining query string in the target with query string in the request #3510

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
+362 −44
Open

RedirectManager: support combining query string in the target with query string in the request #3510

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
afe3ef0
#3509 support combining query string in the target with query string …
YegorKozlov Jan 19, 2025
c94620a
more tests
YegorKozlov Jan 19, 2025
fd01583
code climate issues
YegorKozlov Jan 19, 2025
a33ab6e
Merge branch 'master' into redirects-qs
YegorKozlov Jan 19, 2025
3542af1
code climate issues
YegorKozlov Jan 19, 2025
cf95c6f
#3509 'combine' mode is default
YegorKozlov Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
code climate issues
@YegorKozlov
YegorKozlov committed Jan 19, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit 3542af19a6e6c5878318079ea06bb8d10c069bd7
2 changes: 1 addition & 1 deletion bundle/src/main/java/com/adobe/acs/commons/redirects/filter/RedirectFilter.java
View file
Original file line number Diff line number Diff line change
@@ -150,7 +150,7 @@ public class RedirectFilter extends AnnotatedStandardMBean
@AttributeDefinition(name = "Request Paths", description = "List of paths for which redirection is allowed", type = AttributeType.STRING)
String[] paths() default {"/content"};

@AttributeDefinition(name = "Preserve Query String", description = "Preserve query string in redirects", type = AttributeType.BOOLEAN)
@AttributeDefinition(name = "Preserve Query String", description = "Deprecated. Since v6.11 you can manage handling query string in Redirect Properties.", type = AttributeType.BOOLEAN)
boolean preserveQueryString() default true;

@AttributeDefinition(name = "Preserve Extension", description = "Whether to preserve extensions. "
2 changes: 1 addition & 1 deletion bundle/src/main/java/com/adobe/acs/commons/redirects/models/HandleQueryString.java
View file
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@
* #%L
* ACS AEM Commons Bundle
* %%
* Copyright (C) 2013 - 2024 Adobe
* Copyright (C) 2013 - 2025 Adobe
* %%
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.