Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RedirectManager: support combining query string in the target with query string in the request #3510

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

YegorKozlov
Copy link
Contributor

Addresses #3509

With this PR users can configure handling query string per redirect. There is a new dropdown in the configuration dialog:

image

If the per-redirect option is not set then redirect manager falls back to the OSGi configuration, matching old implementation.

Copy link

github-actions bot commented Jan 19, 2025

Test Results

 2 907 files   -  63   2 907 suites   - 63   1h 35m 39s ⏱️ + 1m 44s
 1 858 tests  -  32   1 858 ✅  -  32  0 💤 ±0  0 ❌ ±0 
16 722 runs   - 288  16 713 ✅  - 288  9 💤 ±0  0 ❌ ±0 

Results for commit cf95c6f. ± Comparison against base commit 6932178.

This pull request removes 38 and adds 6 tests. Note that renamed tests count towards both.
com.adobe.acs.commons.logging.impl.SyslogAppenderTest ‑ testActivate
com.adobe.acs.commons.logging.impl.SyslogAppenderTest ‑ testConstructSyslogAppender
com.adobe.acs.commons.oakpal.checks.AcsCommonsAuthorizableCompatibilityCheckTest ‑ testCheckAcme
com.adobe.acs.commons.oakpal.checks.AcsCommonsAuthorizableCompatibilityCheckTest ‑ testCheckAcsCommonsDerivedGroup
com.adobe.acs.commons.oakpal.checks.AcsCommonsAuthorizableCompatibilityCheckTest ‑ testCheckAcsCommonsDeveloper
com.adobe.acs.commons.oakpal.checks.AcsCommonsAuthorizableCompatibilityCheckTest ‑ testCheckAcsCommonsServiceUserForAcme
com.adobe.acs.commons.oakpal.checks.AcsCommonsAuthorizableCompatibilityCheckTest ‑ testCheckAll
com.adobe.acs.commons.oakpal.checks.AcsCommonsAuthorizableCompatibilityCheckTest ‑ testCheckDevelopers
com.adobe.acs.commons.oakpal.checks.AcsCommonsAuthorizableCompatibilityCheckTest ‑ testCheckNone
com.adobe.acs.commons.oakpal.checks.ContentClassificationsTest ‑ testCheckAllValid
…
com.adobe.acs.commons.redirects.filter.RedirectFilterTest ‑ testCombineQueryString
com.adobe.acs.commons.redirects.filter.RedirectFilterTest ‑ testCombineQueryStringAndPreserveExtension
com.adobe.acs.commons.redirects.filter.RedirectFilterTest ‑ testIgnoreQueryString
com.adobe.acs.commons.redirects.filter.RedirectFilterTest ‑ testPreserveExtensionMethod
com.adobe.acs.commons.redirects.filter.RedirectFilterTest ‑ testPreserveQueryStringConfiguration
com.adobe.acs.commons.redirects.filter.RedirectFilterTest ‑ testReplaceQueryString

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant