Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions lib/binary_to_decimal.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,18 @@
# The least significant bit is at index 7.
# Calculate and return the decimal value for this binary number using
# the algorithm you devised in class.
def binary_to_decimal(binary_array)
raise NotImplementedError
def binary_to_decimal(bin_array)
score = 0

bin_array.each_with_index do |binary, index|
if binary == 1
score += (2 ** (8 - (index + 1)))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love how the calculation is all on one line. Amazing. Also like how you used the index to decrease the exponent each time. 👌

end
end
# eight_decimals = []

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would delete the code that's commented out, since you're not using it. That way it's more readable and someone else won't accidentally uncomment something they shouldn't.

# 8.times do
# eight_decimals << rand(0..1)
# end
# raise NotImplementedError
return score
end