Ports - Jillianne #44
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubha-rajan
reviewed
Mar 2, 2019
| score += (2 ** (8 - (index + 1))) | ||
| end | ||
| end | ||
| # eight_decimals = [] |
There was a problem hiding this comment.
I would delete the code that's commented out, since you're not using it. That way it's more readable and someone else won't accidentally uncomment something they shouldn't.
shubha-rajan
reviewed
Mar 2, 2019
|
|
||
| bin_array.each_with_index do |binary, index| | ||
| if binary == 1 | ||
| score += (2 ** (8 - (index + 1))) |
There was a problem hiding this comment.
I love how the calculation is all on one line. Amazing. Also like how you used the index to decrease the exponent each time. 👌
shubha-rajan
reviewed
Mar 2, 2019
shubha-rajan
left a comment
shubha-rajan
left a comment
There was a problem hiding this comment.
Nice job! Just delete the commented out code and you're good! Also I'm not sure if we could use each_with_index on this assignment (idk where I heard that we couldn't) so if you want to redo this assignment in Hard Mode, try it with a while loop instead ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binary and Decimal
Congratulations! You're submitting your assignment.