fix: DesktopNotifier.send_sync() -> DesktopNotifierSync.send() and Icons#4
Closed
yuhldr wants to merge 2 commits intoActivityWatch:masterfrom
Closed
fix: DesktopNotifier.send_sync() -> DesktopNotifierSync.send() and Icons#4yuhldr wants to merge 2 commits intoActivityWatch:masterfrom
yuhldr wants to merge 2 commits intoActivityWatch:masterfrom
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 3422ea4 in 9 seconds
More details
- Looked at
39lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. aw_notify/main.py:24
- Draft comment:
Updated import toDesktopNotifierSyncto match the new API changes in the desktop-notifier library. - Reason this comment was not posted:
Confidence changes required:0%
The PR changes the import and usage ofDesktopNotifiertoDesktopNotifierSyncand updates the method call fromsend_synctosend. This aligns with the changes in the desktop-notifier library as per the provided documentation link. The changes are consistent and correctly applied in thenotifyfunction.
Workflow ID: wflow_941XbrCmQT3m8Dzl
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
yuhldr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
desktop-notifier docs:
DesktopNotifier.send_sync()APIhttps://github.com/samschott/desktop-notifier/blob/26c6af2f96cefdc9ce3d63606e40446ab5b36a9a/CHANGES.md?plain=1#L70
https://github.com/samschott/desktop-notifier/blob/26c6af2f96cefdc9ce3d63606e40446ab5b36a9a/CHANGES.md?plain=1#L61C1-L61C77