Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

BelKed
Copy link

@BelKed BelKed commented Feb 11, 2025

The dependencies wasn't updated in a while, now it works (at least on my computer :D)



Important

Update dependencies, GitHub Actions workflow, and adjust code for compatibility with new versions.

  • Dependencies:
    • Update aw-client to ^0.5.15 and desktop-notifier to ^6.0.0 in pyproject.toml.
    • Update rubicon-objc to ^0.5.0 for darwin platform in pyproject.toml.
    • Update pyinstaller to ^6.12.0 in pyproject.toml.
  • GitHub Actions:
    • Update os matrix to ubuntu-latest, windows-latest, macOS-latest in build.yml.
    • Update python_version to 3.13 in build.yml.
    • Update actions/checkout to v4 and actions/setup-python to v5 in build.yml.
    • Remove specific poetry version pinning in build.yml.
  • Code Changes:
    • Use Icon class for app_icon in DesktopNotifier in main.py.
    • Implement asyncio event loop handling for notifications in notify() in main.py.

This description was created by Ellipsis for bfc2e10. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to bfc2e10 in 1 minute and 36 seconds

More details
  • Looked at 100 lines of code in 3 files
  • Skipped 1 files when reviewing.
  • Skipped posting 5 drafted comments based on config settings.
1. .github/workflows/build.yml:33
  • Draft comment:
    Removing the fixed poetry version may introduce build inconsistencies if a new release behaves differently. Consider pinning a specific version.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    The comment is about a dependency change, specifically the removal of a fixed version for a dependency management tool (poetry). The comment suggests pinning a specific version to avoid build inconsistencies. This falls under the rule of not commenting on dependency changes or library versions, as it doesn't provide a specific code suggestion or ask for a test to be written.
2. aw_notify/main.py:169
  • Draft comment:
    Using run_until_complete in notify() may conflict if an event loop is already running. Ensure this sync call won’t be invoked from an async context.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
3. .github/workflows/build.yml:33
  • Draft comment:
    Using 'pip install poetry' without pinning may lead to unstable builds if a future version introduces breaking changes. Consider using a specific version.
  • Reason this comment was not posted:
    Marked as duplicate.
4. aw_notify/main.py:169
  • Draft comment:
    Calling run_until_complete on an event loop from get_running_loop may raise an error if a loop is already running. Consider using asyncio.run (or ensure notify is only called in sync contexts).
  • Reason this comment was not posted:
    Marked as duplicate.
5. pyproject.toml:18
  • Draft comment:
    The dependency desktop-notifier has been updated to ^6.0.0; ensure that all necessary API migration changes (e.g. using Icon and async send) are fully tested and compatible across platforms.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is about a dependency update and suggests ensuring compatibility and testing, which violates the rules against commenting on dependency changes and asking for confirmation or testing.

Workflow ID: wflow_1UZAUPBIRyX6FO1y


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to use aw-notify on macOS
1 participant