Skip to content

fix: vrng consumer unused immutable var #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coffeexcoin merged 2 commits into from
Jan 30, 2026
Merged

fix: vrng consumer unused immutable var #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
822b744
fix: vrng consumer unused immutable var
coffeexcoin Jan 30, 2026
ad2b380
fix env
coffeexcoin Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ on:
release:
types: [created]

env:
FOUNDRY_PROFILE: ci

jobs:
package:

Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ on:
pull_request:
workflow_dispatch:

env:
FOUNDRY_PROFILE: ci

jobs:
check:
strategy:
Expand Down
6 changes: 4 additions & 2 deletions src/utils/vrng/VRNGConsumerAdvanced.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,17 @@ abstract contract VRNGConsumerAdvanced is IVRNGSystemCallback {
bytes32 private constant VRNG_STORAGE_LOCATION = 0xfc4de942100e62e9eb61034c75124e3689e7605ae081e19c59907d5c442ea700;

/// @dev The function used to normalize the drand random number
function(uint256,uint256) internal returns(uint256) internal immutable _normalizeRandomNumber;
function(uint256, uint256) internal returns (uint256) internal immutable _normalizeRandomNumber;

struct VRNGConsumerStorage {
IVRNGSystem vrng;
mapping(uint256 requestId => VRNGRequest details) requests;
}

/// @notice The VRNG system contract address
IVRNGSystem public immutable vrng;
function vrng() public view virtual returns (address) {
return address(_getVRNGStorage().vrng);
}

/// @dev Create a new VRNG consumer with the specified normalization method.
/// @param normalizationMethod The normalization method to use. See `VRNGNormalizationMethod` for more details.
Expand Down
15 changes: 10 additions & 5 deletions test/vrng/VRNGConsumerTest.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@ contract VRNGConsumerTest is TestBase {
vrngConsumerMostEfficient.setVRNG(address(vrngSystem));
}

function test_vrngGetterReturnsVrngSystem() public view {
assertEq(address(vrngConsumer.vrng()), address(vrngSystem));
assertEq(address(vrngConsumerMostNormalized.vrng()), address(vrngSystem));
assertEq(address(vrngConsumerMostEfficient.vrng()), address(vrngSystem));
}

function test_uninitializedVrngRevertsOnRequest() public {
// uninitialize the vrng system
vrngConsumer.setVRNG(address(0));
Expand Down Expand Up @@ -59,9 +65,7 @@ contract VRNGConsumerTest is TestBase {
vrngConsumer.randomNumberCallback(requestId, randomNumber);
}

function testFuzz_fulfillRandomRequestAlreadyFulfilledReverts(uint256 randomNumber1, uint256 randomNumber2)
public
{
function testFuzz_fulfillRandomRequestAlreadyFulfilledReverts(uint256 randomNumber1, uint256 randomNumber2) public {
uint256 requestId = vrngSystem.nextRequestId();
vrngConsumer.triggerRandomNumberRequest();

Expand Down Expand Up @@ -158,8 +162,9 @@ contract VRNGConsumerTest is TestBase {
}

function _assemblyCreate(uint8 normalizationMethod) internal returns (address result) {
bytes memory code =
abi.encodePacked(type(MockVRNGConsumerAdvancedImplementation).creationCode, abi.encode(normalizationMethod));
bytes memory code = abi.encodePacked(
type(MockVRNGConsumerAdvancedImplementation).creationCode, abi.encode(normalizationMethod)
);

// Deploy via assembly to avoid enum revert inside the test code
assembly {
Expand Down