You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Medium Risk
Changes the public ABI of VRNGConsumerAdvanced by replacing an immutablevrng variable with a vrng() getter returning address, which could affect downstream integrations. CI workflows also drop the global FOUNDRY_PROFILE, potentially altering build/test configuration.
Overview Refactors VRNG consumer contract API.VRNGConsumerAdvanced drops the unused public immutable vrng field and replaces it with a vrng() view getter that returns the configured VRNG system address from storage; the _normalizeRandomNumber function pointer signature is also reformatted.
Tests/CI updates. Adds a test asserting the new vrng() getter returns the configured system, plus minor test formatting tweaks, and removes the top-level FOUNDRY_PROFILE: ci from the release.yml and test.yml GitHub workflows.
Written by Cursor Bugbot for commit ad2b380. This will update automatically on new commits. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on refining the
VRNGConsumerAdvancedcontract and its associated tests by improving function definitions and adding new test cases.Detailed summary
_normalizeRandomNumberfor clarity.vrng()function to retrieve the VRNG system contract address.test_vrngGetterReturnsVrngSystem()to validate the VRNG system address retrieval.testFuzz_fulfillRandomRequestAlreadyFulfilledRevertsfunction._assemblyCreate.