Repository navigation
Fix generic eval paths after changing the working directory - #113
Merged
Merged
Conversation
haofrank
marked this pull request as ready for review
September 29, 2026 04:55
This was referenced Sep 29, 2026
irvineoy
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relative launches such as
bash benchmarks/sglang_mi355x.shsource InferenceX'sbenchmark_lib.shwith a relative path. Magpie then changes into the isolated eval output directory, so the library's deferredBASH_SOURCElookups can no longer find the GSM8K task orlm_eval_sitecustomize.py. A real Hyperloom synthetic GPU run completed throughput but failed accuracy evaluation with this error.Resolve each generic benchmark script's directory before sourcing its dependencies. Deferred eval lookups now remain absolute after the working-directory change, including paths containing spaces. The persisted accuracy workflow, runner commands, and native AgentX launcher are unchanged.
Validation covers relative and absolute entrypoints through the real persisted-eval wrapper, task/patch lookup after the directory change, and persisted accuracy artifacts. The regression fails against the original scripts. Locally, 169 relevant tests passed. CI passed on Python 3.10 and 3.12: 629 passed and 1 skipped on each; coverage is 90.16%. The real Crusoe MI355X GPU rerun passed at Hyperloom
0ef71137fwith Magpiea3339dc: 320/320 synthetic Qwen3-0.6B throughput requests, 15,637.91443 output tokens/s, and GSM8K strict-match 43/64 (67.1875%) with accuracy enabled and Magpie exit code 0. Torch/SGLang versions were unchanged. This exercises BaselineExecutor, not the full LLM optimizer loop. Detailed results: Hyperloom validation comment.Required by AMD-AGI/Hyperloom#1675. This is a post-release fix on top of
v0.3.0; it does not move the existing tag.