Skip to content

Withdraw AgentX launcher extensions / 撤回 AgentX 启动器扩展 - #3577

Closed
haofrank wants to merge 2 commits into
SemiAnalysisAI:mainfrom
haofrank:feature/agentx-launch-extension
Closed

haofrank wants to merge 2 commits into
SemiAnalysisAI:mainfrom
haofrank:feature/agentx-launch-extension

Conversation

@haofrank

@haofrank haofrank commented Sep 29, 2026 •

Copy link
Copy Markdown

Withdrawn — 2026-09-29

This legacy Bash-launcher extension is no longer being proposed. It was developed on an older pinned InferenceX commit without rebasing onto the YAML/SRT migration. Magpie will own service startup, lifecycle, optimizer parameters, source-patch verification, and launch evidence, while using the upstream benchmark clients and result validation against an already-running endpoint. This integration does not require Magpie to adopt Slurm or add hooks to retired InferenceX server launchers.

The existing branch and commits are retained for provenance. Magpie #114 requires implementation rework; Hyperloom #1675 must replace its dependency on this launch contract. Previous test results below describe the withdrawn implementation, not the replacement design. See the official standalone AgentX client guide.

本 PR 撤回旧 Bash 启动器扩展方案。开发时沿用了旧的 InferenceX 固定提交,没有先 rebase 到已迁移至 YAML/SRT 的主分支。后续由 Magpie 管理服务启动与生命周期、优化参数、源码补丁校验和实际启动证据;上游 benchmark 客户端与结果校验负责测试已经运行的服务。这种接入不要求 Magpie 使用 Slurm,也不需要给已退役的 InferenceX 服务启动器增加 hook。

保留现有分支和提交以便追溯。Magpie #114 需要重做执行接线,Hyperloom #1675 需要替换对本启动契约的依赖。下方测试结果仅对应撤回的旧实现,不代表新方案已完成或通过验证。参考官方独立 AgentX 客户端说明。

Previous implementation and validation / 原实现与验证记录

AgentX's canonical launchers previously assembled fixed server commands without a structured extension for an optimizer. This adds an opt-in v1 argv/environment interface with protected model, topology, endpoint, and context fields; verifies candidate source hashes/absences after setup; and records the base/effective launch with hash-bound evidence. Without an extension, existing launcher commands remain unchanged.

It also declares native custom-model SGLang/vLLM launchers for single-node MI300X/MI325X/MI355X. They use the existing canonical trace replay/aggregation path, validate model config metadata and context, and include those fields in result provenance. Registered recipes remain separately declared in the manifest.

Validation: 114 CPU-only tests passed, one existing Bash-4-only syntax test skipped on macOS Bash 3. Tests cover real Bash-to-helper boundaries, literal argv/environment, protected protocol fields, source identity, metadata/context checks, manifests, and aggregation. No new GPU performance or correctness result is claimed by these tests. Append-only performance changelog and English/Chinese documentation are included.

Companion Magpie #114 builds on Magpie #113; that generic eval source-path fix is separate from this native launch interface.


AgentX 的 canonical 启动器此前固定组装服务端命令,没有面向优化器的结构化扩展接口。本变更增加显式启用的 v1 参数与环境接口,保护模型、拓扑、端点和上下文字段;在安装结束后核验候选源文件哈希及删除状态;记录带哈希绑定的原始与实际启动证据。未启用扩展时,已有启动命令保持原样。

同时声明 MI300X/MI325X/MI355X 单节点的原生自定义模型 SGLang/vLLM 启动器,沿用现有 canonical trace replay 和聚合流程,核验模型配置及上下文,并将其写入结果来源信息。已有注册配方继续在 manifest 中单独声明。

验证:114 项 CPU 测试通过,macOS Bash 3 下跳过 1 项已有的 Bash 4 语法检查。覆盖真实 Bash/helper 边界、字面参数与环境、协议保护、源文件身份、模型上下文、manifest 和聚合。该结果不代表新增 GPU 性能或正确性验证。已追加性能变更记录并同步中英文文档。

配套 Magpie 集成基于 Magpie #113;其中通用 eval 的 source 路径修复与本次原生启动接口属于独立问题。

为 AgentX 增加正式服务启动扩展,校验参数、运行时环境和候选源码;未启用扩展时保留原有 canonical 命令。
支持 AMD 单节点 SGLang/vLLM 自定义模型,沿用 canonical AgentX 重放,核验模型配置哈希和原生上下文,并固定工作负载身份。

@functionstackx functionstackx left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can u rebase it off of remote main plz. We have switched to declarative yaml instead of bash

@haofrank haofrank changed the title Add explicit AgentX server launch overrides and custom-model replay Withdraw AgentX launcher extensions / 撤回 AgentX 启动器扩展 Sep 29, 2026
@haofrank haofrank closed this Sep 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants