Skip to content

fix: empty catch blocks silently swallow errors#14

Merged
DanielCotoJ merged 5 commits into
ACTA-Team:mainfrom
Meet-hybrid:fix/swallowed-error-handling
Jun 29, 2026
Merged

fix: empty catch blocks silently swallow errors#14
DanielCotoJ merged 5 commits into
ACTA-Team:mainfrom
Meet-hybrid:fix/swallowed-error-handling

Conversation

@Meet-hybrid

@Meet-hybrid Meet-hybrid commented Jun 24, 2026

Copy link
Copy Markdown

Closes #10

Several catch blocks discarded the caught error without logging or notifying the user:

  • src/app/demo/vault/list/page.tsxcopyId clipboard errors
  • src/components/modules/vault/hooks/use-vault-setup.tssaveComputedDid() errors in useEffect, copyToClipboard unhandled rejection
  • src/layouts/Header.tsxhandleConnect / handleDisconnect wallet errors

Changes

  • Every failure path now logs (console.warn) and shows a user-facing sonner toast
  • navigator.clipboard.writeText is awaited and wrapped in try/catch
  • No empty catch {} blocks remain in the affected files

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 07b07ef9-2912-471b-87f2-a5990e11a36c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@DanielCotoJ DanielCotoJ merged commit 7b37137 into ACTA-Team:main Jun 29, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants