Empty `catch` blocks silently swallow errors

[DanielCotoJ]

Summary

Several catch blocks discard the caught error without logging it or notifying
the user. When clipboard, wallet, or DID operations fail, nothing happens —
making real failures invisible and very hard to debug in production.

Affected code

• src/app/demo/vault/list/page.tsx:24-28 — copyId swallows clipboard errors.
• src/components/modules/vault/hooks/use-vault-setup.ts:49-55 — saveComputedDid() errors are swallowed in a useEffect.
• src/layouts/Header.tsx:13-26 — handleConnect / handleDisconnect swallow wallet errors.

Note: copyToClipboard in use-vault-setup.ts:57-66 calls
navigator.clipboard.writeText(text) without any try/catch or await, so a
rejected promise becomes an unhandled rejection. This should be fixed in the
same pass.

Why it's a problem

• Users get no feedback when "Copy" silently fails (e.g. non-secure context, or
  browsers that block clipboard access).
• A failed wallet connection in handleConnect looks identical to "nothing
  happened", confusing users.
• Swallowed errors never reach logs or monitoring, so issues are invisible until
  a user reports them.

Step-by-step fix

1. Standardize on the existing toast utility. The project already uses
   sonner (import { toast } from 'sonner'). Reuse it for user-facing feedback
   so the UX stays consistent.
2. Fix copyId in vault/list/page.tsx:
   • Import toast from sonner.
   • On success, call toast.success('Copied to clipboard').
   • In the catch (e) block, call toast.error('Could not copy') and
     console.warn('Clipboard copy failed', e).
3. Fix copyToClipboard in use-vault-setup.ts:
   • Make the callback async and await navigator.clipboard.writeText(text)
     inside a try/catch.
   • On failure, show toast.error('Could not copy') and keep the copied*
     state from flipping to true.
4. Fix the saveComputedDid effect in use-vault-setup.ts:
   • In the catch (e) block, add console.warn('Failed to compute DID', e).
   • Optionally surface a non-blocking toast.error('Could not initialize DID').
5. Fix handleConnect / handleDisconnect in Header.tsx:
   • In each catch (e), log with console.warn(...).
   • For handleConnect, show toast.error('Could not connect wallet') (replace
     the "swallow to avoid extra alerts" comment — a single toast is the
     intended single alert).
6. Lint & build: run npm run lint and npm run build to confirm no
   unused-variable warnings remain from the renamed catch (e) parameters.
7. Manual test:
   • Trigger a copy in an insecure context (or stub navigator.clipboard) and
     confirm an error toast appears.
   • Disconnect the wallet mid-connect and confirm the error is logged/toasted.

Acceptance criteria

• No empty catch {} blocks remain in the affected files.
• Every failure path either logs (console.warn/console.error) or shows a
  toast (preferably both).
• navigator.clipboard.writeText calls are awaited and wrapped in try/catch.

---

[ekwe7]

I would love to work on this issue. I have experience building production ready applications and collaborating through GitHub workflows. I'll carefully analyze the current implementation, propose a reliable solution, and submit a well-tested PR. My focus is on clean code, maintainability, and timely delivery

[davidacunalopez]

Hola, my name is David Acuña, full stack developer. I reviewed the issue and would like to apply. I would resolve it as follows: replace the empty catch {} blocks in the three affected files with error handling consistent with what the project already uses — sonner is mounted in the global layout and other hooks (use-vault-setup, use-credential-form) already show toasts on failure. In vault/list/page.tsx, I would add feedback in copyId (toast.success on copy, toast.error + console.warn on failure). In use-vault-setup.ts, I would make copyToClipboard async with await navigator.clipboard.writeText inside try/catch, without setting the copied* state if it fails, and in the saveComputedDid useEffect I would log the failure with console.warn and show a non-blocking toast. In Header.tsx, I would import toast, remove the “swallow errors” comment, and show a clear message in handleConnect, with logging in both wallet handlers.

The change is scoped and low risk: a single PR touching those three files, with no new abstractions or architectural changes. I would finish by validating with npm run lint and npm run build, and manually testing clipboard copy in an insecure context or with clipboard blocked, plus wallet connect/disconnect, to ensure failures are visible to the user and no rejected promises are left unhandled.

[Meet-hybrid]

@Meet-hybrid has applied to work on this issue as part of the Stellar Wave Program's 6th wave.

Can I work on this please?

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Meet-hybrid to this issue.

[grantfox-oss]

🦊 GrantFox — @Meet-hybrid has been assigned to this issue!

Next steps:

1. Open a Pull Request referencing this issue (e.g., Closes #10)
2. Your PR will be reviewed by the ACTA-Team maintainers

Good luck! Track your progress on GrantFox.

[drips-wave]

Congratulations, @Meet-hybrid! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on June 30, 2026.

🧑‍💻 @Meet-hybrid: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[grantfox-oss]

🎉 This issue has been marked as completed on GrantFox!

@Meet-hybrid's PR #14 was approved and merged by @DanielCotoJ.

🏆 @Meet-hybrid: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (996 total points). Track your full progress on GrantFox.

👏 Great work, @Meet-hybrid! Keep contributing to ACTA-Team.

[grantfox-oss]

🎉 This issue has been marked as completed on GrantFox!

@Meet-hybrid's PR #17 was approved and merged by @JosueBrenes.

🏆 @Meet-hybrid: You earned 40 FoxPoints for this contribution! Your current tier: Builder (1,612 total points). Track your full progress on GrantFox.

👏 Great work, @Meet-hybrid! Keep contributing to ACTA-Team.