-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Webpack Config Files & Add Citation File #695
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3cc7284
Updated Webpack Config Files
5297141
Add Citation File
4c98804
Check and Remove Build Script
6afa98a
Added Change Explain Comment
91926b0
Added EOL to Citation File
e366b28
Updated CodeQL Workflow
3c43b43
Updated CodeQL Workflow - v2
b726359
Updated Comments for CI
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
cff-version: 1.2.0 | ||
title: '3Dmol.js: molecular visualization with WebGL' | ||
message: If you use 3Dmol.js, please cite our Bioinformatics paper | ||
type: software | ||
authors: | ||
- given-names: David | ||
family-names: Koes | ||
email: [email protected] | ||
affiliation: University of Pittsburgh | ||
orcid: 'https://orcid.org/0000-0002-6892-6614' | ||
- given-names: Nicholas | ||
family-names: Rego | ||
affiliation: University of Pittsburgh | ||
orcid: 'https://orcid.org/0000-0002-3164-6803' | ||
identifiers: | ||
- type: doi | ||
value: 10.1093/bioinformatics/btu829 | ||
repository-code: 'https://github.com/3dmol/3Dmol.js' | ||
url: 'https://3dmol.org/' | ||
abstract: >- | ||
3Dmol.js is a modern, object-oriented JavaScript library | ||
that uses the latest web technologies to provide | ||
interactive, hardware-accelerated three-dimensional | ||
representations of molecular data without the need to | ||
install browser plugins or Java. 3Dmol.js provides a full | ||
featured API for developers as well as a straightforward | ||
declarative interface that lets users easily share and | ||
embed molecular data in websites. | ||
license: BSD-3-Clause |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,10 @@ | ||
/* eslint-disable no-undef*/ | ||
|
||
const { merge } = require('webpack-merge'); | ||
const common = require('./webpack.common.js'); | ||
|
||
module.exports = merge(common, { | ||
mode: 'development', | ||
devtool: 'inline-source-map', | ||
mode: 'development', | ||
devtool: 'inline-source-map', | ||
output: { | ||
filename: `[name].js`, | ||
} | ||
filename: '[name].js', | ||
}, | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,28 +1,25 @@ | ||
/* eslint-disable no-undef*/ | ||
|
||
const { merge } = require('webpack-merge'); | ||
const common = require('./webpack.common.js'); | ||
const TerserPlugin = require('terser-webpack-plugin'); | ||
|
||
module.exports = merge(common, { | ||
mode: 'production', | ||
mode: "production", | ||
optimization: { | ||
usedExports: false, //essential for pulling in $3Dmol namespace | ||
usedExports: false, | ||
minimizer: [ | ||
new TerserPlugin({ | ||
parallel: true, | ||
terserOptions: { | ||
keep_classnames: true, | ||
compress: true, | ||
mangle: | ||
{ | ||
mangle: { | ||
reserved: ["MarchingCube"], | ||
} | ||
}, | ||
}, | ||
}), | ||
], | ||
}, | ||
output: { | ||
filename: `[name]-min.js`, | ||
} | ||
}, | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is here for a reason - so VS code doesn't report errors where there are none.