-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Webpack Config Files & Add Citation File #695
Conversation
Signed-off-by: Adithya Krishna <[email protected]>
Signed-off-by: Adithya Krishna <[email protected]>
I have created the citation file to the best of my knowledge, please do let me know if there are any other changes required to it 😶 |
Signed-off-by: Adithya Krishna <[email protected]>
Signed-off-by: Adithya Krishna <[email protected]>
.github/workflows/CI.yml
Outdated
- name: Install Dependencies | ||
# As our package has a postInstall script, we dont need a explicit job for that | ||
- name: Install & Build Dependencies | ||
run: npm install | ||
|
||
- name: Build 3Dmol.js | ||
run: | | ||
npm run build:dev | ||
npm run build:prod | ||
npm run generate:tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the Build job, which saves us ~56 seconds in terms of combined CI time wrt CodeQL and Build Workflows
But why this change? Our package.json
has a "postInstall"
script here, https://github.com/3dmol/3Dmol.js/blob/master/package.json#L33 which runs npm run build
upon installation of dependencies. Till now we were running a redundant job, hence removed the same
postInstall
running after installation of dependencies
With Build Job = +28 seconds - Which was Duplicated by the above postInstall
script
Signed-off-by: Adithya Krishna <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #695 +/- ##
=======================================
Coverage 83.01% 83.01%
=======================================
Files 141 141
Lines 11450 11450
Branches 2112 2112
=======================================
Hits 9505 9505
Misses 1613 1613
Partials 332 332
|
Signed-off-by: Adithya Krishna <[email protected]>
Signed-off-by: Adithya Krishna <[email protected]>
Signed-off-by: Adithya Krishna <[email protected]>
@@ -1,4 +1,3 @@ | |||
/* eslint-disable no-undef*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is here for a reason - so VS code doesn't report errors where there are none.
Description:
More Info: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-citation-files
The citation file adds something like this on the side menu