-
Notifications
You must be signed in to change notification settings - Fork 0
[Feat/#30] 연관 관광지 정보 저장 #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedAn error occurred during the review process. Please try again later. Walkthrough관광지 연관관광지 정보를 저장하기 위한 신규 기능이 대규모로 추가되었습니다. 연관관광지 DTO, 엔티티, 매퍼, 서비스, 저장 로직 및 관련 저장소가 도입되었으며, 기존 컨트롤러의 불필요한 엔드포인트가 제거되고, 에러 상태가 확장되었습니다. 일부 저장소 인터페이스와 패키지 구조도 정비되었습니다. Changes
Sequence Diagram(s)sequenceDiagram
participant TourSpotService
participant AddressCache
participant TourSpotRelatedService
participant TourSpotRepository
participant TourSpotRelatedMapper
participant TourSpotRelatedRepository
TourSpotService->>AddressCache: getAllAddress()
loop 각 address
TourSpotService->>TourSpotRelatedService: fetchRelatedTourSpotData(areaId, tourSpotName)
TourSpotRelatedService->>API: GET 연관관광지 외부 API
API-->>TourSpotRelatedService: JSON 응답
TourSpotRelatedService-->>TourSpotService: CompletableFuture<TourSpotRelatedDto>
end
TourSpotService->>TourSpotRepository: findByName(관광지명)
loop 각 연관관광지명
TourSpotService->>TourSpotRepository: findByName(연관관광지명)
TourSpotService->>TourSpotRelatedMapper: toEntity(현관광지, 연관관광지)
end
TourSpotService->>TourSpot: updateTourSpotRelated(연관관광지목록)
TourSpotService->>TourSpotRepository: save(관광지)
Estimated code review effort4 (~90분) Suggested labels
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
# Conflicts: # src/main/java/com/opendata/domain/tourspot/service/TourSpotService.java
| @GetMapping("/organ") | ||
| public ResponseEntity<List<Void>> getOrganArea() | ||
| { | ||
| tourSpotService.fetchAllOrganTourSpotAndSave(); | ||
| return ResponseEntity.ok().build(); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ApiResponse 사용
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요거 지웠음
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 그렇네 ㅇㅋㅇㅋ
| @GetMapping("/organ") | ||
| public ResponseEntity<List<Void>> getOrganArea() | ||
| { | ||
| tourSpotService.fetchAllOrganTourSpotAndSave(); | ||
| return ResponseEntity.ok().build(); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 그렇네 ㅇㅋㅇㅋ
📌 PR 개요
✅ 변경사항
🔍 체크리스트
📎 관련 이슈
Closes #30
💬 기타 참고사항
-> 따라서 관광지 5개를 모두 저장하려면
Summary by CodeRabbit
신규 기능
버그 수정 및 개선
기타